These are chat archives for codexa/firetext

22nd
Nov 2015
Joshua Smith
@joshua-s
Nov 22 2015 00:16
Which fonts should we include?
Or, should the selector just show generic fonts (e.g. serif, sans-serif, etc...)
Joshua Smith
@joshua-s
Nov 22 2015 00:32
How would I title each?
Daniel Huigens
@twiss
Nov 22 2015 00:36
I'd say with the first one in each list. To be fancy you could also give the option the font style, like the element selector, even though not many browsers support it
Joshua Smith
@joshua-s
Nov 22 2015 00:37
+1!
Joshua Smith
@joshua-s
Nov 22 2015 02:53
How do I send the current font back to the editor?
Nevermind :)
Joshua Smith
@joshua-s
Nov 22 2015 03:11
7 more commits until we hit 1000!!!
:cake:
Joshua Smith
@joshua-s
Nov 22 2015 03:17
@twiss we might want to implement a feature that automatically removes previews from the dom when they aren't in the viewport
(to improve performance)
It would replace them with dummy elements to preserve scroll heights
I could look into this if you want
Daniel Huigens
@twiss
Nov 22 2015 12:32
Go ahead. You could just add an else / else if case to this, you shouldn't even need a dummy element. If you want you could even move this check into the forEach and remove previews if they are disabled. The only thing I would check is if external images in documents are downloaded twice if the iframe is removed from the document in between, and decide if that's worth it. By default previews are only enabled on wifi, so it may be.