These are chat archives for codexa/firetext

3rd
Dec 2015
Daniel Huigens
@twiss
Dec 03 2015 02:09
I think we're kind of done for release, what do you think?
Joshua Smith
@joshua-s
Dec 03 2015 02:54
Lets do one testing round
I'll test from 1.2 to 2.6.
Once that's done, we can pull in translations
And then release :) :) :)
:shipit:
Daniel Huigens
@twiss
Dec 03 2015 02:55
^^
Joshua Smith
@joshua-s
Dec 03 2015 04:24
Actually, is it ok if we do 1.3+?
I don't know any devices still on 1.2
Daniel Huigens
@twiss
Dec 03 2015 04:24
Sure, does something not work on 1.2?
Joshua Smith
@joshua-s
Dec 03 2015 04:25
My simulator doesn't work
If you could test it, that would be great
Also, I don't think many people adopted it
Daniel Huigens
@twiss
Dec 03 2015 04:30
Alright, well, I'd have to install the old simulator thing as well, so I'm fine with that.
Daniel Huigens
@twiss
Dec 03 2015 04:40
The thing with the showing documents after we scroll in is there's a delay (throttle) of 300 ms. It was meant for the getting previews part, not sure if it helps with anything. But it makes things seems slow even if they aren't. Does it help with performance?
Joshua Smith
@joshua-s
Dec 03 2015 04:42
It does not help on the flame
However, it might assist if the hide/show logic is disconnected
I should have noticed that while implementing
Daniel Huigens
@twiss
Dec 03 2015 04:44
Disconnected from?
Joshua Smith
@joshua-s
Dec 03 2015 04:44
Does the 300 ms throttle affect the hide/show functionality?
Or, just the preview loading?
Daniel Huigens
@twiss
Dec 03 2015 04:44
Both
Joshua Smith
@joshua-s
Dec 03 2015 04:45
It should only affect the loading
Where is it located in the code?
Daniel Huigens
@twiss
Dec 03 2015 04:46
The entire updatePreviews function is wrapped in calls to throttle
Joshua Smith
@joshua-s
Dec 03 2015 04:50
I see it now.
Joshua Smith
@joshua-s
Dec 03 2015 05:06
What if we moved the throttle to line 694 inside the updatePreviews() function?
Also, does the function have benefits over a vanilla timeout?
Joshua Smith
@joshua-s
Dec 03 2015 05:15
I'm going to bed now
I'll work on it tomorrow
Daniel Huigens
@twiss
Dec 03 2015 05:15
Alrighty, good night, I'll answer the questions below
The difference is that throttle calls the function at most once every 300 ms. Again I haven't tested without, so I don't know if it really helps with anything but it might.
The easiest way to seperate them might be to duplicate a little bit of the code (the function and the visibility check) and throttle one and not the other
Daniel Huigens
@twiss
Dec 03 2015 05:21
But it might be better to just hide the iframe instead of the item
Or yeah, you could throttle just the getting previews (even line 700 in updatePreviews). That might be a good idea in any case. But I'd say just test it out and see what works.
Joshua Smith
@joshua-s
Dec 03 2015 14:48
So, it looks like Firefox OS is quickest without the showing/hiding
Joshua Smith
@joshua-s
Dec 03 2015 15:14
I don't know if the same is true on desktop
Joshua Smith
@joshua-s
Dec 03 2015 15:22
I left the scrollDocList() function in the code just in case
Joshua Smith
@joshua-s
Dec 03 2015 18:35
I just landed a setting logic refactor
Now, if a user does not change a setting, we don't save it. Thus if we decide to default to another option in the future (e.g. night mode auto -> night mode always off), the users who haven't selected an option will see the new default
If we want, we can also establish different mobile and desktop defaults.
One question: can this new update purge the users' old preferences?
That would maximize the benefit of the new structure. Otherwise, only new users would benefit
Or, maybe a partial purge? E.g. whatever is set to a non-default for the last version is preserved.
Daniel Huigens
@twiss
Dec 03 2015 19:06
Yeah, I think you can purge settings that are set to the current default.
Joshua Smith
@joshua-s
Dec 03 2015 19:06
Fabulous!
I'm quickly revising some server logic
Daniel Huigens
@twiss
Dec 03 2015 19:06
You could also not save settings when the user changes it back to the default, i.e. remove it from localStorage
Joshua Smith
@joshua-s
Dec 03 2015 19:06
So we can dynamically push links and notifications
We should have a reset button
That's a good idea