These are chat archives for codexa/firetext

4th
Dec 2015
Joshua Smith
@joshua-s
Dec 04 2015 03:46

Current defaults:

"autoload": "false",
"autosave": "true",
"autosaveNotification": "true",
"dropbox.enabled": "false",
"language": "auto",
"nightmode": "false",
"previews.enabled": "auto",
"stats.enabled": "true"
This message was deleted
Joshua Smith
@joshua-s
Dec 04 2015 03:51
IMO, we should reset the values of these settings if they equal the previous defaults. In addition, we should completely reset the following:
  • previews.enabled
  • nightmode
  • language
What do you think?
One note: should we leave stats.enabled as-is?
Daniel Huigens
@twiss
Dec 04 2015 03:53
I don't know, what's with those?
Joshua Smith
@joshua-s
Dec 04 2015 03:59

Actually, resetting defaults might cover those.

previews.enabled:
"true" -> "auto"
"false" -> "never"

nightmode:
"auto" -> "off"
"off" -> "off"
"on" -> "on"
In the case of language, I am concerned that the app explicitly saved the locale before we implemented "auto"
In most cases, the reset should not change anything since "auto" will take the system locale
If it is wrong, the user will change it
Do you agree?
Daniel Huigens
@twiss
Dec 04 2015 04:06
I'm not sure, it might be a little bit better for some users, and worse for the people who changed the setting. I would leave it like it is.
Joshua Smith
@joshua-s
Dec 04 2015 04:14
Which?
One other note: people who changed the setting once probably know how to change it again
^ this may or may not be relevant
Daniel Huigens
@twiss
Dec 04 2015 04:22
The language setting. Yeah, they know how, but I always hear people complain about Firefox resetting their prefs, and I don't think there are many people whose navigator.language has changed, and would much prefer the new value to the old one.
Joshua Smith
@joshua-s
Dec 04 2015 04:24
Ok!
Daniel Huigens
@twiss
Dec 04 2015 04:24
The property changed in Firefox 5, if that makes a difference
To mean preferred language instead of browser UI language
But I don't think FFOS existed back then, I might be wrong
Joshua Smith
@joshua-s
Dec 04 2015 04:27
Would it be ok to reset the language pref if and only if the saved pref = navigator.language?

By doing so:

  • Users who specifically selected a different language for firetext than for the system would retain their choice
  • Users who have not touched their language preference, or who have set it back to their system-wide locale will benefit from the "auto" preference.

Neither would experience a visual change

Daniel Huigens
@twiss
Dec 04 2015 04:34
Yeah, sure. But it's still tricky to figure out whether changing to auto would change the language, because the language depends on navigator.languages and the available languages as well.
Joshua Smith
@joshua-s
Dec 04 2015 04:35
So, it might be best to stay away from that pref then
Ok then. What about the others?
Daniel Huigens
@twiss
Dec 04 2015 04:36
What was with stats.enabled?
Joshua Smith
@joshua-s
Dec 04 2015 04:36
What does it do?
Daniel Huigens
@twiss
Dec 04 2015 04:36
:p You created it, not me
Joshua Smith
@joshua-s
Dec 04 2015 04:37
Is that what you're asking?
Daniel Huigens
@twiss
Dec 04 2015 04:37
No, you asked: should we leave stats.enabled as-is
What should we change?
Joshua Smith
@joshua-s
Dec 04 2015 04:37
stats.enabled controls error reporting to splunk mint
It defaults to "true" in the last version and in the present version.
I was wondering if we could empty the explicit setting if it equals the default
Daniel Huigens
@twiss
Dec 04 2015 04:39
Oh, yeah, definitely
Joshua Smith
@joshua-s
Dec 04 2015 04:39
With the other settings it seems fine, but error reporting is touchy ;)
Daniel Huigens
@twiss
Dec 04 2015 04:39
What could go wrong?
Joshua Smith
@joshua-s
Dec 04 2015 04:40
I guess nothing since the only change we could do would be to set it to "false" by default.
I'll proceed :)
Daniel Huigens
@twiss
Dec 04 2015 04:41
Well, yeah, it might be a problem if we ever increase the default amount of logging
But even then I think it's not a problem
Joshua Smith
@joshua-s
Dec 04 2015 04:45
Ok!
Joshua Smith
@joshua-s
Dec 04 2015 05:17
Did you find any other bugs in your testing?
If not, we can ship once I land the new server and settings
(both should be done tomorrow)
Daniel Huigens
@twiss
Dec 04 2015 06:27
Maybe this is an issue: if you resize a desktop Firetext window to mobile size, you no longer have formatting buttons
Joshua Smith
@joshua-s
Dec 04 2015 18:26
Could you check codexa/firetext@a0054e5
I don't think I introduced any bugs, but extra eyes are always handy
Daniel Huigens
@twiss
Dec 04 2015 19:54
Looks good to me