@HeyJoel, have you been running Cofoundry on ASP.NET Core 3.1 for a while now? We've been running a staging environment but at some point between 24 and 96 hours our application is depleting it's SQL connection pool it seem with this error message:
System.InvalidOperationException: Timeout expired. The timeout period elapsed prior to obtaining a connection from the pool. This may have occurred because all pooled connections were in use and max pool size was reached.
at Microsoft.Data.Common.ADP.ExceptionWithStackTrace(Exception e)
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.OpenDbConnectionAsync(Boolean errorsExpected, CancellationToken cancellationToken)
at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.OpenDbConnectionAsync(Boolean errorsExpected, CancellationToken cancellationToken)
at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.OpenAsync(CancellationToken cancellationToken, Boolean errorsExpected)
at Microsoft.EntityFrameworkCore.Storage.RelationalCommand.ExecuteReaderAsync(RelationalCommandParameterObject parameterObject, CancellationToken cancellationToken)
at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable`1.AsyncEnumerator.InitializeReaderAsync(DbContext _, Boolean result, CancellationToken cancellationToken)
at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerExecutionStrategy.ExecuteAsync[TState,TResult](TState state, Func`4 operation, Func`4 verifySucceeded, CancellationToken cancellationToken)
at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable`1.AsyncEnumerator.MoveNextAsync()This also happens with an application that's not really being used, and it didn't before on .NET Core 2.2. Any clues?
It stops working until at some point the connection pool seems to free up in itself. Although I'n not 100% sure yet. I'm investigating whether I should auto-restart these pods or that they recover by themselves. On the plus side, I do have the distributed Redis cache working, so I can now run multiple copies of that site successfully. :wink:
The problem was already there with the InMemory cache though.
I have another stack trace here: https://gist.github.com/Qonstrukt/419d67f5b0bc8582b26dcf3e0501ff6c
But I don't think it's gonna help much since it happens whenever the connection pool is exhausted, so it happens in a lot of different instances.
Some extra questions so I can rule a few things out:
- Are you seeing this using the logs in the
ErrorLoggingplugin? - Are you using any other data access other than Cofoundry? (I expect EF uses the same underlying ADO connection pool)
- Are yo using the Hangfire background tasks plugin?
- How much traffic are you experiencing? Roughly - e.g. a couple of test users
Also, what platform / db are you using - sounds like K8s / linux?
- No, this Is console output, because it also fails to save logs to the database at this stage.
- No, the only other connections we make is to some Azure services and a Redis cluster.
- No
- It's staging, so hardly any traffic besides a health check every 5 seconds
It will use the default which should be more than enough. I don't think anything much changed in the 3.1 migration from our perspective, but there's always big under-the-cover changes in EF and ASP.NET that might impact something. It will probably be a while for me to look into this one.
Well, the ErrorLogging plugin is much neglected and if it's only picked up in logging I probably won't have seen it if it has occured. I'll need to have a dig around. Is it a recurring issues for you? If it was a one-off Azure-wobble you might see connection timeouts that could lead to pool exhaution.
I updated the gist with a full request log: https://gist.github.com/Qonstrukt/419d67f5b0bc8582b26dcf3e0501ff6c
You can see the
Cofoundry.Plugins.ErrorLogging.Data.ErrorLoggingDbContext throwing the error, but that might be very well caused by something else first throwing the error. The fact that it uses a different DB context is interesting though.
Can you take out the error logging package?
I suspect you might find that fixes that error (and exposes a new one), but if not, this article seems to have some good info on tracking down issues with connectons https://sqlperformance.com/2017/07/sql-performance/find-database-connection-leaks
I want to create a link to a page that may not exists so for example. I have a Product called WidgetA The users want to promote this product so they would create a custom page that is specific to that product. How would I check that the custom product page exists if so render that page otherwise, render a default page? Ideally, both would be manageable within the Pages area of the admin so the user can add a Header and Footer section to the default, but the contents would be rendered based on the product for the default page, whereas the custom page is the custom all the way and no Page-level model would be needed. I think it is here https://www.cofoundry.org/docs/content-management/custom-entity-pages but not understanding this vs Page and Page Types.
What I have is a situation where Widget-A will have a customized page with custom content and Widget-B, we just do not want to setup a custom page for Widget B and instead use values from a database and a default page template. So Widget-A would have a Page and Widget-B to Widget -Z would use the Page that is marked default.
So, if I understand correctly, Widget A can be a normal custom (non CMS) page? CMS routing kicks in last in the pipeline, so you should be able to register a normal MVC route for that if you don't need any CMS content. The other pages you can handle as normal with a custom entity page (as you referenced earlier).
Hello there, is there anyway to get the default mailing to call an api service? For example when I add a user on the admin side I would like to be able to make an api call with the generated template. Or is there some way to intercept that mailing process when new users are added?
Hi there Guys. I picked up a small issue inthe pagetemplate handler. the class GetPageTemplateDetailsByIdQueryHandler line 58 .GroupBy(v => v.PageId) , this causes an issue when querying metadata for pagetemplates and the line can be removed to solve the problem as there should be no group by on a non aggregate field., thought I would just share.
Eithere then that, enjoying your work :)
Thanks @technical2cents for letting us know. The group by is required for the correct stats, but EF doesn't work well with GroupBy anymore. The fixed query should be:
queryModel.NumPages = await _dbContext
.PageVersions
.AsNoTracking()
.Where(v => v.PageTemplateId == query.PageTemplateId)
.Select(v => v.Page)
.Distinct()
.CountAsync();I've committed the fix, thank you!
Hi guys, has anyone successfully ran the ASP.NET identity alongside the Cofoundry v0.7 in .NET core 3.1? First the authentication urls don't load, I fixed it by add "routeBuilder.MapRazorPages();" in my RouteRegistration. Second, after I got the login screen, the user/password works, but I got redicted back to an unauthorised page after a successful login. Removed the Cofoundry pipeline and all back to work normally.
Presumably there’s a reason you’re not using the Cofoundry user areas i.e. you’re running another application alongside Cofoundry? There’s no guidance here, but you’d probably need to override the Cofoundry auth startup task and modify it to your needs. I don’t have my laptop to hand so can’t look it up.
I was looking at making this area more configurable earlier in the year, so some feedback on your use-case would be helpful.
@HeyJoel Thanks. I am trying to add Cofoundry to an in-house ecommerce site that already has .Net core Identity for customers and admins. It is probably too hard to migrate my users to Cofoundry as there are too many changes. My client wants to be able to edit some contents on the site and create news items and updates. I like how Cofoundry works and it is relatively small footprint (compare with Orchard Core or Piranha). Ideally I would like all .Net core Identity users in "Admins" role can access the CMS admin portal and can do everything they want, but I can live with a seperate login system for CMS.
@adamy that makes sense, it doesn't seem that uncommon to want to run a CMS alongside another application and it's something that's possible, but it's not straightforward. First off, I'm not very familiar with Identity, and it's been redesigned a few times since I last used it, so I can't help you too much on that part.
Secondly, I expect you'll need to override the way Cofoundry configures the auth at startup, this issue is a little old, but has the basic idea. Have a look at the source for DefaultAuthConfiguration.cs in the latest release to see what it currently does and what you'll need to override. the interface to override is
IAuthConfiguration and the docs for DI tell you how to override stuff. If you need to inject anything into the startup pipeline the docs for that are here
Thirdly, if you want to integrate your existing logins into Cofoundry, I think you'll need to have a custom login endpoint that manages the single sign on. In the above auth configuration you could set the
LoginPath to your SSO script. Your SSO script would have to use the Cofoundry data APIs to create a Cofoundry user if it doesn't exist and log them in. The SPA Sample shows how you can use the data APIs, in particular the RegisterMemberAndLogInCommandHandler
As mentioned before, we'd like to make customizing the configuration of the 2nd part easier. People want to do lots of different things here so it's difficult, but we can definitely do better.
I have a class that will return a list of Page Directories for a select list in the DataModel
public class PageDirectoryOptionSource : IListOptionSource
{
private CofoundryDbContext dbContext;
public PageDirectoryOptionSource(CofoundryDbContext dbContext)
{
this.dbContext = dbContext;
}
public ICollection<ListOption> Create()
{
return (from p in dbContext.PageDirectories select new ListOption(p.Name, p.PageDirectoryId)).ToArray();
}
}It will not inject the CofoundryDbContext. What alternative do I have build a list for the user based on information stored in the Cofoundry database? or What would be the best way to build a table of contents based on Page Directory?
@sremiger1 have you looked at the menu sample project? https://github.com/cofoundry-cms/Cofoundry.Samples.Menus
Having this issue with hosting on an Azure App Service - I developed a Custom Entity similar to the Blog Post examples. After I publish a new custom entity, and not logged into Cofoundry - I see this error in the log when browsing to the root of the site or any of the post NOT logged in. I can login into the admin but when the site begins to behave like this, I can no longer go into the Custom Entities settings. The same error below occurs. I have seen some behavior with deleting the cookies specifically the ARRAFINITY cookies. This does not occur every when running locally.
Main
MESSAGE:
Entity of type 'Cofoundry.Domain.CustomEntityRoute' and identifier '2' could not be found.