Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Alok Kumar
    @iFlameing
    @datakurre I am currently writing a test for breadcrumbs node. I will make a pr tomorrow and start exploring with the async-lock npm and without it.
    Asko Soukka
    @datakurre
    @iFlameing Thanks. Obviously you should finish your current test tasks first, because every new test protects from regression.
    Alok Kumar
    @iFlameing
    @datakurre I am able to complete these test earlier but writing test for makecontentNode takes lot's of time
    I have to read lot's of code and understand it to make the mock data :)
    Asko Soukka
    @datakurre
    No problem. I'm happy that we were able to use a complete GSOC phase for testing.
    Btw, when I get some new acceptance tests merged I will also rename folder "tests/gatsby-starter-default" to just "example".
    Alok Kumar
    @iFlameing
    @datakurre can we name something like demo because It is more suitable and Gatsby community also following this?
    Asko Soukka
    @datakurre
    @iFlameing Ok. I'll name it "demo" then if that's used elsewhere.
    Anything is better than the current :)
    Alok Kumar
    @iFlameing
    @datakurre In the recent release of Gatsby theme, they named most of them as demo .
    Asko Soukka
    @datakurre
    @iFlameing Thanks for following that.
    Alok Kumar
    @iFlameing
    @datakurre I am going to bed because it is around 1:30 am in my timezone. gdnight :)
    Asko Soukka
    @datakurre
    Good night!
    Asko Soukka
    @datakurre

    I have now added some acceptance tests that do "black box testing" that your GSOC additions update gatsby develop when pages are deleted, modified or added.

    Example run starting from line 1222 at output log of https://travis-ci.org/collective/gatsby-source-plone/jobs/561341455

    MVP code is a bit noisy, but hopefully you have time to refactor and cleanup the code in the last part of GSOC once all planned unit tests have been written.
    Tests in question are here but (in my opinion) that test setup is outside the scope of this GSOC https://github.com/collective/gatsby-source-plone/blob/master/demo/test-updates.robot#L58
    It's old-school Makefile/bash-scripting to start everything in parallel and then uses Selenium with Robot Framework (and its JSON REST test library) to call Plone REST API and test the changes in gatsby develop site.
    Alok Kumar
    @iFlameing
    @datakurre ok, I have submitted the 2nd evaluation form :)
    Asko Soukka
    @datakurre
    Me too :)
    And I got my GatsbyJS fix merged gatsbyjs/gatsby#15919
    Alok Kumar
    @iFlameing
    @datakurre That's great. As you provided the feedback I have to implement the separate function for all the WebSocket event. And write the documentation for WebSocket configuration. I think that random call of API is fixed now? which you mention in the feedback :)
    Asko Soukka
    @datakurre
    @iFlameing Yes. The API call order issue was fixed. Thanks.
    Asko Soukka
    @datakurre

    I cannot say, into how small functions you should refactor the code. Something that looks clean and easily understandable. Something you could be proud to say you wrote it.

    After refactoring and updating the documentation (probably the MD-files in docs-folder is enough; updating the Plone site fixture requires use of Plone), it's up to you if you'd like to do some stretch goals (websocket reconnection, logging refactoring, or more) or just try

    or just try to test the new functions.

    @iFlameing I wrote a small update https://community.plone.org/t/gsoc-2019-gatsbyjs-preview-for-plone/8535/8

    Feel free to add about your experience if you want to :)

    Alok Kumar
    @iFlameing
    @datakurre I will write my experience in the last. Just one thing I want to attend the Plone Conf 2019 and give a talk if Plone Community gives me a chance to speak!
    Alok Kumar
    @iFlameing
    @datakurre My college is situated in Jammu and Kashmir region and there is an intelligence report that some militant activity is going in Kashmir so the government might shut down the internet service for one week because Our Independence day is on 15th of August. I might not able to use the Internet these days. I will send the pr for all the feature once if Internet Service will be down if not then I continue posting the pr as I have done it.
    Asko Soukka
    @datakurre
    @iFlameing That’s ok. Thank you for warning about that before hand.
    Asko Soukka
    @datakurre
    @iFlameing How does the rest of the GSOC look for you? Has your internet connection been ok for now?
    I see you have started working on WebSocket re-connection. That would be great to have. My idea is to have "gatsby develop" -servers with this new plugin running as a long-running services and it would be pity if we should remember to restart them every time Plone sites do restart for a reason or another.
    I assume that this is probably the last issue you are able to do and then you should probably focus on wrapping up and collecting all of your pull requests into a report.
    Alok Kumar
    @iFlameing
    @datakurre I moved from Jammu & Kashmir to New Delhi so that I have better connectivity throughout the GSoC period. I am looking forward to solving this issue and start writing the report for the final evaluation. My college is started but the internet is still not working there. Side talk not related to the project. I am at my brother house in New Delhi and I will return to the college when internet service starts. Currently, I am having a good time because I am with my family and celebrating the festival "Raksha Bandhan with them after 3years because at this time my college doesn't give us leave". Thanks for the previous year report link :)
    Asko Soukka
    @datakurre
    Good to hear that you have managed to combine GSOC, good connectivity and family reunion!
    @iFlameing I'm now finally trying out the reconnection code....
    Asko Soukka
    @datakurre
    @iFlameing I will review the websocket pull again on Tuesday evening and also comment the report then. So, no hurry. You are well on schedule.
    Alok Kumar
    @iFlameing
    @datakurre thanks!
    Alok Kumar
    @iFlameing
    @datakurre I submitted the final evaluation :)
    Asko Soukka
    @datakurre

    @iFlameing Thank you a lot for your hard work (and learning new things while doing that)!

    It's been a pleasure to work with you and follow how you and your code improved during the summer.

    I will pass the last evaluation for you so you can prepare to write your GSOC completion post to community.plone.org :)

    FYI. I might have a GatsbyJS related talk at the Plone Conference, but I will focus on the greater picture: where Plone excels with GatbyJS and probably present same use cases of my own.
    Alok Kumar
    @iFlameing
    @datakurre thank you !!! Can you provide me feedback regarding where I can improve myself like communication skill, technical skills etc.
    @datakurre I also want to attend the Plone conference. Can you help me how I can attend it?
    Asko Soukka
    @datakurre

    @iFlameing About PloneConf, try to ask Cris Ewing about it at https://community.plone.org via private message.

    Previously, when Plone Foundation was on GSOC on its own, it was possible for the foundation to use the GSOC funds from Google to sponsor students' trip to the conference.

    Now, under PSF, I don't really know.

    Asko Soukka
    @datakurre

    @iFlameing About feedback, communication really depends on team and project, but I really believe that issues and pull requests are the best way to communicate with open source projects. And you learned that well during the summer.

    In technical skills, learning typescript could be the next logical step. It seems to be popping up everywhere. (Personally, for standalone project, I would prefer Elm language, but typescript seems to be the currently chosen one for JavaScript community.)

    I hope you benefit from you GatsbyJS experience later. Plone is thougher one, because even there are still big Plone users and many consulting firms in Europe it has not really attracted new users. gatsby-source-plone helps existing Plone users to benefit from Plone, but might not make new users to choose Plone over something simpler.
    Alok Kumar
    @iFlameing
    Thank you !! For the information. Can we do a Hangout session whenever you are free?
    Alok Kumar
    @iFlameing
    @datakurre thanks for the detailed feedback in the final evaluation. Thank you very much :)
    Asko Soukka
    @datakurre

    @iFlameing Thank you!

    I'm sorry for not being able to hangout. We had the beginning of a new semester in our university with some new information systems in use, so the last month has been extremely busy for me.

    Alok Kumar
    @iFlameing
    @datakurre Never mind I can wait till you become free from work. Since gsoc is over I am searching for some contract work remote. Can you suggest me someplace where should I apply and where not?
    Alok Kumar
    @iFlameing
    I have some experience other than gsoc. I am collaborator of taskluster and contributor of Iodide both of them are Mozilla project.