These are chat archives for collectiveaccess/support

27th
Oct 2017
yelto
@yelto
Oct 27 2017 14:51
Hello, quick very low-level question: on reviewing the last months of commits, it appears that many changes come with spaces instead of tabs for indentation, even in files originally all tabs. Oversight or policy change?
CollectiveAccess
@collectiveaccess
Oct 27 2017 15:56
I was not aware of that. There's no policy.
yelto
@yelto
Oct 27 2017 16:25
You probably use tab-width 4, which hides the issue. The code seems mostly TAB, either way is fine when it's consistent at least file by file. I can probably whip up a pull request over the w.e. to revert to TABs the spaces in TAB-based files, if there is interest.
Kehan Harman
@kehh
Oct 27 2017 16:46
@yelto if you do that it's worth adding a .editorconfig http://editorconfig.org/
yelto
@yelto
Oct 27 2017 17:30
@kehh Hm, I didn't mean to open a code-formatting can of worms, and .editorconfig and the ilk are too close to policy-setting, which is better left to @collectiveaccess and co. I was just going to replace 4 spaces by tab where 4 spaces have been introduced in tab-based files, but given some guidelines I could do more...
CollectiveAccess
@collectiveaccess
Oct 27 2017 19:31
Well I'm a tab person myself, not that I've ever given it a whole lot of thought. If someone wants to create and .editorconfig go for it it. Otherwise I'll do it. Same for replacing spaces with tabs. It's easy enough to do it if matters to you
yelto
@yelto
Oct 27 2017 20:37
Ok, tabs it is then.