Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Margaret Clinard
    @margaretclinard
    blob
    Katye Russell
    @complikatyed
    I thought the lettuce popped more with the blue, but I'm good with either color.
    Margaret Clinard
    @margaretclinard
    lol
    Katye Russell
    @complikatyed
    Okay, I made a version of the play again button that refreshes the page -- it's not exactly a button anymore, but I'm going to add and push it to my branch.
    Andy Meagher
    @AndyMeagher
    hey are either of you there?
    Andy Meagher
    @AndyMeagher
    I got it all working I think
    I'm going to pull Katyes styling onto my branch
    Andy Meagher
    @AndyMeagher
    OK I pushed my branch up. It has Katye's styles and once someone wins it won't let you click another square and appends who the winner is up top. Maybe you can try to pull my branch? or if the conflicts are confusing, you can just copy and paste the code on my branch. I changed the Table class names and stuff so that may be confusing
    Katye Russell
    @complikatyed
    Whoa! That's cool, Andy! I'll go pull from your branch now.
    Andy Meagher
    @AndyMeagher
    lemme know if it works!
    Katye Russell
    @complikatyed
    ANDY! That's amazing! Can we incorporate Margaret's styling, too?
    Andy Meagher
    @AndyMeagher
    yeah i think so!
    just gotta figure out how we want it to look I guess
    but did you have trouble getting onto my branch or is it all working ok?
    Katye Russell
    @complikatyed
    Also, my daughter wants to know what happens if no one wins. I wonder if we could add to your function so that if NONE of the win variables are true, the "Don't Taco 'Bout It" image from Margaret's game over page shows?
    It seems to be fine.
    Andy Meagher
    @AndyMeagher
    ohh yeah try it out, it has a TIE alert right now
    instead of saying it's a tie we can do the don't taco bout it
    Katye Russell
    @complikatyed
    Not seeing the tie alert. How long ago did you add that part?
    Andy Meagher
    @AndyMeagher
    hmmm maybe that broke, lemme check it out
    Katye Russell
    @complikatyed
    I don't even see the code for it. What line would it be on?
    Andy Meagher
    @AndyMeagher
    Oh i had a misspelling
    Katye Russell
    @complikatyed
    And I just found the code. Lol.
    Andy Meagher
    @AndyMeagher
    hmm ok I'll push that fix up..it's line 79
    it should say oWin == false
    I didn't capitalize the W
    Katye Russell
    @complikatyed
    Okay, corrected it over here, too.
    Andy Meagher
    @AndyMeagher
    ok see if the tie works now
    Katye Russell
    @complikatyed
    _
    Hey, since you have oWin and xWin, would it make sense to change the player variables to playerX and playerO, instead of 1 & 2? For the sake of clarity?
    Andy Meagher
    @AndyMeagher
    or make it p1Win p2Win since we're not using x's and o's
    Katye Russell
    @complikatyed
    Yeah, that would definitely work too (and maybe fewer variables to change). You okay with that switch?
    Andy Meagher
    @AndyMeagher
    yeah, I'll do it right now and push it. I have a good sense at where those variables are
    Katye Russell
    @complikatyed
    Sounds great. I'm so impressed with how this is working!
    Andy Meagher
    @AndyMeagher
    yeah it's really not that complicated. I can walk through the javascript with you if you'd like
    as for making it two player game on firebase...that still sounds confuses the hell outta me. but at least we did the initial assignment
    k pushed up the changes to those variables
    Katye Russell
    @complikatyed
    I think I get the javascript -- maybe one or two questions, but I'm puzzling through it. I added comments to explain the different functions and changed "checkTurn" to "checkTie" (since that's what the function is really doing now). I'll push in just a sec.
    ...once I make sure I didn't break anything...
    Andy Meagher
    @AndyMeagher
    ok sounds good, I'm gonna run some errands class, but see you soon!
    Katye Russell
    @complikatyed
    Okay, changes made. Nothing broken. Pushing now.I really like Margaret's new game and play buttons, so I think I'll grab them.
    Margaret Clinard
    @margaretclinard
    Wow! Nice work!!
    Katye Russell
    @complikatyed
    Hi Margaret!
    I just pulled your code up and I'm sorting through merge conflicts. Your version of restarting a new game is so much more elegant than mine, but I think I may need your help to get it placed correctly, so I'm just commenting out stuff as I merge (instead of deleting anything).
    _
    Can we look at it together at some point?
    Margaret Clinard
    @margaretclinard
    yep! that's fine
    Katye Russell
    @complikatyed
    Okay, I think I merged all three of our contributions and it's working GREAT! I'm going to push up to master so we can show it if Scott is looking for it on GH.
    _
    Now "all" we have to do is the firebase part...
    Katye Russell
    @complikatyed
    I just had an idea -- what if we highlight the winner's winning squares? I think I have a way to do it using the code Andy set up to detect the win. Headed to NSS now; everything else is on the master and ready to show.
    Katye Russell
    @complikatyed
    _
    I got the board values (in Firebase) to update with each 'play' -- as part of the '''$('td').one('click', function''' -- but we need to grab the uid to automate the process, and I'm shaky on how to do that. I've pushed the code to my branch so you can see it, and I've added you to my "xogame" on firebase so you can also mess with that data if you want.
    Nina Isabelle R.
    @NinaIsabelle
    I created a tic tac toe game using html / css / and javascript , but once there are three X's or O's what function could I include in my script to have the server return either "You Won!" or "You , better luck next time"....any tips ? Please.