Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 02:20

    arcturus2 on stale-workflow

    (compare)

  • 02:20

    arcturus2 on master

    :green_heart: Stale detection a… Merge pull request #385 from co… (compare)

  • 02:20
    arcturus2 closed #385
  • 00:57
    Travis constellation-app/constellation (Layers_view-NB11) still failing (594)
  • 00:56
    sol695510 commented #360
  • 00:53
    formalhaut69 commented #280
  • 00:47

    aldebaran30701 on Layers_view-NB11

    Remove accidental addition (compare)

  • 00:37
    sol695510 commented #360
  • 00:34
    Travis constellation-app/constellation (Layers_view-NB11) still failing (593)
  • 00:23

    aldebaran30701 on Layers_view-NB11

    Change query split - Create p… (compare)

  • 00:14
    Travis constellation-app/constellation (Layers_view-NB11) broken (592)
  • 00:12

    aldebaran30701 on Layers_view-NB11

    Fix bug with transactions and q… (compare)

  • 00:07
    sol695510 commented #360
  • Mar 31 23:56
    sonarcloud[bot] commented #360
  • Mar 31 23:56
    sonarcloud[bot] commented #360
  • Mar 31 23:45
    sol695510 synchronize #360
  • Mar 31 23:45

    sol695510 on RULE-(Java)-Empty-arrays

    SonarCloud Code Smells Fix (compare)

  • Mar 31 23:35
    sonarcloud[bot] commented #360
  • Mar 31 23:23
    sol695510 synchronize #360
  • Mar 31 23:23

    sol695510 on RULE-(Java)-Empty-arrays

    Modified Null checks regarding … (compare)

antares1470
@antares1470
i approved it. should probably ensure all PR's looking to merge in have been handled 1st though
arcturus2
@arcturus2
thanks @antares1470. I can repoint open PRs to master so that will be ok.
the only thing is the sha256 issue which @cygnus-x-1 is looking at now.
i'll wait
antares1470
@antares1470
ah cool. nvm on the PR's then
cygnus-x-1
@cygnus-x-1
sha256 issue is fixed - pr awaiting your review @arcturus2
arcturus2
@arcturus2
thanks @cygnus-x-1
arcturus2
@arcturus2
image.png
^got some peeps checking the constellation-app.com site (and it wasn't me) :smiley:
aldebaran30701
@aldebaran30701
I've just got a layers view prototype onto the current master-nb11 and updated with the SHA-256 fix. If someone wants to have a look, it is https://github.com/constellation-app/constellation/tree/Layers_view-NB11. Would appreciate any ideas and feedback.
Currently its located in the views dropdown, and you can select elements and use the right click context menu to add them to a certain layer.
arcturus2
@arcturus2
going to merge master-nb11 to master
before i do here is a snapshot of SonarQube before
image.png
merged and I've re-pointed the branches to master
antares1470
@antares1470
(As expected) Those numbers have gone down :smiley:
arcturus2
@arcturus2
image.png
aha! nice one!! here is the after screenshot
cygnus-x-1
@cygnus-x-1
0% coverage?
arcturus2
@arcturus2
a significant dip indeed - thank you everyone that contributed
image.png
special thanks to @antares1470 - :heart: ur work
aldebaran30701
@aldebaran30701
@cygnus-x-1 I've had some issues trying to rename a module, i created it as Core Layers View, but it keeps renaming itself to au.gov.asd.tac and refactor/rename does not change it back. You ever run into something similar?
cygnus-x-1
@cygnus-x-1
not exactly like that, but i have had renaming issues before
i usually do a find replace across my model (ctrl+shift+h) for the module base name
it'll get confused and close when you do that, but just re-add it to the constellation module suite and reopen it and all should be fine
arcturus2
@arcturus2
@/all just to let you know that for those working on SonarQube warnings, you don't need to close them off manually. When Sonar runs the next time it will automatically mark them as resolved.
arcturus2
@arcturus2

This is what I've put at the topic for this chat group. Let me know if you thing anything should change.

Discuss about anything Constellation with developers and users - Our current focus is migrating to NetBeans 11 & JDK 11 | Thank you for treating everyone with respect. By joining this community forum you agree to abide by our code of conduct (https://github.com/constellation-app/constellation/blob/master/CODE_OF_CONDUCT.md). Note that before you create an issue or PR please read our contribution guide (https://github.com/constellation-app/constellation/blob/master/CONTRIBUTING.md).

cygnus-x-1
@cygnus-x-1
@canis-majoris-42 what do the colors that you've used in the spreadsheet of tickets mean?
canis-majoris-42
@canis-majoris-42
Ah, Yellow is I've added it github, blue is i've added it and checked that i can recreate it, and red is i have added it but haven't been able to recreate it
(with regards to the steps to reproduce part of the issue)
cygnus-x-1
@cygnus-x-1
i'll follow that too - i've added a legend to the table so we can keep track
sol695510
@sol695510
@arcturus2 @cygnus-x-1 @antares1470 I accidentally hit push instead of pull on master on GitHub desktop but there were no changes
formalhaut69
@formalhaut69

Hey guys, I'm working on RULE (Java) Unused local variables should be removed. Not sure about the following code;

    public void actionPerformed(ActionEvent e) {

        Graph graph = context.getGraph();

        int count = 3;
        PluginSynchronizer s = new PluginSynchronizer(count);

        for (int i = 0; i < count; i++) {
            PluginExecution.withPlugin(new SynchronizerPlugin())
                    .withParameter(SynchronizerPlugin.NAME_PARAMETER_ID, "I am number " + i)
                    .interactively(true)
                    .executeLater(graph);
        }
    }

PluginSynchronizer s was picked up by sonarQube as an unused variable. PluginSynchronizer appears to be a counter to keep track of a group of plugins that need to be executed and although this object isn't read from the count might be still be used in the background. Do you guys think it'll be okay to remove it?

this code is in class SynchronizerAction

arcturus2
@arcturus2
@formalhaut69 I did a test (Experimental -> Developer -> Test Synchronizer) and noticed that the plugins were not synchronised because it wasn't using PluginSynchronizer. It was missing a call to .synchronizingOn(s) like so:
PluginExecution.withPlugin(new SynchronizerPlugin())
                    .withParameter(SynchronizerPlugin.NAME_PARAMETER_ID, "I am number " + i)
                    .interactively(true)
                    .synchronizingOn(s)
                    .executeLater(graph);
also might as well change the variable name from s to something like pluginSynchronizer to fix a code smell with 1 letter variables :smiley:
arcturus2
@arcturus2
@/all the splash screen has been updated based on feedback. I've told the designer to focus on Option 3 which was the most popular and the updated version is https://github.com/constellation-app/constellation/pull/270#issuecomment-604977642. Please comment on the PR with your thoughts. I still need to upload the code to use the new image which I will do based on everyone's feedback.
arcturus2
@arcturus2
I've not been around because of computer woes. Phone works!
formalhaut69
@formalhaut69
Hey guys, looking through this sonarQube issue; RULE - Java "@override" should be used on overriding and implementing methods and this issue https://sonarcloud.io/project/issues?id=constellation-app_constellation&issues=AXEUsUuc1MF60jHDyUcO&open=AXEUsUuc1MF60jHDyUcO seems to be within a block of generated code that is has a warning not to modify it. Any suggestions for how to handle it?
arcturus2
@arcturus2
@cygnus-x-1 and @formalhaut69 sorry but my recommendation would be to leave it alone. The reason is that if you make a change using the GUI builder then it will regenerate the code and you will LOOSE YOUR CHANGES! I've been marking those code blocks as "won't do" with a comment saying that it is system generated.
Perhaps NetBeans 11 has fixed some of these code smells and I would prefer trying to rebuilt them in NB 11 but as a task later on. Perhaps if we are trying to replace them with JavaFX then that could be the permanent solution.
formalhaut69
@formalhaut69
@arcturus2 Okay, no worries, I'll move on to another SonarQube issue
aldebaran30701
@aldebaran30701
Morning all, I may have seen an architectural diagram for the layering of Constellation components. Does anyone have one handy ? When is the ComponentSubgraph utilized?
arcturus2
@arcturus2
@aldebaran30701 see https://github.com/constellation-app/constellation/blob/master/docs/components.png. I need to redo it and make is higher quality but its a start.
formalhaut69
@formalhaut69
Hey guys, taking a look at the SonarQube rule; Return values from functions without side effects should not be ignored. The two issues are within the class ZonedDateTimeAxis. Just wondering if this class is still used? I was trying to test some stuff but I noticed that I can't seem to find any usages of this class. There is also a TODO at the top of the class talking about "ChartLayoutAnimator" not being supported, is this supposed to be the class that uses ZonedDateTimeAxis?
antares1470
@antares1470
So I've noticed that we have 2 sonar rules that seem to address to same issue. One rule says that Object.finalize()should be protected when overriding and the other rule says Object.finalize() shouldn't be overridden full stop. Which rule do you think is better we address?
GCHQDeveloper601
@GCHQDeveloper601
has anyone been able to launch any of the constellation-adaptors in netbeans? I'm trying to test but can't launch directly from the adaptors and have to launch constellation first and then manually install the plugin. The error on launch I'm getting is a NoClassDefFoundError: org.netbeans.api.project.ProjectManager
aldebaran30701
@aldebaran30701
I can get comparison of equality for generic attributes by checking if the .toString() values are equal. I am wondering what the best way to compare less than and greater than generically. It will need to be error proof when checking against attribute definitions such as color (in this case, maybe don't compare GT or LT but EQ and not EQ)
formalhaut69
@formalhaut69

I've looked at sonarQube issue "Anonymous inner classes containing only one method should become lambdas" and all of the issues within it are from generated code with the exception of 4 of them. Should I mark them as not going to fix?

https://sonarcloud.io/project/issues?id=constellation-app_constellation&open=AXAYZUcmxAwNLZ01DH1n&resolved=false&rules=java%3AS1604&types=CODE_SMELL

formalhaut69
@formalhaut69

I've also looked into the 4 issues that aren't generated generated code and after a bit of googling I don't believe that there is a possible lambda solution.
https://sonarcloud.io/project/issues?id=constellation-app_constellation&issues=AXAYZY8UxAwNLZ01DJOk&open=AXAYZY8UxAwNLZ01DJOk

Here's a stackoverflow discussion that @aldebaran30701 found that states that a lambda expression isn't appropriate for this issue.
https://stackoverflow.com/questions/34904198/override-a-default-method-using-lambdas

Unsure how you guys would like to proceed with this one

cygnus-x-1
@cygnus-x-1
@arcturus2 those pull requests are piling up ;)