Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Rishi Raj Singh
    @rish07
    Okay let me try on 3.8
    Siddhant Khare
    @Siddhant-K-code
    sure
    Rishi Raj Singh
    @rish07
    Getting this when i run yarn watch
    Rishi Raj Singh
    @rish07
    yarn run v1.22.5
    $ rm -rf dist && run-p watch:*
    $ cd extensions/github1s && yarn dev
    $ cd scripts/watch && node watch-src.js
    $ cd scripts/watch && node watch-dist.js
    $ ./scripts/watch.sh
    $ cd lib/vscode && yarn watch
    copy resources done!
    warning github1s@0.0.0: The engine "vscode" appears to be invalid.
    $ webpack --config extension.webpack.config.js --watch
    (node:43642) UnhandledPromiseRejectionWarning: Error: Command failed: rsync -a /home/creator/development/projects/github1s/lib/vscode/out/ /home/creator/development/projects/github1s/dist/static/vscode
    rsync: [sender] change_dir "/home/creator/development/projects/github1s/lib/vscode/out" failed: No such file or directory (2)
    rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1330) [sender=3.2.3]
    
        at ChildProcess.exithandler (child_process.js:303:12)
        at ChildProcess.emit (events.js:315:20)
        at maybeClose (internal/child_process.js:1021:16)
        at Socket.<anonymous> (internal/child_process.js:443:11)
        at Socket.emit (events.js:315:20)
        at Pipe.<anonymous> (net.js:675:12)
    (node:43642) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
    (node:43642) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    $ concurrently "npm:watch-client" "npm:watch-extensions"
    copy necessary node_modules done!
    compile vscode builtin extensions...
    $ gulp --max_old_space_size=8192 compile-web
    [00:23:36] Node flags detected: --max_old_space_size=8192
    [00:23:36] Respawned to PID: 44020
    [watch-client] npm WARN lifecycle The node binary used for scripts is /tmp/yarn--1614192815805-0.43933036891310695/node but npm is using /usr/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.
    [watch-client] 
    [watch-client] > code-oss-dev@1.52.1 watch-client /home/creator/development/projects/github1s/lib/vscode
    [watch-client] > gulp watch-client --max_old_space_size=4095
    [watch-client] 
    internal/modules/cjs/loader.js:969
      throw err;
      ^
    
    Error: Cannot find module './build/lib/util'
    Require stack:
    - /home/creator/development/projects/github1s/lib/vscode/gulpfile.js
    - /home/creator/development/projects/github1s/lib/vscode/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js
    - /home/creator/development/projects/github1s/lib/vscode/node_modules/gulp-cli/index.js
    - /home/creator/development/projects/github1s/lib/vscode/node_modules/gulp/bin/gulp.js
        at Function.Module._resolveFilename (internal/modules/cjs/loader.js:966:15)
        at Function.Module._load (internal/modules/cjs/loader.js:842:27)
        at Module.require (internal/modules/cjs/loader.js:1026:19)
        at require (internal/modules/cjs/helpers.js:72:18)
        at Object.<anonymous> (/home/creator/development/projects/github1s/lib/vscode/gulpfile.js:12:14)
        at Module._compile (internal/modules/cjs/loader.js:1138:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
        at Module.load (internal/modules/cjs/loader.js:986:32)
        at Function.Module._load (internal/modules/cjs/loader.js:879:14)
        at Module.require (internal/modules/cjs/loader.js:1026:19) {
      code: 'MODULE_NOT_FOUND',
      requireStack: [
        '/home/creator/development/projects/github1s/lib/vscode/gulpfile.js',
        '/home/creator/development/projects/github1s/lib/vscode/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js',
        '/home/creator/development/projects/github1s/lib/vscode/node_modules/gulp-cli/index.js',
        '/home/creator/development/projects/github1s/lib/vscode/node_modules/gulp/bin/gulp.js'
      ]
    }
    error Command failed with exit c
    xcv58
    @xcv58
    Could you please try these commands? yarn clean && yarn, yarn watch?
    Rishi Raj Singh
    @rish07
    @xcv58 Did it and now my terminal is stuck here for since half an hour.
    netcon
    @conwnet
    @rish07 It is watch mode, you need to open another shell and run yarn serve
    Rishi Raj Singh
    @rish07
    Oh my bad. I'm sorry I am new to it. Let me try
    Rishi Raj Singh
    @rish07
    image.png
    image.png
    Rishi Raj Singh
    @rish07
    Is anyone of you facing this?
    netcon
    @conwnet
    @rish07 you need to wait minutes for vscode built completed
    xcv58
    @xcv58
    @rish07 it's normal, you need to wait the watch command to finish the build. Another way to verify it is using yarn build and yarn serve to see whether it could be built successfully.
    Rishi Raj Singh
    @rish07
    Okay let me try
    Rishi Raj Singh
    @rish07
    it worked
    thank you all
    Now we can discuss the strat for search @conwnet
    netcon
    @conwnet
    @rish07 I think Sourcegraph API recommend by @bpartridge is powerful!
    Rishi Raj Singh
    @rish07
    Yes, i saw that as well! Will try to play around with the Api tonight.
    Brenton Partridge
    @bpartridge
    Yea, glad I could help! Afraid I don't have much knowledge about the VS Code integration point where the search system touches the "filesystem" but I'm really curious how that ends up working, and glad to be a second pair of eyes there!
    Rishi Raj Singh
    @rish07

    Yea, glad I could help! Afraid I don't have much knowledge about the VS Code integration point where the search system touches the "filesystem" but I'm really curious how that ends up working, and glad to be a second pair of eyes there!

    @bpartridge haha same. Even I am going to try it for the first time. Maybe @conwnet can help me to point in the right direction

    Siddhant Khare
    @Siddhant-K-code
    Yes, you guys can ask your doubts, questions here. We Will try to answer it
    Rishi Raj Singh
    @rish07
    How is the search working right now? I am unable to find the functions. It is the GitHub1sFS class?
    Siddhant Khare
    @Siddhant-K-code

    How is the search working right now? I am unable to find the functions. It is the GitHub1sFS class?

    Check File -> ./extensions/github1s/src/github1sfs.ts

    netcon
    @conwnet
    @rish07 It is an proposed extension API provided by vscode, you can check https://github.com/microsoft/vscode-web-playground/blob/main/src/vscode.proposed.d.ts#L505
    Mike Nikles
    @mikenikles

    Hey everyone :wave:! I'm working on a configuration to develop github1s in an online development environment on www.gitpod.io. I'm able to see the editor, but get the following error in the browser console: Extension host terminated unexpectedly. Code: 81 Signal: The Web Worker Extension Host did not start in 10s

    Is this something anyone else encountered and knows what causes it?

    netcon
    @conwnet
    @mikenikles Hi Mike, this error may caused by network, because there are too many static files in Watch Mode. and we can not fetch all in 10s, so the WebworkerExtensionHost throw this error, you can just disable the timeout judge at lib/vscode/src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts#156
    netcon
    @conwnet
    It seems the sourcegraph API limit the cross-origin accessπŸ˜‚
    Mike Nikles
    @mikenikles
    Fantastic, thanks @conwnet once I updated the timeout, I can now develop github1s on Gitpod :)
    Jonathan Basseri
    @misterikkit

    Hello, I am trying to recreate the work of @gragib in conwnet/github1s#114 to get github1s working for my own github enterprise instance.

    I replaced the github API urls in the source with my own url, but github is blocking cross-origin-resource requests from github1s. Are there specific steps to properly handle CORS?

    Jonathan Basseri
    @misterikkit
    Hmm, it looks specifically as though my GHE instance is serving its API at github.dev.example.com/api/v3 and github1s is trying to access github.dev.example.com/api
    Jonathan Basseri
    @misterikkit
    okay the problem was (1) I didn't put "v3" in the url when I edited the source and (2) I didn't clear my browser cache after fixing that error. whew!
    netcon
    @conwnet
    I'm glad you have solved the problem~ πŸ˜ƒ
    xcv58
    @xcv58
    Did anyone get an email with the title: "Gitpod x GitHub1s - DevX Conf"?
    Mike Nikles
    @mikenikles
    Hey @xcv58, that email is likely from my co-worker Johannes. We (Gitpod) are preparing a DevX Conf later in April and want to ask if you are interested in joining as a speaker to tell the story of GitHub1s.
    xcv58
    @xcv58
    Thanks @mikenikles, I think @conwnet is a better fit since he is the author.
    Mike Nikles
    @mikenikles
    Sounds good, I've already emailed with him as well :thumbsup:
    netcon
    @conwnet
    @xcv58 It's okay, I think you will speak better and I am not good at EnglishπŸ˜‚
    Koren Minchev
    @korenminchev_gitlab
    Hey guys!
    My organization uses bitbucket and I thought it would be nice to implement support for it too. Is something like this in progress?
    I would be glad to contribute:)
    netcon
    @conwnet
    @korenminchev_gitlab The other SCM platform support is in the plan, it hasn't started yet~πŸ˜ƒ
    Koren Minchev
    @korenminchev_gitlab
    What's stopping us from starting? πŸ˜…
    xcv58
    @xcv58

    @korenminchev_gitlab there is very limited contributors work on this project and both @conwnet and I have a full-time job to do. @conwnet is working hard on fixing existing bug and adding new features like https://github.com/conwnet/github1s/pulls?q=is%3Apr++author%3Aconwnet+review%3Aapproved

    There are still some refactor works that need to do before we actively onboard other SCM platforms.

    xcv58
    @xcv58

    @conwnet writes an awesome roadmap here: https://github.com/conwnet/github1s/wiki/Roadmap

    Please take a look and file an issue to indicate if you are working on any "Not started" items on the roadmap.

    I have a couple of thoughts/items and want to add them to the roadmap:

    1. Enhance the README file, we need to collect some feedbacks about what need to be enhanced. e.g. how to deploy, how to contribute.
    2. Add more deployment example, in ideal, it should be deployable via Docker/K8s. And anyone just needs to docker pull a prebuilt docker image and ready to go. And all the configuration needs to be configured via ENV. For example, if we support GitHub enterprise, the developer could pass GITHUB_BASE_URL=https://github.example.com/api/v3and the instance should point all endpoints call to the https://github.example.com/api/v3
    netcon
    @conwnet
    Thank you so much!
    Chris Wendt
    @chrismwendt

    I saw "Jump to definition of symbols" on the roadmap. Would you guys like to use CodeWing? https://codewing.dev/ I'm the developer, and I'm a fan of GitHub1s πŸ˜ƒ

    CodeWing can do hover documentation and definitions for Java and Go, with more languages planned. The API is pretty simple:

    POST https://api.codewing.dev {"definition":{"owner":"...","repo":"...","commit":"...","file":"...","line":...,"column":...}}
    => {"file":...,"line":...,"column":...,"hover":{"text":...}}

    I'd be happy to submit a PR that adds this functionality to GitHub1s, but wanted to run the idea by you first.

    netcon
    @conwnet
    @chrismwendt Thanks for your concern!πŸ‘ If there any plan to support other languages on CodeWing? and where can we pay more attention to its progress?
    Chris Wendt
    @chrismwendt
    Yes, here's the issue tracker https://github.com/codewing-dev/codewing/issues It's a bit outdated at the moment, but I plan to add more languages in the next few weeks