Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Kevin Tindall
    @kevinkjt2000
    Harry Mallon
    @hjmallon
    Yeah that one looks better
    Kevin Tindall
    @kevinkjt2000
    I squashed the 3 commits as you suggested for this run
    Harry Mallon
    @hjmallon
    Yeah it tries to work out which files have changed in order to only run CI on the required packages
    (I'm not 100% on how it does this - some GitHub magic)
    Kevin Tindall
    @kevinkjt2000
    Hmmm maybe I should have updated my fork's master?
    It's behind
    Harry Mallon
    @hjmallon
    If you get that >256 error it normally means it is trying to build everything (or I have seen the issue with Boost before as there are so many sub-project tests)
    Kevin Tindall
    @kevinkjt2000
    Thanks!
    Kevin Tindall
    @kevinkjt2000
    These are errors that I can fix now :) I kind of expected the build to complain about missing CURL before swapping the download links to the hunter-ized version of aws-lambda-cpp
    Harry Mallon
    @hjmallon
    :thumbsup:
    bazfp
    @bazfp
    What's needed to get github actions building from a fork?
    Have I missed a step?
    Rahul Sheth
    @rbsheth
    Maintainers (read: me) have to approve due to a recent change in Github to fight abuse and cryptomining. I'm not sure why it considers non-first-time contributors as first-time, but it is what it is. https://github.blog/2021-04-22-github-actions-update-helping-maintainers-combat-bad-actors/
    bazfp
    @bazfp
    Thank you for approval. I was wondering if I could do a build on my own fork repo but it appears not without a PR
    bazfp
    @bazfp
    Can I get another approval :)
    Rahul Sheth
    @rbsheth
    :thumbsup:
    Ghost
    @ghost~60aa9d3b6da03739847d3c68

    Hello, have question:

    cmake_minimum_required(VERSION 3.15)
    
    set(HUNTER_URL "https://github.com/cpp-pm/hunter/archive/v0.23.300.tar.gz")
    set(HUNTER_SHA1 "1151d539465d9cdbc880ee30f794864aec11c448")
    set(HUNTER_PACKAGES protobuf gRPC)
    include(FetchContent)
    FetchContent_Declare(SetupHunter GIT_REPOSITORY https://github.com/cpp-pm/gate)
    FetchContent_MakeAvailable(SetupHunter)

    Gives me this error:

    -- [hunter] Calculating Config-SHA1
    
    [hunter ** FATAL ERROR **] No VERSION, GIT_SELF, GIT_SUBMODULE or URL/SHA1 specified
    Ghost
    @ghost~60aa9d3b6da03739847d3c68
    Looks like channel is not active :(
    Kasper
    @Waarbubble
    Could i also be approved as a first-time contribute?
    Rahul Sheth
    @rbsheth
    @ghost~60aa9d3b6da03739847d3c68 It might be a capitalization thing? Protobuf instead of protobuf. Try a more simple package first like ZLIB and see if you still get the error.
    @Waarbubble done
    hatmajster
    @hatmajster
    Hi I would like to provide few updates of packages (still need to read again carefully the guides though). I have mostly working versions of those packages forked on my own git server just to mess around with everything, and I think I will soon be ready to create some forks on github and create PR's. I have one question about minizip-ng - the legacy package minizip already exists and interestingly enough it is forked from -ng repository: https://github.com/hunter-packages/minizip. Should I prepare a new package for minizip-ng, or should I just create a new version?
    Please note, minizip-ng is not really compatible with the old minizip, though it does the same job
    TheMarpe
    @themarpe
    @hatmajster minizip in hunter-packages seems to be forked from https://github.com/zlib-ng/minizip-ng
    If this is the case and the package actually refers to minizip-ng already, I'd say just update the existing, as probably other users use it as such already
    @rbsheth for projects that provide only include/ directory is it viable to go with a new schema and ExternalProject_Add for those and install the headers to some install prefix path or should a CMake fork be made (or PR to original repo)?
    Also is it possible to create a new schema based ExternalProject_Add locally without modifying hunter sources, eg like cmake/Hunter/config.cmake?
    hatmajster
    @hatmajster
    Thanks, I'll try to do it so
    Harry Mallon
    @hjmallon
    Please could I have a fork of https://github.com/hunter-packages/Bento4 in the new cpp-pm world?
    Rahul Sheth
    @rbsheth
    @hjmallon it is there already, just updated to latest master for you https://github.com/cpp-pm/Bento4/tree/master
    @themarpe currently a fork always has to be made if the repo doesn't install its headers. I think it would be worth exploring the patch functionality in a recent WIP PR to patch in install commands to repos that don't provide them
    @hatmajster welcome, and yes - if minizip is actually minizip-ng, no problem just creating a new version
    Harry Mallon
    @hjmallon
    Cheers @rbsheth : Heres my PR cpp-pm/Bento4#1
    drodin
    @drodin
    Please fork https://github.com/libsdl-org/SDL_net into cpp-pm org
    Rahul Sheth
    @rbsheth
    drodin
    @drodin
    @rbsheth Can't push a new branch to this repo, don't have access rights.
    Rahul Sheth
    @rbsheth
    weird, my script should have added the group. try it again now
    drodin
    @drodin
    @rbsheth it worked
    bazfp
    @bazfp
    I have submitted an update to jsoncpp
    craffael
    @craffael
    Can I please have a fork of intel ittapi (https://github.com/intel/ittapi) in the cpp-pm "namespace"? I will have to patch the source quite a bit for hunter and I don't think that Intel will accept it because they have their custom python build script :(
    Steven Liebregt
    @stevenliebregt
    Hi all, I'm having some problems setting up Hunter, I have a top level CMakeList.txt, which defines its project, and below that includes a subdirectory, in which I also have a CMakeList.txt in that subdirectory, I first setup Hunter, then the project name, but this does not work, because the top level CMakeList has a project definition before Hunter then. Do I then just add the subdirectories in the top level before setting the top level project name or is that not the right way?
    Harry Mallon
    @hjmallon
    If your project is a main project and a subproject (where the subproject uses Hunter) I would just add the Hunter init CMake code to the top level too
    That way you can build the subproject on it's own (perhaps for CI) and build them toghether too
    Rahul Sheth
    @rbsheth

    Can I please have a fork of intel ittapi (https://github.com/intel/ittapi) in the cpp-pm "namespace"? I will have to patch the source quite a bit for hunter and I don't think that Intel will accept it because they have their custom python build script :(

    @craffael Sorry, didn't get a notification for this. Done https://github.com/cpp-pm/ittapi

    @stevenliebregt What @hjmallon said is correct. Since the Hunter initialization must happen before a PROJECT command, it is better to add the init code to the top level.
    Megaguy32
    @megaguy32:matrix.org
    [m]
    Helio
    I have a problem compiling Ethminer from the AUR
    the output indicates Hunter having a problem with the Boost C++ libraries - ethereum-mining/ethminer#2378
    Harry Mallon
    @hjmallon
    I think the new Boost URLs were implemented in Hunter here https://github.com/cpp-pm/hunter/releases/tag/v0.23.298
    Try updating Hunter version
    1 reply