These are chat archives for creationix/nvm

26th
Jan 2015
Jean Lucas
@jeanleonino
Jan 26 2015 19:14
@ljharb: I kinda want to help with the $SHELL issue when there's a .zshrc and bashrc files. But I'm not sure how can I contribute to nvm.
Jordan Harband
@ljharb
Jan 26 2015 19:26
jeanleonino: there's lots of ways to contribute :-) ideas, a proposal, your opinion on what you'd expect to happen
even if it doesn't end up being a workable approach, or if another one lands instead, it can still help inspire or focus ideas
but also feel free to try your hand at a pull request, i'm happy to review it
Jean Lucas
@jeanleonino
Jan 26 2015 19:30
oh, ok, I was thinking in a PR, based on this: https://github.com/creationix/nvm/issues/592#issuecomment-71328750
@ljharb but I don't know where exactly I should do it, need some guiding to dig into the code :)
Jordan Harband
@ljharb
Jan 26 2015 19:31
ah - it'll be in install.sh
specifically the nvm_detect_profile function
Jean Lucas
@jeanleonino
Jan 26 2015 19:32
@ljharb thanks ;) I'll do some work here
Jordan Harband
@ljharb
Jan 26 2015 19:32
and there's unit tests for it in test/install_script/nvm_detect_profile so you can modify those too :-)
yay, much obliged