Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    legendaryzyper
    @legendaryzyper
    now its working
    what the hell
    Luca Schlecker
    @luca-schlecker
    Older Boost versions have a problem compiling with the VS2022 (at least through VCPKG).
    But I'm glad it works now. 🎉
    legendaryzyper
    @legendaryzyper
    awesome framework btw
    thumbs up to the devs
    Luca Schlecker
    @luca-schlecker
    Thanks, we're (I guess I may speak for all of us here) glad to hear it. 😊
    legendaryzyper
    @legendaryzyper
    what does mustache::set_base() do?
    Farook Al-Sammarraie
    @The-EDev
    it sets the directory where your templates will be placed in, the default directory is "templates/"
    legendaryzyper
    @legendaryzyper
    thanks
    so the "." is using the default dir right
    Farook Al-Sammarraie
    @The-EDev
    no, "./templates" is the default dir
    legendaryzyper
    @legendaryzyper
    hmm i used set_base("./my_dir") and put my htmls in "my_dir" but crow still cant find them
    Farook Al-Sammarraie
    @The-EDev
    try set_base("my_dir")
    legendaryzyper
    @legendaryzyper
    hmm still doesnt work either
    i noticed that even if i changed set_base then crow still search in "./templates"
    Farook Al-Sammarraie
    @The-EDev
    interesting
    legendaryzyper
    @legendaryzyper
    hope you look into it
    Farook Al-Sammarraie
    @The-EDev
    I am
    Farook Al-Sammarraie
    @The-EDev
    for some reason it seems that setting the base inside your route works
    I'll look into it further]
    legendaryzyper
    @legendaryzyper
    thanks
    legendaryzyper
    @legendaryzyper
    not sure but in the function handle in class DynamicRule there's a check if the template base is not "templates" then set the base to "templates" which makes it always use "templates" directory
    again im not too sure about this. maybe im missing something
    Farook Al-Sammarraie
    @The-EDev
    Github is down, might be worth creating a Gitlab mirror
    leon0402
    @leon0402:matrix.org
    [m]
    Or switching to GitLab completely :D
    Farook Al-Sammarraie
    @The-EDev
    I would like to. Unfortunately the people (and the original project) are on github, so cutting that off is nothing short of killing this project in the crib
    Luca Schlecker
    @luca-schlecker
    I in fact do have a GitLab account, but I decided to only work on GitHub... Switching to GitLab could definitely starve the Project of potential users which report issues or even contribute.
    I feel like GitHub also seems to be a bit easier on users and maybe even a bit less overwhelming than GitLab. As @The-EDev already mentioned, GitHub is where most people are at.
    Farook Al-Sammarraie
    @The-EDev
    image.png
    So this happened :)
    (I also fixed the matrix avatar problem but that's not as big a deal)
    Luca Schlecker
    @luca-schlecker
    Awesome. 🎉 Congrats. ☺️
    Farook Al-Sammarraie
    @The-EDev
    @luca-schlecker let me know if you need help with CrowCpp/Crow#258, I'm currently focusing on expanding the documentation but once that's done I think I can focus on async work. If we can squeeze Async handlers in the next release I believe I would confidently call it v1.0
    Farook Al-Sammarraie
    @The-EDev
    Taking on CrowCpp/Crow#25 once more. This time I'm going through the original repo changes since August 2014 and trying to integrate those into Crow's parser
    I don't blame the people at nodejs for dropping the parser XD
    leon0402
    @leon0402:matrix.org
    [m]
    Don‘t do client support :-)
    Do one thing and do that thing good is my believe.
    We already have with cpr a very good client library
    Farook Al-Sammarraie
    @The-EDev
    @leon0402:matrix.org god no! The idea with CrowCpp/Crow#25 is that the Parser is outdated and needs improvements or replacements
    leon0402
    @leon0402:matrix.org
    [m]
    There was some discussion in the end
    Farook Al-Sammarraie
    @The-EDev
    Yes, I was setting up a plan on where to take the parser and needed to know whether there was a chance that crow could become a client
    My plan is 3 stages, the first is to get the code up to date with the latest nodejs parser (only 6 years of updates to implement, the purpose behind that is to make sure we're on solid ground before moving forward). Then strip not needed code (response parsing and client related code), and then slowly change parts to be more in tune with Nginx's parser (so we can ultimately make the change to the latter which is still maintained)
    leon0402
    @leon0402:matrix.org
    [m]
    I‘m not sure I understand though. We modify an existing library and make it our own?
    So this means we always have to pick up new updates😅
    Why not try to integrate the library as a real dependency.
    And if necessary, write a wrapper around it
    Farook Al-Sammarraie
    @The-EDev
    So to explain this better I need to talk about the history if it all, Crow uses the parser from NodeJS, which in turn is a modified version of the parser for Nginx.
    The version Crow uses is from mid 2014. The nodeJS parser was abandoned in favor of a new parser last year. This is why the need to switch to something else is there, problem is, I already tried to make the switch, and lost half my sanity by the end of the first week.
    As to why not just add another dependency, aside from the fact that the nodeJS code is abandoned and the alternative is a single file in a massive project. Crow will ultimately require modifications to the parser, so we can't just lift a parser and use it as is. Not to mention it's much easier to compile when the parser is integrated.
    leon0402
    @leon0402:matrix.org
    [m]
    hmm so we basically want our own http parser, but don't start from scratch
    What is again the job of the http parser? And would it maybe make sense to have its own repository for that library, so others can use it as well without crow?
    Farook Al-Sammarraie
    @The-EDev

    hmm so we basically want our own http parser, but don't start from scratch

    To some extent, if "not from scratch" meant we start with a fully functioning parser

    leon0402
    @leon0402:matrix.org
    [m]
    Or try to fork an existing project, but also upstream some of the work if it's accepted
    Farook Al-Sammarraie
    @The-EDev

    What is again the job of the http parser? And would it maybe make sense to have its own repository for that library, so others can use it as well without crow?

    In Crow's case the parser takes the raw text sent over TCP and converts it into crow::request objects, it would normally also parse HTTP response text but we don't care about that part.
    It wouldn't really make sense to have them separate, like I said, the plan is to take something that already works and make it work with Crow's own connection and request objects (when it's intended to work with other kinds of classes/data structures)