crystal-lang/crystal

The Crystal programming language | http://crystal-lang.org | Fund Crystal's development: http://is.gd/X7PRtI | Docs: http://crystal-lang.org/docs/ | API: http://crystal-lang.org/api/

Jonathan Silverman

@mixflame

alright, i got it to connect, now im just back to the refusal to send bug

https://gist.github.com/mixflame/4e81d9083a02c9859ccc59c623b4d3c9

ERROR :Closing link: (97KAAAAEC@c-107-2-145-228.hsd1.co.comcast.net) [Registration timeout]

Jonathan Silverman

@mixflame

something to do with flush()?

George Dietrich

@Blacksmoke16

https://gist.github.com/mixflame/4e81d9083a02c9859ccc59c623b4d3c9#file-irc-cr-L79 is prob closing the socket so that when the other fibers execute it's closed

would be my guess without actually trying it

Chris Watson

@watzon

Seems likely. The code inside of the spawn is going to run asynchronously, so the .close is going to happen while the socket is still being accessed.

Jonathan Silverman

@mixflame

whoa thx

George Dietrich

@Blacksmoke16

looks like you got some non-ideal concurrency code going on

Jonathan Silverman

@mixflame

sorry guys even with that close disable the server still closes the link, there's a fail to write... i'll show the current code

https://gist.github.com/mixflame/ac368524b43075ab5768893290cc914d

the code has worked fine before without the SSL stuff bolted on...

trying to get it onto my irc network

George Dietrich

@Blacksmoke16

whats the error exactly again?

Jonathan Silverman

@mixflame

i'm back to this IRC based error, "ERROR :Closing link: (97KAAAAEC@c-107-2-145-228.hsd1.co.comcast.net) [Registration timeout]"

it happens when you don't do this fast enough:

```

  def login
    return unless @response_count == 3
    ssl_socket.as(OpenSSL::SSL::Socket::Client).unbuffered_write "PASS #{password}\r\n".to_slice
    ssl_socket.as(OpenSSL::SSL::Socket::Client).unbuffered_write "NICK #{nick}\r\n".to_slice
    ssl_socket.as(OpenSSL::SSL::Socket::Client).unbuffered_write "USER #{user} 8 * :#{user}\r\n".to_slice
    @logged_in = true
  end

George Dietrich

@Blacksmoke16

so at this point it sounds like it's a logic problem

Jonathan Silverman

@mixflame

surely

but the SSL socket simply isn't sending, i ran into this before

George Dietrich

@Blacksmoke16

do you need to use that socket directly versus just like HTTP::Client with tls enabled?

Jonathan Silverman

@mixflame

there's no TLS enable IRC socket in the crystal lang lib

it's speaking the Internet Relay Chat protocol

George Dietrich

@Blacksmoke16

ah right, and it's not HTTP based i take it?

Jonathan Silverman

@mixflame

nope, non http

George Dietrich

@Blacksmoke16

gotcha

Jonathan Silverman

@mixflame

this part is usually simple

and not hard

and i had it working before

there seems to be a bug in the ssl socket, not sure if this is related but i can't decode it: crystal-lang/crystal#5375

he (RX14) says call #flush... but the doc's don't say this...

i tried calling flush tho.. didn't write

George Dietrich

@Blacksmoke16

did you try using << "some str" then .flush

Jonathan Silverman

@mixflame

i did try, that...

just changed it to this...

```

  def login
    return unless @response_count == 3
    ssl_socket.as(OpenSSL::SSL::Socket::Client) << "PASS #{password}\r\n"
    ssl_socket.as(OpenSSL::SSL::Socket::Client) << "NICK #{nick}\r\n"
    ssl_socket.as(OpenSSL::SSL::Socket::Client) << "USER #{user} 8 * :#{user}\r\n"
    ssl_socket.as(OpenSSL::SSL::Socket::Client).flush
    @logged_in = true
  end

no send

whoa!
i got it to login

see the response count think

turns out my server only sends 2

yeah protocol code lol :D

George Dietrich

@Blacksmoke16

mmk

Jonathan Silverman

@mixflame

if you were wondering here is the full code that works https://gist.github.com/mixflame/057abeff96311c91f0d2e81fbd0edb26

IRC SSL in Crystal ^

Gabor Szabo

@szabgab

I accidentally ran "crystal spe" (without the trailing c) and it executed all the spec test. Why and how?

George Dietrich

@Blacksmoke16

when "spec/".starts_with?(command)

is what the logic for the CLI is

Gabor Szabo

@szabgab

Oh, thanks

Where communities thrive

People

Repo info

Activity