Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 30 23:58
    caspiano opened #11517
  • Nov 30 23:14
    HertzDevil labeled #11516
  • Nov 30 23:14
    HertzDevil labeled #11516
  • Nov 30 23:14
    HertzDevil labeled #11516
  • Nov 30 23:14
    HertzDevil opened #11516
  • Nov 30 23:12
    HertzDevil synchronize #11496
  • Nov 30 22:28
    straight-shoota synchronize #11512
  • Nov 30 22:18
    HertzDevil synchronize #11496
  • Nov 30 21:44
    straight-shoota opened #11515
  • Nov 30 21:44
    straight-shoota labeled #11515
  • Nov 30 21:39
    straight-shoota labeled #11514
  • Nov 30 21:39
    straight-shoota opened #11514
  • Nov 30 21:36
    HertzDevil synchronize #11298
  • Nov 30 21:26
    straight-shoota labeled #11513
  • Nov 30 21:24
    straight-shoota milestoned #11513
  • Nov 30 21:10
    straight-shoota closed #11509
  • Nov 30 21:03
    straight-shoota edited #11513
  • Nov 30 21:02
    straight-shoota edited #11513
  • Nov 30 21:02
    straight-shoota labeled #11513
  • Nov 30 21:02
    straight-shoota edited #11513
George Dietrich
@Blacksmoke16
im not super familiar with protobuf, but isn't the idea that you dont make everything nilable?
From IRC (bridge bot)
@FromIRC
<raz> well it's a "oneof". request.item.obj tells me which attr is set, so i can then look it up as request.item[ request.item.obj ]. i'm afraid all of these things are legally nil'able in this situation, but i'm still trying to find a better way
oprypin
@oprypin:matrix.org
[m]
heh could be a union of namedtuples
From IRC (bridge bot)
@FromIRC
<raz> https://carc.in/#/r/blw8 - this version also works.
oprypin
@oprypin:matrix.org
[m]
(with exactly one key each)
From IRC (bridge bot)
@FromIRC
<raz> but that's what my complain from earlier was about, i don't find it exactly clearer to read
George Dietrich
@Blacksmoke16
are you the only one using these types?
could leverage getter!
just would have to know when to do .item? versus .item
From IRC (bridge bot)
@FromIRC
<raz> hmmm that sounds like an idea. i may try a pr on protobuf.cr
George Dietrich
@Blacksmoke16
a quick look suggests they already support that
required ones are not nilable, optional are
From IRC (bridge bot)
@FromIRC
<raz> yea, but in proto3 everything is optional (don't get me started...)
George Dietrich
@Blacksmoke16
welp
From IRC (bridge bot)
@FromIRC
<riza> might as well write in node then
<raz> heureka.not_nil!
<raz> that was actually easy to add... phew
<raz> i'll just add me a helper for that has lookup, too, then it'll be pretty
<raz> hash*
<hightower2> Seems a couple presentations are not among the recordings.. e.g. Ary's or btate's.. What's up with that?
<hightower2> (from the crystal conf, of course)
<hightower2> ah could be in main track
mfiano
@mjfiano:matrix.org
[m]
I have a few types which all include some partial types. These modules are never intended to be seen be the user, such as in generated documentation pages with crystal doc, but I can't exactly make them private either if I want to include them in other modules/types, and protected doesn't seem to work on modules, so I'm not really sure if Crystal has a solution for me...
The mixins are purely for DRY/maintenance reasons
George Dietrich
@Blacksmoke16
# :nodoc:
mfiano
@mjfiano:matrix.org
[m]
Any ideas?
Oh hmm, that might be what I'm looking for :)
mfiano
@mjfiano:matrix.org
[m]
That does work, however, perhaps it's me being picky but it'd be nice if the types that include a :nodoc: module didn't generate docs with references to the hidden module, as it currently does with "Instance methods inherited from module..."
George Dietrich
@Blacksmoke16
you'd probably need to have public methods in each type that delegate to the module
otherwise the docs are correct, those methods dont actually live in the type, they come from that module
From IRC (bridge bot)
@FromIRC
<straight-shoota> I think the docs generator is not handling things like this very nicely
<straight-shoota> If you want this mixin to be completely invisible, maybe you could just use a macro that generates these methods.
mfiano
@mjfiano:matrix.org
[m]
I see. This is not a big deal really, and delegates/macro would be more trouble than its worth.
Thanks for the pointers. I'm happy enough with :nodoc:
George Dietrich
@Blacksmoke16
@straight-shoota related to crystal-lang/crystal#10977, so is the current output actually correct?
From IRC (bridge bot)
@FromIRC
<straight-shoota> Yes, the behaviour is correct and as expected. The documentation is just wrong.
George Dietrich
@Blacksmoke16
hm, whats the reasoning when not using a buffered channel that the output is
Before send 1
Before send 2
1
2
Before send 3
After send
3
shouldnt the first send cause the receive to print the value?
https://play.crystal-lang.org/#/r/blx6 which is how it worked before
From IRC (bridge bot)
@FromIRC
<straight-shoota> Channel#send doesn't immediately yield to a waiting receiver, it just enqueues it (so it get's resumed when the scheduler reschedules)
George Dietrich
@Blacksmoke16
i guess to me it seems more like a regression as it used to work one way and now works a diff way
From IRC (bridge bot)
@FromIRC
<straight-shoota> So on send(1), the receiving fiber is enqueued, on send(2), there's no waiting receiver and no queue, so the channel triggers a reschedule.
George Dietrich
@Blacksmoke16
when the thing that changed it was MT, which maybe its a byproduct of supporting MT versus a regression
From IRC (bridge bot)
@FromIRC
<straight-shoota> No, I think it's a fix really. The previous behaviour was not correct. At least not what you would expect from the specifics of a channel.
George Dietrich
@Blacksmoke16
hmm fair enough
mfiano
@mjfiano:matrix.org
[m]
Do I have to create 2 different partial types if the intended behavior is to mixin a set of instance methods and a set of class methods?
George Dietrich
@Blacksmoke16
i usually define a ClassMethods module within the one partial type, then add a like macro inherited; extend ClassMethods; end;
mfiano
@mjfiano:matrix.org
[m]
I can't seem to get that to work. Maybe I'm doing it wrong...