Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 15:10
    straight-shoota closed #13041
  • 14:05
    straight-shoota assigned #12284
  • 12:54
    straight-shoota milestoned #13045
  • 12:54
    straight-shoota milestoned #13045
  • 12:02
    straight-shoota labeled #13045
  • 12:02
    straight-shoota labeled #13045
  • 12:02
    straight-shoota assigned #13045
  • 12:02
    straight-shoota opened #13045
  • 10:40
    straight-shoota closed #13040
  • 10:37
    straight-shoota milestoned #12963
  • 10:34
    straight-shoota milestoned #13034
  • 10:34
    straight-shoota milestoned #13034
  • 00:58
    HertzDevil synchronize #13034
  • 00:47
    HertzDevil synchronize #13034
  • Feb 02 22:23
    HertzDevil ready_for_review #13034
  • Feb 02 22:22
    straight-shoota closed #13039
  • Feb 02 22:21
    straight-shoota closed #13020
  • Feb 02 22:21
    straight-shoota closed #11646
  • Feb 02 22:21
    HertzDevil synchronize #13034
  • Feb 02 19:26
    straight-shoota labeled #13044
George Dietrich
@Blacksmoke16
ah pp by default prints a long list, not a 4x4 grid
mfiano
@mjfiano:matrix.org
[m]
So those rand methods in the ClassMethods module...
If I use inheritance, and stick those in an abstract parent struct, that isn't going to cause issues with eg; .new being undefined for the abstract type?
George Dietrich
@Blacksmoke16
if you're using inheritance now just define them as class methods in the parent and call it a day
i dont think so?
mfiano
@mjfiano:matrix.org
[m]
Ok. Inheritance does seem better by far
Unsure if I will even need any mixins for the code I have so far anyway
George Dietrich
@Blacksmoke16
id test that tho, but it should be fine assuming each child has an argless constructor
mfiano
@mjfiano:matrix.org
[m]
wait why?
oh i see what you mean
Yes, that's a given
The one thing I'm unsure about is how to get my T type parameter to resolve for the topmost type....it was passed into include before
mfiano
@mjfiano:matrix.org
[m]
Ah.
My intention is to only allow instances in this library to have Float64 for elements in the various containers, and I don't want type inference to permit anything else, so should be able to just make sure all contructors restrict their types, in addition to the above.
George Dietrich
@Blacksmoke16
then why do you need generics?
yea just do that and dont use generics
mfiano
@mjfiano:matrix.org
[m]
Probably don't anymore. I only needed it before because Indexable required a type parameter.
George Dietrich
@Blacksmoke16
generic inheritance can be kinda buggy
well it would be Indexable(Float64)
mfiano
@mjfiano:matrix.org
[m]
Yeah I was only using T because a lot of function signatures became too long with Float64 everywhere
iirc anyway
George Dietrich
@Blacksmoke16
:S
i always find its better to be explicit
even tho crystal allows you to not use them, i always do
at least on publicly facing libs and APIs
mfiano
@mjfiano:matrix.org
[m]
I do agree.
It may be that I have to support Float32 in the future, I'm not sure. It depends how FFI works in Crystal
It's a performance trap to use doubles on the GPU in most cases, so prob have to send them to the driver with single precision
George Dietrich
@Blacksmoke16
:shrug:
mfiano
@mjfiano:matrix.org
[m]
and also what opengl binding libraries expect I suppose
The Scalar module was/is bothering me, and much moreso with inheritance
George Dietrich
@Blacksmoke16
how so?
cant those 2 methods just live on the parent and not worry about it
mfiano
@mjfiano:matrix.org
[m]
It is unrelated to any of the aggregate types...it defines some functions for Float64 elements themselves
George Dietrich
@Blacksmoke16
if they're unrelated put em in a Utility namespace?
mfiano
@mjfiano:matrix.org
[m]
I could, but how would I make it private to users...they're sort of just an implementation detail of some of the aggregate types' methods
George Dietrich
@Blacksmoke16
nodoc it
wouldnt show up anywhere since you're not including/extending anything
mfiano
@mjfiano:matrix.org
[m]
Sold
George Dietrich
@Blacksmoke16
not sure im a fan of the =~ method name tho for a class method
mfiano
@mjfiano:matrix.org
[m]
For a class name?
oh
I cannot read
George Dietrich
@Blacksmoke16
works better when its between instances, but a more english name might be better
mfiano
@mjfiano:matrix.org
[m]
That was suggested in this chat quite a few days ago by someone, because 99% of use cases are going to be in the form of a binary operator, not the method call syntax...and can only use a whitelisted set of symbols there
I'm not sold on it either, but
Origin::Vector3.nearly_equal? v1, v2 user code calling Origin::Util.nearly_equal? f1, f2, rel_tol, abs_tol internal code isn't too bad I suppose
George Dietrich
@Blacksmoke16
wait
why not v1 =~ v2