crystal-lang/crystal

The Crystal programming language | http://crystal-lang.org | Fund Crystal's development: http://is.gd/X7PRtI | Docs: http://crystal-lang.org/docs/ | API: http://crystal-lang.org/api/

George Dietrich

@Blacksmoke16

can you make a playground link that reproduces it?

Sean Gregory

@skinnyjames

I think so!

simplified version: https://play.crystal-lang.org/#/r/c0rm

George Dietrich

@Blacksmoke16

i think the compiler gets the typing of the hash messed up

can re-write that part to be a case and should work fine

def handle_error(error)
  {% begin %}
    case error
      {% for k, v in klass_map %}
       when {{k}} then raise {{v}}.new(error)
      {% end %}
    end
  {% end %}
end

Sean Gregory

@skinnyjames

ah cool.

thanks!

George Dietrich

@Blacksmoke16

pp !!clazz && clazz.is_a?(Exception) # => false

Sean Gregory

@skinnyjames

this will likely be a little less performant right?

I can make the hashmap an array instead if that's easier

George Dietrich

@Blacksmoke16

probably negligible, no that would be worse i think

Sean Gregory

@skinnyjames

ah okay

George Dietrich

@Blacksmoke16

could benchmark it if you want, but i prob wouldn't worry about it too much

ofc it's all moot if you remove the need to convert arbitrary strings into exceptions. i.e. if you already know that you want to raise an unknown method exception because of the string, could just do raise UnknownMethodException.new versus going thru the case at all

but i assume there is more to it than this example?

Sean Gregory

@skinnyjames

definitely did the trick!

i was originally iterating, but I'm just being lazy

Sean Gregory

@skinnyjames

almost ready to beta my project!
https://github.com/skinnyjames/webdriver

It's a w3c compliant OO webdriver that pulls from the Watir api

George Dietrich

@Blacksmoke16

nice one!

Sean Gregory

@skinnyjames

thanks! I'm pretty excited. I've been looking at ruby's Spinach library, and I would like to implement a similar test runner in Crystal

George Dietrich

@Blacksmoke16

sounds like quite the challenge

Sean Gregory

@skinnyjames

yeah, I'll probably be bugging you all a little bit :)
Crystal is definitely my favorite language, so I hope that testing can be a bit more first class

George Dietrich

@Blacksmoke16

in regards to E2E testing you mean?

Sean Gregory

@skinnyjames

yeah,ATDD

i'm happy with Spec

George Dietrich

@Blacksmoke16

everyone i know uses https://www.cypress.io/ for that

main downside is ofc it's JS, but will be a large undertaking to try and match them imo

Sean Gregory

@skinnyjames

cypress is cool, but the api is more cumbersome

the one thing that I really like about it, is by mocking the network deps, you can turn a unit test suite into an e2e test suite with a switch

George Dietrich

@Blacksmoke16

they did just add in the #intercept method, which makes that side of it easier more powerful

i also really like their tooling. How you can see what's going on and interact with snapshots of the UI at each point

Sean Gregory

@skinnyjames

driver.findElement(By.id("username");).sendKeys(username);
vs
browser.element(id: /username/i).set(username)

yeah, I think tooling could be better in selenium, but selenium 4 supports video now

George Dietrich

@Blacksmoke16

wait, neither of those looks like cypress

cy.get('#username').click(); is what im familiar with

Sean Gregory

@skinnyjames

oh lol

I was looking at the wrong docs

George Dietrich

@Blacksmoke16

that would do it :P

er .type(username)*

Sean Gregory

@skinnyjames

how would you get the second input if they were like:

<form id="first-form"></form>
<form>
<input id="username-dynamic234231">
<input id="username-dynamic234234">
</form>

I've built abstractions around the query selector api, but it never seems to be the best

cy.get('input[id^="username"]:nth-of-type(2)').type(username)

I'm also a big fan of page object, so I may be biased :)

George Dietrich

@Blacksmoke16

i think in the ideal world of cypress you'd do something like cy.get('[data-test=some-unique-id]') such that you're not relying upon classes/id/order etc

Sean Gregory

@skinnyjames

collections don't usually have unique ids though

George Dietrich

@Blacksmoke16

but, for this example it would be like cy.get('input').eq(2)

er .eq(1), starts at 0

collections of objects from the db or?

Sean Gregory

@skinnyjames

like a list

George Dietrich

@Blacksmoke16

true true, depends on the context. A simple list of strings wouldn't, but a list of something fetched from the db would

Where communities thrive

People

Repo info

Activity