Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 03:34
    phil-davis synchronize #1252
  • Oct 20 15:23
    ishank011 closed #1258
  • Oct 20 15:16
    ishank011 closed #1260
  • Oct 20 15:04
    refs edited #1260
  • Oct 20 14:53
    refs synchronize #1260
  • Oct 20 14:39
    refs synchronize #1260
  • Oct 20 14:33
    refs synchronize #1260
  • Oct 20 14:30
    refs synchronize #1260
  • Oct 20 14:28
    refs review_requested #1260
  • Oct 20 14:28
    refs opened #1260
  • Oct 20 13:53
    C0rby review_requested #1259
  • Oct 20 13:53
    C0rby opened #1259
  • Oct 20 13:47
    C0rby synchronize #1258
  • Oct 20 13:13
    C0rby synchronize #1258
  • Oct 20 12:55
    C0rby synchronize #1258
  • Oct 20 12:54
    C0rby review_requested #1258
  • Oct 20 12:53
    C0rby review_requested #1258
  • Oct 20 12:53
    C0rby opened #1258
  • Oct 20 09:21
    Daniel-WWU-IT synchronize #1257
  • Oct 20 09:17
    Daniel-WWU-IT review_requested #1257
Jörn Friedrich Dreyer
@butonic
:thumbsup:
Jörn Friedrich Dreyer
@butonic
I'll update #1193 with an ongoing example today (reviews and demos all day long). @labkode @ishank011 can you clarify what you think should be done for cs3org/reva#1170 ?
Hugo G. Labrador
@labkode
@butonic PR approved, needs rebase and passing CI to merge. Take a look at my comment.
Jörn Friedrich Dreyer
@butonic
I am splitting out some changes into dedicated PRs in the hope that they can be reviewed easier: cs3org/reva#1206 would be a great start
Jörn Friedrich Dreyer
@butonic
@labkode @ishank011 cs3org/reva#1206 is green and only needs a review
Jörn Friedrich Dreyer
@butonic
@labkode @ishank011 now that the storageprovider correctly reports permission erros the ocs api needs to handle them and return the http forbidden status. please review & merge: cs3org/reva#1207
Hugo G. Labrador
@labkode
@butonic we have merged the PRS
Jörn Friedrich Dreyer
@butonic
yes, rebased my owncloud driver worg
Hugo G. Labrador
@labkode
We added also the etag propagation for the home and shared folder so the sync client will now discover the changes
Jörn Friedrich Dreyer
@butonic
now preparing a pr for the gateway as it also swallows permissions ...
Hugo G. Labrador
@labkode
The foundation is there
Jörn Friedrich Dreyer
@butonic
yeah i saw that
Hugo G. Labrador
@labkode
We should also start refactoring the error model to rely on the stdlib now that has support
Jörn Friedrich Dreyer
@butonic
but i was under the impression that that is a task for the storage driver ... which is obviously wrong. but I need to digest khat you did there ;)
after teaching the gateway about permissions
agreed. there is quite some back and forth ...
Jörn Friedrich Dreyer
@butonic
@labkode @ishank011 teaching the gateway storageprovide about permissions in cs3org/reva#1210 ... waiting for ci, a review and merge
Jörn Friedrich Dreyer
@butonic
cool, cs3org/reva#1210 is all green
Hugo G. Labrador
@labkode
@butonic merged, thanks for improving the error handling
Jörn Friedrich Dreyer
@butonic
thx, I rebased cs3org/reva#1202 ti is good to be reviewed. only affects the owncloud driver
Hugo G. Labrador
@labkode
@butonic merged
Jörn Friedrich Dreyer
@butonic
:heart:
Jörn Friedrich Dreyer
@butonic
I noted down two changes in the cs3api that I see:
cs3org/cs3apis#91 and cs3org/cs3apis#92
comments welcome
Jörn Friedrich Dreyer
@butonic
@labkode @ishank011 can you merge cs3org/reva#1213 pls
Hugo G. Labrador
@labkode
@butonic merged, nice progress on the ocis driver. Would be good to have a chat to see what you're working on
Jörn Friedrich Dreyer
@butonic
awesome, thx
current focus is on getting the client to sync shared files on top of eos ... together with making the account service use cs3 as a backend
we are going to rename ocis-reva to just storage in the monorepo, that should make differentiating them easier
Hugo G. Labrador
@labkode
And the other cs3 implementations like sharing how are you going to call them? ocis-reva => sharing?
Jörn Friedrich Dreyer
@butonic
I also want to change the config and moun ta storage provider (together with a data provider) at /home and /users . that should make it easier to understand what they are used for, regardless of the storage driver that is used for them
the current ocis-reva sharing will become storage sharing or as part of the ocis single binary the ocis storage-sharing subcommand
Hugo G. Labrador
@labkode
Cool
The /home and /users mounts makes sense for default for the majority of users
Jörn Friedrich Dreyer
@butonic
auth is currently handled by the proxy. so while we technically don't need them we are going to run them for the time being until we halve the time to implement a micre version of them with service discovery built in
alse ocdav and ocs will move to dedicated services ... and no longer be part of storage
Hugo G. Labrador
@labkode
Makes sense yes
Jörn Friedrich Dreyer
@butonic
so it think it made sense to go forward with renaming to storage ... as ultimately it will only be storage related ...
but sharing actually will remain part of that ... afaict
public shares, ocm ... all very much storage
Jörn Friedrich Dreyer
@butonic
@labkode @ishank011 a merge of cs3org/reva#1225 would be great
Jörn Friedrich Dreyer
@butonic
@labkode @ishank011 small pr to merge pls: cs3org/reva#1255
Jörn Friedrich Dreyer
@butonic
maybe @SamuAlfageme can reviewc cs3org/reva#1255
@ishank011 :heart:
Jörn Friedrich Dreyer
@butonic
@labkode please review this change to the UpdateGrant implementation in the gateway. cs3org/reva#1258 it should be the cause for a lot of failing sharing tests.
runsh: Total unexpected passed scenarios throughout the test run:
apiShareReshareToShares3/reShareUpdate.feature:25
apiShareReshareToShares3/reShareUpdate.feature:26
apiShareReshareToShares3/reShareUpdate.feature:42
apiShareReshareToShares3/reShareUpdate.feature:43
apiShareReshareToShares3/reShareUpdate.feature:76
apiShareReshareToShares3/reShareUpdate.feature:77
apiShareReshareToShares3/reShareUpdate.feature:93
apiShareReshareToShares3/reShareUpdate.feature:94
nice find @C0rby
Jörn Friedrich Dreyer
@butonic
maybe @ishank011 or @SamuAlfageme can have a look ^
Ishank Arora
@ishank011
@butonic @C0rby looks good, merged!