Hey @butonic:matrix.org I guess he is (and I am as well!), let me have a look this evening
Andre Duffeck
@aduffeck
@glpatcern thanks for merging :thumbsup: happy vacation!
Nyra Reddy
@nyrareddy
Are there any programs other than GSoC to support students. I see that CERN has this, anything specific to Reva for this Winter/Fall?
Klaas Freitag
@dragotin
@labkode hi Hugo, FYI, I (mis-) used my power to tweak the settings in codacy to not complain about missing "Package Comments" any more in Reva, that blocked PRs unexpectedly for us. I hope you did not enable it intentionally recently...
Hugo Labrador
@labkode
Hi Klaas, no I haven't changed that settings in long time.
Good it helped you
Antoon P.
@redblom
Can someone (@glpatcern, @labkode) review this: cs3org/reva#2979
@labkode@glpatcern Seems that the reva CI on edge and experimental is broken since cs3org/reva@636b2b6
I wonder what happened. Did you change the codacy secret?
Giuseppe Lo Presti
@glpatcern
@micbar there's some active ongoing work on that, yes, because we really have to get out of drone - our license expired long ago
The target is to move everything to GitHub workflows
_
Hugo Labrador
@labkode
I pinged the person working on that
Vasco Guita
@vascoguita
@micbar We are moving out from Drone. Drone was running the "coverage" job which was using the Codacy API but now we run the Codacy/GitHub integration so we don't need the API anymore. Therefore I removed the API access token (maybe I shouldn't have done it yet). Anyway, rebasing on master should solve the problem.
Or just cherry-pick that commit
Michael Barz
@micbar
The target is to move everything to GitHub workflows
Seen that. I hope it doesn't break anyhthing during our planned code freeze.
Michael Barz
@micbar
@labkode I wrote you an email. We need to sync these changes. Today it cost us a 4h delay on the reva experimental branch.
Michael Barz
@micbar
@vascoguita where did the code coverage report go? IMO we need to send the coverage report to codacy. Can you do that with the Codacy/GitHub integration?
Michael Barz
@micbar
we have two test pipelines which create code coverage, unit tests and integration tests.
Both coverage reports should be sent to codacy and aggregated.
@micbar That PR was not suppose to be merged. It was a test to see how Drone would behave with less concurrent containers. I reverted the merge already.