Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 2019 14:40
    klipach commented #241
  • Jan 31 2019 11:21
    localheinz commented #237
  • Jan 31 2019 09:46
    csarrazi commented #241
  • Jan 31 2019 09:45
    csarrazi commented #237
  • Jan 31 2019 09:45

    csarrazi on 1.3

    Fix: Remove cache-related servi… (compare)

  • Jan 31 2019 09:45
    csarrazi closed #237
  • Jan 31 2019 09:33
    csarrazi commented #242
  • Jan 25 2019 14:50
    csarrazi commented #243
  • Jan 25 2019 14:50
    csarrazi closed #243
  • Jan 25 2019 14:50

    csarrazi on master

    Update available_middleware.md … (compare)

  • Jan 25 2019 14:44
    Warxcell opened #243
  • Jan 25 2019 14:44
  • Jan 23 2019 17:23
    fnash opened #242
  • Jan 22 2019 18:25
    vincentRaiffe starred csarrazi/CsaGuzzleBundle
  • Jan 16 2019 09:25
    godilley starred csarrazi/CsaGuzzleBundle
  • Jan 15 2019 20:55
  • Dec 07 2018 20:02
    kriswallsmith starred csarrazi/CsaGuzzleBundle
  • Dec 07 2018 05:01
    antograssiot edited #240
  • Dec 06 2018 11:03
    antograssiot edited #240
  • Dec 06 2018 10:46
    antograssiot edited #240
Charles Sarrazin
@csarrazi
Currently, the only reason why the master branch is in dev is because I wanted to make the profiler layout compatible with both the new and old layouts.
I actually started by creating a PR based on the master branch, but I changed my mind, and actually intend to do this in the 1.x branch
(And of course the 2.0 branch)
Also, the 1.x branch will be maintained until support for version 5.x of guzzle is dropped.
JHGitty
@JHGitty
We use PHP 5.6 everywhere. :) I hate legacy PHP versions.
ok, thanks! :)
Charles Sarrazin
@csarrazi
True. But Guzzle 6 induced a huge BC break, which makes it difficult to migrate from 5 to 6 (PSR-7 + middleware, vs Subscribers).
And many people still use Guzzle 5 for that reason
JHGitty
@JHGitty
so sounds good to me to use guzzle 6 for new projects :D
thanks for explaination :)
Charles Sarrazin
@csarrazi
Of course! ;)
You'll use Guzzle 6 for a new project!
@Khez I will take my existing PR (fixing the profiler toolbar for SF 2.8), and merge it in both 1.3 and master. Ok?
Cristian Lupu
@Khez
go for it :D
I'll check it later and maybe see if I can add some extra fixes :)
if required
JHGitty
@JHGitty
yeah, SF2.8 support :D thats good because currently we use SF2.8 here :)
Charles Sarrazin
@csarrazi
FYI, I just pushed two releases: v1.3.9 and v2.0.0-RC1.
Théo FIDRY
@theofidry
:+1:
JHGitty
@JHGitty
yeah! :)
Théo FIDRY
@theofidry
@csarrazi any update regarding the toolbar integration for the v2?
Charles Sarrazin
@csarrazi
@theofidry the toolbar is already supported. The only missing thing is the profiler integration.
Théo FIDRY
@theofidry
@csarrari ok :)
Charles Sarrazin
@csarrazi
Hey @Khez! Any news on the profiler update?
If you don't have time, I should be able to work on this by the end of next week.
Charles Sarrazin
@csarrazi
Release 2.0.0 yesterday evening! \o/
Théo FIDRY
@theofidry
Yeah! \o/
Charles Sarrazin
@csarrazi
Next step: bring back support for guzzle services with Guzzle 6 + serializer support.
Théo FIDRY
@theofidry
indeed that would be great
Harrison Heck
@nesl247
@csarrazi Do you have a few minutes to debug the bundle?
Found a few bugs that prevent the use of the bundle at the moment.
Harrison Heck
@nesl247
Nevermind @csarrazi.
Charles Sarrazin
@csarrazi
Welcome to the chan, @nesl247 ! ;)
It could be interesting to explain what you were trying to achieve, though, so I can see whether there's some piece of development which could be done to improve your development life! ;)
Fabien Bourigault
@fbourigault
Hi, I'm configuring two clients from prepend() of my DI extension. In the compiled container, I have
        $a = new \UL();
        $a->push($this->get('csa_guzzle.middleware.stopwatch'), 'stopwatch');
        $a->push($this->get('csa_guzzle.middleware.logger'), 'logger');
        $a->push($this->get('csa_guzzle.middleware.history'), 'history');
and an error about class UL not found
Fabien Bourigault
@fbourigault
Final configuration (from debug:config CsaGuzzleBundle):
csa_guzzle:
    clients:
        first_client: { config: { base_uri: '%base_uri%', headers: { Authorization: 'Bearer %token%', Content-Type: %content_type_client1% } }, class: GuzzleHttp\Client, lazy: false, middleware: {  }, alias: null }
        second_client: { config: { base_uri: '%base_uri%', headers: { 0: 'Authorization: Bearer %token%', Content-Type: %content_type_client2% } }, class: GuzzleHttp\Client, lazy: false, middleware: {  }, alias: null }
    profiler:
        enabled: true
        max_body_size: 65536
    logger:
        enabled: true
        service: null
        format: '{hostname} {req_header_User-Agent} - [{date_common_log}] "{method} {target} HTTP/{version}" {code} {res_header_Content-Length}'
        level: debug
    cache:
        enabled: false
        adapter: null
    mock:
        enabled: false
        mode: replay
of course %% strings have their real values in the output of debug:config CsaGuzzleBundle
Fabien Bourigault
@fbourigault
I posted a bug report symfony/symfony#17353 but it works with 2.8.1. I have to upgrade my project to 2.7.8 to check if it stills occurs.
JHGitty
@JHGitty
hey guys I have a question.
I like to create a API, maybe will put it on github as it is working fine. For it I think guzzle would be a nice idea to use.
So should my own bundle require CsaGuzzleBundle? is that a good idea? or could I directly require only Guzzle?
if I only use Guzzle directly, will the profiler work if somebody additionally add CsaGuzzleBundle?
or is it only working if my bundle directly use CsaGuzzleBundle as dependency?
Joseph Rouff
@rouffj
Hi @csarrazi, Did you have any answer related to your question (https://gitter.im/guzzle/guzzle?at=558a8f803e3f225219fd58e3) about guzzle-services and guzzle-command. I would like to use them, but not compatible with guzzle6. As of now, Did you use one of them ? Thanks.
Luc Vieillescazes
@iamluc
Hi @csarrazi. I have a some troubles about middleware blacklisting. It seems it is allowed to mix blacklisting with whitelisting (https://github.com/csarrazi/CsaGuzzleBundle/blob/master/tests/DependencyInjection/CompilerPass/MiddlewarePassTest.php#L60).
IMO, it should no be the case, as blacklisting only one middleware results to no middleware at all (because of https://github.com/csarrazi/CsaGuzzleBundle/blob/master/src/DependencyInjection/CompilerPass/MiddlewarePass.php#L177)
Charles Sarrazin
@csarrazi
Hey @iamluc! I don't know if you took a look at the bundle recently, but all whitelisting / blacklisting issues are fixed in master, now! :)
Luc Vieillescazes
@iamluc
Yep, thanks ;-)
pimvdberg
@pimvdberg
Hi, how can i make a middleware that is used by only 1 client?