by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 11 2019 21:37
    EricCrosson commented #67
  • Dec 11 2019 21:37
    EricCrosson commented #67
  • Dec 11 2019 21:35
    EricCrosson commented #67
  • Dec 11 2019 21:34
    EricCrosson opened #67
  • Nov 11 2019 21:29
    EricCrosson closed #66
  • Nov 11 2019 21:29
    EricCrosson commented #66
  • Nov 11 2019 16:24
    EricCrosson edited #66
  • Nov 11 2019 15:14
    EricCrosson opened #66
  • Nov 01 2018 22:52
    lulalachen opened #65
  • Oct 25 2018 04:28
    lulalachen commented #63
  • Sep 13 2018 09:36
    cullophid commented #64
  • Aug 31 2018 15:34
    maxdietrich commented #64
  • Aug 21 2018 09:39
    cullophid commented #64
  • Jul 30 2018 07:38
    maxdietrich opened #64
  • Jun 24 2018 20:06
    mgtitimoli commented #34
  • May 30 2018 16:05
    lulalachen commented #63
  • May 26 2018 13:34
    cullophid commented #63
  • May 26 2018 13:34

    cullophid on master

    fix sub cross year issue (#63) (compare)

  • May 26 2018 13:34
    cullophid closed #63
  • May 24 2018 05:20
    lulalachen synchronize #63
Ludwig Magnusson
@TheLudd
can you push the tags to github?
Andreas Møller
@cullophid
what do you mean ?
Ludwig Magnusson
@TheLudd
Do you bump version with npm version?
Andreas Møller
@cullophid
no i just updated package.json
Ludwig Magnusson
@TheLudd
ah...
If you do a tag is created.
you can do npm version [major,minor,patch]
And if you push the tags they will show here https://github.com/cullophid/date-fp/releases
Andreas Møller
@cullophid
ah ill start doing that
Andreas Møller
@cullophid
thats cool I have never actually used that :)
@TheLudd will you add changify and update circle.yml to run it on commit ?
Ludwig Magnusson
@TheLudd
Can look at it later. No time now and not familiar with circle
Perhaps this week
Andreas Møller
@cullophid
sure :)
David Chambers
@davidchambers
I see a few familiar faces and a few new ones. Hello, all!
Stefano Vozza
@svozza
welcome david! :)
Aldwin Vlasblom
@Avaq
Heya
Ludwig Magnusson
@TheLudd
Not very active here but hello hello :)
Andreas Møller
@cullophid
Ha no sorry I have not been here for a while
I need to setup some notifications :)
I am working on writing a proper parser, once its done and people are happy with it we can start doing some PR on twitter etc.
Im also very interested in hearing peoples opinion on adding sanctuary style Either monads in stead of returning Errors.
Ludwig Magnusson
@TheLudd
@cullophid There is actually an instance of Date called invalid date. Seems to be the most proper thing to return to me
Andreas Møller
@cullophid
I agree, but as with most thing related to javascript dates, its not easy to use / check for
Ludwig Magnusson
@TheLudd
But it is the same type
Andreas Møller
@cullophid
yes
its better than returning an error
well that is, its sort of the same type
they are both 'object'
My idea is to return Either monads when applicable, we can then include a simple interface that just extracts the value and throws errors if some people dont'
like monads
im not sure what is the best solution, so I value your opinions :)
Ludwig Magnusson
@TheLudd
Well it is a Date instance. It has all the method that a regular Date instance has
Andreas Møller
@cullophid
true
and we do have a isValid function
It might be good enough
Stefano Vozza
@svozza
That will increase the size of the library a fair bit because we'll have to include the monad types (hopefully the ones from sanctuary), which is fine for people who sign up for the monad stuff but maybe not for everyone else
Andreas Møller
@cullophid
yes
Though I think we only need one monad type
im a bit torn on this. I do Think @TheLudd makes a very valid point...
The main problem I have with Invalid Date is that its not very informative
Andreas Møller
@cullophid
I think maybe the solution is to go with Invalid Date for now, and then make sure that all functions that returns errors returns invalid dates in stead.
Then later we can add support for mondas
Andreas Møller
@cullophid
We currently have a PR for version 3 up, with a brand new parser.
This is IMO the last step we need before date-fp can replace OO libraries like Moment
Ludwig Magnusson
@TheLudd
:+1:
Andreas Møller
@cullophid
then tweets then fame!
Andreas Møller
@cullophid
New Documentation is live! checkout the fancy gitbook on evilcorp.limited/date-fp
Stefano Vozza
@svozza
:thumbsup:
Stefano Vozza
@svozza
very rough POC for type safe and monadified version of date-fp:
svozza/sanctuary-date-poc-2#1