It's been around about a month but more issues concerning it keep popping up on GitHub centering around 10 days ago, likely as the distributions start packaging it.
At least it looks very much related in my mind. The folks at #php on irc.libera.chat thought that was not very likely though when we were chatting yesterday
That library is required for 2FA module QR-Code generation, right?
I already patch it out of composer.json because the GD library dependency is a bit heavyweight for me.
I already patch it out of composer.json because the GD library dependency is a bit heavyweight for me.
1 reply
jasonmunro (Jason Munro) Is this a case of browsers being broken with compression applied or are we lacking a necessary response header to keep them happy?
Anyhow. I can confirm that disabling compression fixes the issue. It also confirms that php_version_compare works on my system in this context.
Talking of which, the super-globals clearing function will need a revisit due to the the issue being addressed twice - once with the php_version_compare (which doesn't appear to work for me) and then with the iterative unset() of the variables. The php_version_compare could now be removed.
Talking of which, the super-globals clearing function will need a revisit due to the the issue being addressed twice - once with the php_version_compare (which doesn't appear to work for me) and then with the iterative unset() of the variables. The php_version_compare could now be removed.
marclaporte_gitlab (Marc Laporte) Interesting that the GD library which is needed for 2FA is marked as a suggests in composer.lock but the top-level libraries are required. Could they not all be marked as suggests?
So all extensions by the way.... like mbstring,openssl etc or just dependencies needed in 2FA?
ElvisAns (Elvis Ansima) Some research required. If a module is optional then I would suggest the external libraries needed to use it should not be a hard requirement e.g. if you don't want 2FA then no need for QR-Code/Barcode/GD support either.
What does @jasonmunro says about this idea?
And if user tries a feature when dependency is missing: there should be a helpful (and maybe even friendly) error message
@jasonmunro Is there a good way to limit feeds in the everything view? It would be nice to show the latest x feeds and/or limit them by recency, they seem to crowd out emails. Limiting the everything source count doesn't really help because the feeds still overpower the emails. Probably because I don't get enough emails every day.
no built in way I'm afraid, if you want to hack the code you can change $limit here: https://github.com/jasonmunro/cypht/blob/master/modules/feeds/modules.php#L204
This is with PHP 8.0.17 on the master branch, I haven't tried any other versions. One strange thing I noticed is that the First Page after Login is stuck at "None" and it won't save if I try to. I tried a bunch of other settings and didn't have any issue with those saving. So when I log in I get shown "Home" no matter what.
I reverted back to here: jasonmunro/cypht@8a7484c before all the PHP 8.1 fixes and now it is working.
kk6mrp (Weston Miller) Feed handling is a bit fragile. I've got one that won't delete. I think it's because it has a punctuation character (') in the name.
folks: when people are stuck in Github issues that unreproducible, I ask them to come to this room, where a junior dev will troubleshoot with them.
Hello! I'm the author of this comment https://github.com/jasonmunro/cypht/issues/439#issuecomment-1120485927 (Cypht fails to archive mails from the unified inbox view). Sorry for taking a while to join. Please tell me how I can help troubleshoot
Jean-Paul is a fast-learning junior developer and this is a good learning opportunity
So he needs access to a system which has the issue, where he can put debugging code. So can you reproduce in a place with no confidential info?
I might have found something. Around line 918 (I have edited the file, so it might be off a couple of lines) of the file modules/imap/handler_modules.php there is an if statement that reads:
elseif ($form['action_type'] == 'archive' && $archive_folder && $archive_folder != hex2bin($folder))The condition is not met because $archive_folder is unset.
This is because, around line 892 of the same file, this test fails:
if (array_key_exists($server, $specials)) {I believe to have fixed the issue, perhaps somebody more familiar with the code can review the change?
I replaced the body of the following if statement (around line 890):
if ($form['action_type'] == 'archive') {with:
if(array_key_exists('archive', $specials)) {
if($specials['archive']) {
$archive_folder = $specials['archive'];
}
}I essentially copied the code referring to the trash folder just above. It seems that the previous code expected $specials[$server]['archive'] to exist but, at least in my case, $specials already refers to one specific server.
