Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 09 2017 16:18

    jacwright on master

    Removing fonts needed by < IE9 … Shorten ids again Fix scroll lock, bugs, tests (compare)

  • May 03 2017 23:29

    jacwright on master

    Fix up additional CSS and code … Fix autoscroll from firing on c… (compare)

  • May 02 2017 18:00

    jacwright on master

    Moving public folder (compare)

  • May 02 2017 17:55

    jacwright on greenkeeper-electron-builder-17.1.2

    (compare)

  • May 02 2017 17:43

    jacwright on master

    chore(package): update electron… (compare)

  • May 02 2017 17:43
    jacwright closed #384
  • May 02 2017 17:43
    jacwright synchronize #384
  • May 02 2017 17:43

    jacwright on greenkeeper-electron-builder-17.1.2

    chore(package): update electron… Merge branch 'master' into gree… (compare)

  • May 02 2017 17:42

    jacwright on greenkeeper-electron-config-1.0.0

    (compare)

  • May 02 2017 17:42

    jacwright on master

    chore(package): update electron… (compare)

  • May 02 2017 17:42
    jacwright closed #383
  • May 02 2017 17:36

    greenkeeper[bot] on initial

    chore(package): update dependen… docs(readme): add Greenkeeper b… (compare)

  • May 02 2017 17:28
    jacwright synchronize #384
  • May 02 2017 17:28

    jacwright on greenkeeper-electron-builder-17.1.2

    Initial db loading Change to new database structur… Add build step in test back in and 2 more (compare)

  • May 02 2017 17:27
    jacwright synchronize #383
  • May 02 2017 17:27

    jacwright on greenkeeper-electron-config-1.0.0

    Initial db loading Change to new database structur… Add build step in test back in and 2 more (compare)

  • May 02 2017 17:25

    jacwright on database-rework

    (compare)

  • May 02 2017 17:25

    jacwright on master

    Initial db loading Change to new database structur… Add build step in test back in and 1 more (compare)

  • May 02 2017 17:25
    jacwright closed #385
  • May 02 2017 17:20
    jacwright synchronize #385
Jacob Wright
@jacwright
I don’t want any of their toolbars.
just the core engines
Matt
@matthopson
Also I totally misunderstood your question about testing. I thought you meant brunchs haha
Jacob Wright
@jacwright
:)
Testing with a brunch-based build
Matt
@matthopson
This is something we're investing some time into now at TS.
Trying being a weak point for me, I'm excited about it
*testing (getting reacquainted with the iPhone keyboard)
Jacob Wright
@jacwright
haha
Jacob Wright
@jacwright
dabblewriter/dabble#28
Took me a few days, sorry
Jacob Wright
@jacwright
Also, because of porting from the prototype, there may be extraneous class names or other vestiges fom there. Some of them will be useful for unported features (drag-drop) so I didn’t delete them. Others I might have just missed.
Jacob Wright
@jacwright
That nav piece unlocks everything else
Now that we have nav and can create folders/files we can fill in the rest in parallel
or whatever order we need
hmm, actually, need the “selection” piece for selecting a file/folder first
simple redirect on clicking the file/folder
Jacob Wright
@jacwright
@/all been adding tasks that need to be done next to https://github.com/dabblewriter/dabble/issues. Please add any that need to be there (or you’d like to be). And if you are going to work on one assign it to yourself before beginning.
Matt
@matthopson
:+1:
Jacob Wright
@jacwright
dabblewriter/dabble#34 is a little options system to allow customizing the behavior of different types of files/folders/projects.
Trying to get rid of logic from the current codebase (as well as not perpetuate from the old) for treating certain types in a certain way and making it configurable. E.g. the stuff would have things like if (model instanceof Book || item instanceof Chapter || item instanceof Part) {…
And already we have [unless]="item.class === ‘Project’" in our code so you don’t delete a project for e.g.
Jacob Wright
@jacwright
Moved files around to match a chip brunch app. Be sure to pull before doing much work.
Jacob Wright
@jacwright
Been working on a better drag-drop reorder solution than the alpha had.
Matt
@matthopson
For #32 - what do you think about this approach? https://github.com/dabblewriter/dabble/compare/32-navigate-file-folder
There's a small abstraction for a clicked nav item to route the click action.
Jacob Wright
@jacwright
We need to have folders be selectable. A folder should be able to be a view onto its children.
Or at least, we need to allow it to be. Perhaps it could be configurable.
Matt
@matthopson
Ah, so clicking a folder shouldn't toggle child view (or like you said, be configured to do so)
Jacob Wright
@jacwright
If you check out www.dabblewriter.com/alpha/ more closely you’ll note that “manuscript”, “book”, and “chapter” are all folders. When you click on them they display the whole book but scrolled to that section.
yeah
Matt
@matthopson
In that case, the navItemClicked method (or whatever you want to call it) could still work with this
Jacob Wright
@jacwright
And “plot” and “plot line” are folders which display all the “plot point” files in them.
Matt
@matthopson
Or do you think that gets a little dirty?
Jacob Wright
@jacwright
what do you think?
Matt
@matthopson
My thought was all logic related to a clicked nav item could go through the one place to simplify the template a little
I don't think it's so bad.
But of course simplification here, adds complexity there..
Jacob Wright
@jacwright
We need a click handler on the toggle arrow in addition. So that folders that can be selected can be open/closed by the toggle without being selected.
Matt
@matthopson
Yup. That can go back on there.. I was actually having some issues killing the event propagation - but since I was assuming clicking the name would do essentially the same thing, I dropped it
Jacob Wright
@jacwright
So we need that to always toggle. But we’re discussing now whether certain folders will open/close when you click on their name.
Matt
@matthopson
Which will come from options, yeah?
Jacob Wright
@jacwright
yeah, folder.options.selectable or something like that. What do you think the default should be?
Matt
@matthopson
I think it makes sense to click the name to toggle it since it's an easy target - but if there's going to arbitrarily be additional options with clicking it, then maybe we should never toggle by default. It could get confusing
Jacob Wright
@jacwright
We should have the undefined state of options be the default. So either selectable if the default is not selectable, or unselectable if the default is to be selectable.
true, maybe be consistent.
otherwise users will get confused and frustrated
Matt
@matthopson
Yup