@dalanmiller I would recommend looking into using https://github.com/codegangsta/negroni instead (which is made by the same author)
Its a bit more "idiomatic"
I think abstracting away
net/http isn't a good practice
For the sake of completeness, would you like me to put together an example of what I was talking about? A good way to stream large numbers of responses without taking forever.
func fastHandler(w http.ResponseWriter, req *http.Request) {
res, err := r.DB("pi_baker").Table("observations").
OrderBy(r.Desc("datetime")).
Limit(5760).
Pluck("datetime", "temp", "humidity").
Run(session)
if err != nil {
log.Fatalln(err.Error())
}
w.Header().Set("Content-Type", "application/json")
encoder := json.NewEncoder(w)
var row map[string]interface{}
for res.Next(&row) {
err = encoder.Encode(row)
if err != nil {
// Oh no! Something bad happened!
// Since we're not buffering the response, we aren't going to send an
// error code and message. Maybe you can log the error and continue.
}
}
}
Untested in terms of performance, but to the best of my knowledge that would stream the results as individual json objects, newline delimited. So you could hack in array formatting to make it a valid json object (
[,commas between each item, and ]) or make your handler consume it line-by-line.
The call to
.Encode() will write each object to the http connection, not storing it in memory. Probably the best way to handle actually massive amounts of data.
var results []map[string]interface{} = make([]map[string]interface{}, 0)
var row map[string]interface{}
for res.Next(&row) {
results = append(results, row)
}
jsonBytes, err := json.Marshal(results)
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
// Logging goes here
return
}
w.Header().Set("Content-Type", "application/json")
w.Write(jsonBytes)
Just curious if the dependency on the hailocab protobuf fork is intentional, or accidental. https://github.com/dancannon/gorethink/blob/master/ql2/ql2.pb.go
Fixes some issues with enums
How would I accomplish this in GoRethink?
r.db("store").table("shelves").filter(r.row("products").contains(function(product) { return product('id').eq("122f0054-fb41-46d6-9c50-bc158ec9a2ff") }))
I've scoured the GitHub repo & docs but am none the wiser. I assume this is quite simple & I'm just missing something?
Hmm i wonder if the value of GeneratedKeys is correct, could you try running your code and log that value and see what is logged when your session is empty?
And just to double check, you are checking the error returned by both
Run and One?
@prophittcorey would it be possible for you to post the entire code so I can run some more detailed tests? If you are not comfortable posting here you could maybe email it?
Great thanks
There seems to be an issue when you unmarshal the time into the CreatedAt term
I dont think so no
For now you can fix your code by changing the
CreatedAt field to time.Time and setting it with time.Now() instead of db.Now()
Just out of curiosity why did you decide to use the rethinkdb time functions?
Yeah even though I think there is an issue with the driver not handling this properly (it should probably error since you cant convert a time back to a gorethink
Term) I think using the Go time package is the best thing for you to do
No worries, let me know if you have any other questions
