dancannon/gorethink

Please use #gorethink on the RethinkDB slack

Daniel Cannon

@dancannon

Fixes some issues with enums

Lenny Händler

@algor1th

how do i call GetAll()? can anyone give me an example?

Lenny Händler

@algor1th

oh, i found it, it is called GetAllByIndex() for my needs

Daniel Cannon

@dancannon

@NoSkillDwnload glad you sorted it out, let me know if you have any further questions

NeonMonk

@NeonMonk

How would I accomplish this in GoRethink?

r.db("store").table("shelves").filter(r.row("products").contains(function(product) { return product('id').eq("122f0054-fb41-46d6-9c50-bc158ec9a2ff") }))

I've scoured the GitHub repo & docs but am none the wiser. I assume this is quite simple & I'm just missing something?

NeonMonk

@NeonMonk

Can you please confirm if this is the appropriate way to achieve this?

table := r.Table("store")
query := table.Filter(r.Row.Field("shelves").Contains(func (product r.Term) interface{} {
    return product.Field("id").Eq(product.ID)
}))

fazal

@faxal

r.DB("store").Table("shelves").Filter(r.Row("products").Contains(func (product r.Term) interface{} { return product.Field("id").Eq("122f0054-fb41-46d6-9c50-bc158ec9a2ff")}))

William McGann

@tehbilly

What's the return from the call to cursor.One()? Hard to tell from that snippet what error checking/printing is going on

Daniel Cannon

@dancannon

Hi @prophittcorey just having a look now

Hmm i wonder if the value of GeneratedKeys is correct, could you try running your code and log that value and see what is logged when your session is empty?

And just to double check, you are checking the error returned by both Run and One?

Daniel Cannon

@dancannon

Ok great thanks for checking

@prophittcorey would it be possible for you to post the entire code so I can run some more detailed tests? If you are not comfortable posting here you could maybe email it?

Great thanks

Daniel Cannon

@dancannon

@prophittcorey Ok I think I have found the cause of the issue

There seems to be an issue when you unmarshal the time into the CreatedAt term

I dont think so no

For now you can fix your code by changing the CreatedAt field to time.Time and setting it with time.Now() instead of db.Now()

Just out of curiosity why did you decide to use the rethinkdb time functions?

Yeah even though I think there is an issue with the driver not handling this properly (it should probably error since you cant convert a time back to a gorethink Term) I think using the Go time package is the best thing for you to do

No worries, let me know if you have any other questions

Daniel Cannon

@dancannon

@prophittcorey Oh just noticed you were not actually checking the error returned by One. It looks like it was actually returning an error

Daniel Cannon

@dancannon

@prophittcorey You just need err = cursor.One(&session) instead of just cursor.One(&session)

Suyash Katiyar

@skatiyar

@dancannon is current release of driver compatible with rethinkdb 2.2??

Daniel Cannon

@dancannon

@SKatiyar I have not yet update the driver to support the new features but it should be compatible . Let me know if you have any issues

Suyash Katiyar

@skatiyar

@dancannon was thinking of putting new changefeed feature in driver

Daniel Cannon

@dancannon

If you have the time I would really appreciate it.

Suyash Katiyar

@skatiyar

cool should open a issue first??

Daniel Cannon

@dancannon

Sure feel free

Suyash Katiyar

@skatiyar

and any particular point from where i can start??

Daniel Cannon

@dancannon

I will add it to the 1.2 milestone

I havnt looked into what needs to be changed yet but I imagine it will require changing the options struct for the Changes term and creating some new tests for the new response structure

Suyash Katiyar

@skatiyar

adding new option to struct, apart from that do i need to touch any other functionality??

Daniel Cannon

@dancannon

I have no idea sorry! Usually the first thing I do is look at how one of the official drivers has implemented the change

Suyash Katiyar

@skatiyar

cool, will do that. Will ask you if I run into any problems.

Daniel Cannon

@dancannon

Yeah feel free, I should be online for a while

Suyash Katiyar

@skatiyar

how can we see output while running tests??
go test -v doesn’t seem to work

fazal

@faxal

with Log or Logf

Suyash Katiyar

@skatiyar

@dancannon to add new command values do we have to get proto file from rethinkdb repo??

Daniel Cannon

@dancannon

@SKatiyar Yes the proto file needs to be updated

Regarding the test output try using the flag -gocheck.vv

Suyash Katiyar

@skatiyar

@dancannon driver doesn't seem to have connection event implemented. Should I look into implementing them??

Daniel Cannon

@dancannon

@SKatiyar What do you mean by "connection event"?

Suyash Katiyar

@skatiyar

http://rethinkdb.com/api/javascript/#event_emitter

Daniel Cannon

@dancannon

Hmm, can you think of a use case for this?

My understanding is that this is provided by the JS driver as it is a feature of the JS connection itself

Suyash Katiyar

@skatiyar

as of now only reconnect seems only one

Daniel Cannon

@dancannon

I dont think it is in any other drivers

In gorethink this tends to be handled internally

Especially since GoRethink has a host and connection pool so the driver user shouldnt really need to care about reconnections

Where communities thrive

People

Repo info

Activity