Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 07 15:52
    GaikwadPratik closed #493
  • Apr 07 15:14
    Gerrit91 edited #500
  • Apr 07 15:09
    Gerrit91 edited #500
  • Apr 07 15:05
    Gerrit91 edited #500
  • Apr 07 15:02
    Gerrit91 edited #500
  • Apr 07 14:58
    Gerrit91 edited #500
  • Apr 07 14:52
    Gerrit91 edited #500
  • Apr 07 14:42
    Gerrit91 commented #493
  • Apr 07 13:45
    Gerrit91 edited #500
  • Apr 07 13:44
    Gerrit91 edited #500
  • Apr 07 13:37
    Gerrit91 opened #500
  • Sep 26 2021 22:12
    CodyDWJones edited #499
  • Sep 26 2021 22:12
    CodyDWJones opened #499
  • Sep 26 2021 20:07
    CodyDWJones closed #498
  • Sep 24 2021 17:24
    CodyDWJones commented #497
  • Sep 24 2021 17:06
    CodyDWJones closed #497
  • Sep 23 2021 21:42
    CodyDWJones commented #498
  • Sep 23 2021 14:35
    CMogilko commented #498
  • Sep 23 2021 13:49

    CMogilko on master

    Upgrade to Python 3.8 (#496) *… (compare)

  • Sep 23 2021 13:49
    CMogilko closed #496
Daniel Cannon
@dancannon
For now you can fix your code by changing the CreatedAt field to time.Time and setting it with time.Now() instead of db.Now()
Just out of curiosity why did you decide to use the rethinkdb time functions?
Yeah even though I think there is an issue with the driver not handling this properly (it should probably error since you cant convert a time back to a gorethink Term) I think using the Go time package is the best thing for you to do
No worries, let me know if you have any other questions
Daniel Cannon
@dancannon
@prophittcorey Oh just noticed you were not actually checking the error returned by One. It looks like it was actually returning an error
Daniel Cannon
@dancannon
@prophittcorey You just need err = cursor.One(&session) instead of just cursor.One(&session)
Suyash Katiyar
@skatiyar
@dancannon is current release of driver compatible with rethinkdb 2.2??
Daniel Cannon
@dancannon
@SKatiyar I have not yet update the driver to support the new features but it should be compatible . Let me know if you have any issues
Suyash Katiyar
@skatiyar
@dancannon was thinking of putting new changefeed feature in driver
Daniel Cannon
@dancannon
If you have the time I would really appreciate it.
Suyash Katiyar
@skatiyar
cool should open a issue first??
Daniel Cannon
@dancannon
Sure feel free
Suyash Katiyar
@skatiyar
and any particular point from where i can start??
Daniel Cannon
@dancannon
I will add it to the 1.2 milestone
I havnt looked into what needs to be changed yet but I imagine it will require changing the options struct for the Changes term and creating some new tests for the new response structure
Suyash Katiyar
@skatiyar
adding new option to struct, apart from that do i need to touch any other functionality??
Daniel Cannon
@dancannon
I have no idea sorry! Usually the first thing I do is look at how one of the official drivers has implemented the change
Suyash Katiyar
@skatiyar
cool, will do that. Will ask you if I run into any problems.
Daniel Cannon
@dancannon
Yeah feel free, I should be online for a while
Suyash Katiyar
@skatiyar
how can we see output while running tests??
go test -v doesn’t seem to work
fazal
@faxal
with Log or Logf
Suyash Katiyar
@skatiyar
@dancannon to add new command values do we have to get proto file from rethinkdb repo??
Daniel Cannon
@dancannon
@SKatiyar Yes the proto file needs to be updated
Regarding the test output try using the flag -gocheck.vv
Suyash Katiyar
@skatiyar
@dancannon driver doesn't seem to have connection event implemented. Should I look into implementing them??
Daniel Cannon
@dancannon
@SKatiyar What do you mean by "connection event"?
Daniel Cannon
@dancannon
Hmm, can you think of a use case for this?
My understanding is that this is provided by the JS driver as it is a feature of the JS connection itself
Suyash Katiyar
@skatiyar
as of now only reconnect seems only one
Daniel Cannon
@dancannon
I dont think it is in any other drivers
In gorethink this tends to be handled internally
Especially since GoRethink has a host and connection pool so the driver user shouldnt really need to care about reconnections
Suyash Katiyar
@skatiyar
ok cool was wondering if its driver specific or more of a rethink thing
Daniel Cannon
@dancannon
If you think it would be useful + know how to implement it then go for it. I am just not sure if we need it
Suyash Katiyar
@skatiyar
for now lets punt it, if needed will do it.
what drivers do you take for reference usually??
Daniel Cannon
@dancannon
Python + rethinkdbdash
Daniel Cannon
@dancannon
@SKatiyar have you started work on .Server()?
Daniel Cannon
@dancannon
I had a go at it as well and changed the cluster connection code to use a hostpool. Let me know what you think @SKatiyar https://github.com/dancannon/gorethink/compare/develop...feature/server-info
If you have already worked on the Server function I would like to see how you solved it
Suyash Katiyar
@skatiyar
@dancannon i did a very simple thing, SKatiyar/gorethink#3
did not test it yet
so not sure if it works
Suyash Katiyar
@skatiyar
@dancannon testing the local code becomes a pain when proto spec changes, any easy way to rewrite the imports for local testing??
Daniel Cannon
@dancannon
@SKatiyar not sure what you mean? Are you using and old version of RethinkDB?
Also the reason that I put the query code into the Connection and bubbled up the result is that eventually I want to use this function in the cluster connection code and I didnt want to duplicate the query.
Its not ideal having to put the Server call in so many different files but I think it is still manageable
Suyash Katiyar
@skatiyar
the fork of repo still uses “github.com/dancannon/gorethink/ql2
so when testing local changes, have to rewrite the import in multiple files
just wondering any good way, apart from linux utility like sed etc.