I havnt looked into what needs to be changed yet but I imagine it will require changing the options struct for the Changes term and creating some new tests for the new response structure
Regarding the test output try using the flag
-gocheck.vv
My understanding is that this is provided by the JS driver as it is a feature of the JS connection itself
In gorethink this tends to be handled internally
Especially since GoRethink has a host and connection pool so the driver user shouldnt really need to care about reconnections
what drivers do you take for reference usually??
I had a go at it as well and changed the cluster connection code to use a hostpool. Let me know what you think @SKatiyar https://github.com/dancannon/gorethink/compare/develop...feature/server-info
If you have already worked on the Server function I would like to see how you solved it
did not test it yet
so not sure if it works
Also the reason that I put the query code into the
Connection and bubbled up the result is that eventually I want to use this function in the cluster connection code and I didnt want to duplicate the query.
Its not ideal having to put the
Server call in so many different files but I think it is still manageable
the fork of repo still uses “github.com/dancannon/gorethink/ql2”
so when testing local changes, have to rewrite the import in multiple files
so when testing local changes, have to rewrite the import in multiple files
just wondering any good way, apart from linux utility like sed etc.
The reason for
GetNextNode is that I switched to using the go-hostpool library which means that the host selection is no longer random but instead based on the errors and response times for each host
That's what I do as well, get then upstream changes. To move your package and not lose your changes: https://godoc.org/golang.org/x/tools/cmd/gomvpkg