Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Thibault Duchateau
@tduchateau
nice
Ready to PR?
Rizzi
@RizziCR
start of next week.. no time currently.. friday 17:00 MET the projects goes live :)
and i have a lot to do before
Thibault Duchateau
@tduchateau
sure, no problem
I'll open the issue
Rizzi
@RizziCR
ok
bad time calculation of me :P
or to many changes from customer side
Thibault Duchateau
@tduchateau
feel free to propose a PR when you have time, it's not a major one :-)
Rizzi
@RizziCR
i don’t know ;)
yes.. i also have to check if its also in the current version.. this project build with 0.10.1 :)
but a question.. for what is pattern on the fillWithProperty method ?
fillWithProperty(String propertyName, String pattern, String defaultContent)
Thibault Duchateau
@tduchateau
just if you need to a apply a MessageFormat on the value
Rizzi
@RizziCR
ok.. and defaultContent is the content if the property is null ?
Thibault Duchateau
@tduchateau
absolutely
Rizzi
@RizziCR
good :D
no need to searching :)
set pattern to null, if i don’t need it ?
Thibault Duchateau
@tduchateau
absolutely, or use the same method but with another signature (without pattrn)
Rizzi
@RizziCR
the isn’t :)
propertyName
propertyName, pattern
propertyName, pattern, defaultContent
Thibault Duchateau
@tduchateau
well, another reason for a PR ;-)
Rizzi
@RizziCR
but hard to do..
only with another method name
Thibault Duchateau
@tduchateau
let's discuss it when you have time to work on it
Rizzi
@RizziCR
yep
Thibault Duchateau
@tduchateau
(dandelion/dandelion-datatables#298)
Rizzi
@RizziCR
thx
i don’t know why.. but i love this „last minute“ working :D
Thibault Duchateau
@tduchateau
last minute? what do u mean?
Rizzi
@RizziCR
2 days to finish and work for 2 weeks :D
Thibault Duchateau
@tduchateau
let's call it "agile" ..
Rizzi
@RizziCR
:)
Rizzi
@RizziCR
nexts question
on export (xls, pdf) sometimes a null value is printed as empty string and sometimes as „null"
also on the same property
Thibault Duchateau
@tduchateau
please provide a test case so that I can reproduce
or it will hard to fix
Rizzi
@RizziCR
if there are for example 10 entities to export
5 of them have propery x null
the exported file have then 3 times an empty string and 2 times the string „null“ as value
Rizzi
@RizziCR
and it’s equal if i set a default content or not.. there are no different
i have to check it later
thx
and the log message is not so useful :)
Something went wrong with the property {}. Check that an accessor method for this property exists in the bean.
Thibault Duchateau
@tduchateau
Oh actually the log message is. All fillWithProperty(*) methods rely on http://commons.apache.org/proper/commons-beanutils/, which uses naming conventions on beans.
So if you call fillWithProperty("beanProperty"), you're supposed to have a getter in the corresponding Bean called getBeanProperty()
It's up to you to check for nulls when you call these getters
Rizzi
@RizziCR
yes.. but on 45 properties its hard to find which on is wrong :D
i do some renaming of properties and have forgotten to change it in the export scripts ;)
Thibault Duchateau
@tduchateau
wow