@Fierozen Feel free to make an issue about validating the inputs of byweekday. Though generally when I make that sort of thing more strict I find that someone was relying on the loose validation for some reason.
@Fierozen Do you have a minimal example that generates this exception problem?
John Black
@Fierozen
@pganssle Thanks. I'll get together the actual code tonight if I can.
little snipit should work
Bernát Gábor
@gaborbernat
Cool
Cheuk Ting Ho
@Cheukting
Hi! I will try "Isoparser misinterprets T24:00 #658" today
Pav A
@rs2
Will look at dateutil/dateutil#124
Cosimo Lupo
@anthrotype
I'll grab this low-hanging fruit dateutil/dateutil#736
Hey, I'm looking into a problem in the python-iCalendar test suite using dateutil 2.7, but I got a bit sidetracked because it seems the dateutil exception thrown is actually wrong.
And I'm unclear as to whether the exception is just incorrectly worded, or if the test ics file is incorrect.
Johannes Löthberg
@kyrias
Ah, just found the place in the RFC, and it seems like the exception message is indeed incorrectly worded.
Paul Ganssle
@pganssle
I suppose you could take the if to be if and only if in that situation.
Paul Ganssle
@pganssle
Oh I guess it's actually a "when"
Matt Cooper
@vtbassmatt
Hey hey. Normally I would send you a phone number, but I'm in an all-afternoon training right now so chat is better :)
Our test analytics stuff (currently) requires you to upload JUnit (or NUnit, or TRX, or a bunch of other formats) results in order to track them. Instead of making you call a REST API or something, we have a "PublishTestResults" task.
Paul Ganssle
@pganssle
Ah.
Is there any way to upload an artifact to somewhere where we can look at it?
_
Matt Cooper
@vtbassmatt
Since the "docs" leg doesn't create any JUnit results, the PublishTestResults task was throwing a warning about no results found. That's not a problem, it's intended, so I just made that step skip when running the Docs job
Yes! There's a PublishBuildArtifacts task which will create an "artifact" that then gets attached to the build.
You can download a ZIP after the build finishes.
Paul Ganssle
@pganssle
Hm... Would be preferable if we could view the contents directly like a website, though a zip file would still be an improvement over "clone the PR branch and build the docs"
I might just bite the bullet on permissions and go with netlify.
Matt Cooper
@vtbassmatt
Yeah... that's one I've heard a few times. You can string something together with an Azure static content publishing feature, but we haven't made that seamless and easy yet. In fact, I ran out of time to publish the blog post I was trying to write on the topic.
Paul Ganssle
@pganssle
Yeah, no problem. I think Steve Dower was planning on doing something similar for CPython's documentation.
Matt Cooper
@vtbassmatt
I got it working somewhere... let me find that link
Paul Ganssle
@pganssle
On the other question - are the permissions going to be automatically linked to the GH org? Is there any way to achieve that?
Matt Cooper
@vtbassmatt
Yeah, was just about to mention that.
We don't have that feature yet. It's something we desperately want to do.
Paul Ganssle
@pganssle
It's not a big deal if not, I just know that I've had that problem with Appveyor especially. When I inherited the dateutil config I ended up getting access to some private Google appveyor jobs because it was linked to the former maintainer's appveyor account.
Matt Cooper
@vtbassmatt
In the short term, it won't actually affect you much. You can set up an account with us, but the project is world-readable (well, you have to set it that way), and almost all the interaction happens from GitHub.
Paul Ganssle
@pganssle
Fixed that up but it's something I'd like to avoid. For now I don't think it will be a problem, I'll just create a custom live account for dateutil.
Matt Cooper
@vtbassmatt
Yeah. That's the problem for now.
Or, you can add several other people as administrators.
Paul Ganssle
@pganssle
Yeah, dateutil is a pretty small project so I'm less worried about that.
I imagine it'll come soon enough anyway since GH is owned by MS now.
Matt Cooper
@vtbassmatt
But yeah... I'm hopeful we get to sync permissions soon. I'm not involved in any work there but I know it's going to happen.