These are chat archives for daviferreira/medium-editor

28th
Mar 2015
Davi Ferreira
@daviferreira
Mar 28 2015 07:38
@secrettriangle I can help later on :shipit:
.P. S. but right now all you have is a lint issue: https://travis-ci.org/daviferreira/medium-editor/builds/55713949
describe instead of fdescribe
Dan Kaplun
@dbkaplun
Mar 28 2015 13:27
@daviferreira well I put that there to test more easily
If you run grunt jasmine you'll see just the tests I'm working on
Davi Ferreira
@daviferreira
Mar 28 2015 14:26
Yeah, silly me, sorry
so, first test you need to either clean up the class attribute or test if the innerHTML contains the font size instead of being equal
because phantomjs is adding a class="Apple-style-span"
or even better, the extension should strip the classes :)
Davi Ferreira
@daviferreira
Mar 28 2015 14:32
same with the last test
the output on phantomjs is '<font class="Apple-style-span" size="7">lorem ipsum</font>'
not sure what is happeing with the second test, but it has something to do with the second fireEvent call
Dan Kaplun
@dbkaplun
Mar 28 2015 16:36
@daviferreira straonge, on my machine it's not adding anything
Dan Kaplun
@dbkaplun
Mar 28 2015 16:42
X should change font size when slider is moved
Expected 'lorem ipsum' to be '<font size="7">lorem ipsum</font>'. (1)
Is that what you're getting?
Davi Ferreira
@daviferreira
Mar 28 2015 17:17
hmm, yeah, might be a phantomjs + linux thing then
Dan Kaplun
@dbkaplun
Mar 28 2015 17:17
I'm on OSX
I've rebased/pushed BTW, same errors
Davi Ferreira
@daviferreira
Mar 28 2015 17:20
hmm
can you try running only the 'Font Size' describe
describe('Font Size', function () {
that is giving me the <font class="Apple-style-span" size="7">
Yeah, I see it too
Davi Ferreira
@daviferreira
Mar 28 2015 17:22
I'm suspecting that something is not being cleaned up on previous tests, I don't know
I think @nmielnik will know better, he is the guy behind extensions, but I will keep looking :)
there is also this weird Fatal error: Cannot read property 'name' of undefined at the end of the tests
it's funny because on the browser there is no class being added