Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Dennis Baldwin
@dbaldwin
Then try to change the interval to 1. It will force it to 2. I had forgotten all about that.
What do you mean by this "I reset virtual stick in the telemetry to false." Can you point me to some code in GitHub?
Kilian Eisenegger
@hdrpano
I did not upload it. But I checked that in the DJI pano example. If we set virtual stick to true we have the set it for false at the end of the pano. I do that in the telemetry. I will push the code.
In this mode we can see the comment. TelemetryViewController didGenerateNewMediaFile. I cannot see that in the single shot mode in the Debugger.
TelemetryViewController didGenerateNewMediaFile
TelemetryViewController didGenerateNewMediaFile
Mission control event Optional(C.DJIMissionControlTimelineEvent)
Finished
Mission control event Optional(
C.DJIMissionControlTimelineEvent)
Started
Mission control event Optional(C.DJIMissionControlTimelineEvent)
Finished
Mission control event Optional(
C.DJIMissionControlTimelineEvent)
Started
Kilian Eisenegger
@hdrpano
Mission control event Optional(__C.DJIMissionControlTimelineEvent)
Finished
2018-01-17 22:01:32.977296+0100 DronePan-Swift[860:242386] Warning: Attempt to present <UIAlertController: 0x137268a00> on <DronePan_Swift.CameraViewController: 0x13790b0d0> which is already presenting <UIAlertController: 0x139004c00>
That's a timeline Error
Kilian Eisenegger
@hdrpano
I timeline mode we don't need virtual stick. It works without. The message on the screen is Joystick when we yaw, but GPS with pitch. I have commented out the virtual stick on my latest test. But if we need it we have to set it on false at the end of the panorama.
Dennis Baldwin
@dbaldwin
@hdrpano let's test across multiple platforms. DJI engineers specifically stated we need to enable virtual stick for yaw actions: https://github.com/dji-sdk/Mobile-SDK-iOS/issues/104#issuecomment-305308946
From DJI.... "Upon further testing, I found that the yaw action needs virtual stick mode to be enabled in order to work. As a temporary workaround while we fix this, please try enabling the virtual stick mode (it is this key: DJIFlightControllerParamVirtualStickControlModeEnabled of type DJIFlightControllerKey) and then start the timeline."
Maybe they've fixed it.
Kilian Eisenegger
@hdrpano
The version online is with virtual stick. But I tested it without. Doesn’t change for me. But we need to set in on false at the end of the pano. They do that in their code too. Its in the telemetry I have added vs on false to gain control if the drone.
Kilian Eisenegger
@hdrpano
I will send you the object c code how they enable it. Maybe we do it wrong.
Kilian Eisenegger
@hdrpano
@dbaldwin I sent you some interesting timeline swift code per mail. Maybe you know it
Dennis Baldwin
@dbaldwin
@hdrpano btw this is how we got around it in the past: https://github.com/dbaldwin/DronePan-Swift/blob/master/DronePan-Swift/PanoramaController.swift#L134-L138 but if you recall for some reason in certain cases the drone would descend as though it were landing. But any sort of waypoint action at the end of the mission will force the drone back into GPS mode.
Kilian Eisenegger
@hdrpano
@dbaldwin yes I haven’t any problem to have control of my drones in the latest releases.
Kilian Eisenegger
@hdrpano
@dbaldwin I have changed the mission end handling. I control missing photos and end the virtual stick mode. I do that in the event listener. I force virtual stick at start and end it on stop or mission finished. That‘s more secure and proper. I will do some tests and upload the new code.
Kilian Eisenegger
@hdrpano
@dbaldwin I start to modify a lot in the code, sorry for that. I hope you understand quickly what I have changed. The virtual stick mode improves a lot. I used a old wrong method in the first beta.
Dennis Baldwin
@dbaldwin
@hdrpano yes I've been reviewing code and will test tomorrow.
Kilian Eisenegger
@hdrpano
@dbaldwin The actual build is clean. Ready for beta. In will work tomorrow on the lens key. That’s key for me. In the next release I will put in lens calculations. That means I will change the user interface.
Kilian Eisenegger
@hdrpano
what means C
Dennis Baldwin
@dbaldwin
I'm pretty sure it means "changed"... that the file from the repo is different than your local branch.
Can you tell me if I can merge the latest CameraViewController that you sent in your last email with the three files?
I will fix that. You can discard your changes for that one file and then commit the other two.
I will walk you through the process, but I need to know if CVC is the latest.
Kilian Eisenegger
@hdrpano
I will send you the files
Dennis Baldwin
@dbaldwin
Just send me CameraViewController. I have not touched any other files. So you will be able to commit those with nno problems.
Kilian Eisenegger
@hdrpano
Bildschirmfoto 2018-01-24 um 22.13.06.png
Now it tell me to download 4 files. I will wait. I am not sure if they are correct.
Dennis Baldwin
@dbaldwin
No, what that is telling you is there are 4 commits ahead of yours. Go here: https://github.com/dbaldwin/DronePan-Pro-iOS/commits/kilian-spherical-logic
you'll see there are 4 commits since your last commit.
Kilian Eisenegger
@hdrpano
Can I commit now? I have only <M> no more <C>
Dennis Baldwin
@dbaldwin
Sure. give it a try.
M just means the file is "modified"
You have changes that need to go to the main repo
Kilian Eisenegger
@hdrpano
please do nothing. I fixed some lines. I will retest all tomorrow. I am on some tricky stuff
Dennis Baldwin
@dbaldwin
okay
Kilian Eisenegger
@hdrpano
@dbaldwin Dennis I do some tests tonight to validate finally the actual build without any menu modification to go for a beta. Next week I will modify too much I guess.
Dennis Baldwin
@dbaldwin
@hdrpano :+1: :+1: :+1:
Kilian Eisenegger
@hdrpano
I am testing P4P I have added a lot of things. Camera detection and optimized row and columns for each drone. Connection is modified to Arnouds code. Menus are hidden if not used. I am making a video.
Dennis Baldwin
@dbaldwin
Sounds good. Let me know if you'd like me to test anything. I will be traveling this weekend but I can do some limited testing.
Kilian Eisenegger
@hdrpano
@dbaldwin I am on the M200 the Mavic... I like my build :-) Works smooth
Kilian Eisenegger
@hdrpano
@dbaldwin I will make some small adjustments tomorrow morning and I will automize rows and columns without going to settings for each drone. Then we could launch a beta. Next week I will implement my framework. That means a lot of new code. I would like to make some small changements to DroneCeption too if you like.
rlesac
@rlesac
Hi folks!
Any new on the Android front?
I have the beta app, but it never managed to start up. After "connecting.." it displays "no product connected" and crashes.
rlesac
@rlesac
Anyway, I got ahold of an iPhone. Can you add me to the beta for the Dronepan iOS?
nikola mihail
@Nikola_Mihail_twitter
I have problem with Dji phantom 3 SE runing on android After 3rd photo it stops and hoovers
dligocki
@dligocki
Hello! I have a P4P v2.0 with an iPad. The application starts up and allows me to control the drone however when I start the pano process it tries to take a photo then appears to time out and presents a message that says 'Missing Photo! The mission will be stopped!'. If you do not have support for P4P v2 yet I would be willing to beta test to help work out bugs on this platform.
Kilian Eisenegger
@hdrpano
This problem is solved with SDK 4.7 build. Plus... use .300 FW instead .600