These are chat archives for dcsan/gitterbot

6th
Sep 2015
dc
@dcsan
Sep 06 2015 08:17
@SaintPeter i'd like to but there were a bunch of other changes. could you help with QA if we do release it?
@abhisekp any chance you can change your linter to read the .eslint in the project? those newlines on else are kind of ugly...
Abhisek Pattnaik
@abhisekp
Sep 06 2015 08:18
@dcsan i just removed some spaced and added some. That's not a big deal
dc
@dcsan
Sep 06 2015 08:19
        return oneMessage;
             }                     }
-        } else {        +        }
+        else {
             return null;                     return null;
         }                 }
we should be using MVVM anyway now :)
Abhisek Pattnaik
@abhisekp
Sep 06 2015 08:21
@dcsan yay! :)
what are all these changes?
there's 20~30 modifications there i need to review
  • regex: /\btroll\b/i,
CamperBot
@camperbot
Sep 06 2015 08:22
:trollface: troll problems? notify admins here
dc
@dcsan
Sep 06 2015 08:22
is that the only thin that actually matters?
Abhisek Pattnaik
@abhisekp
Sep 06 2015 08:23
@dcsan they're nothing. Just spacings.
YES. That's the only thing that matters
dc
@dcsan
Sep 06 2015 08:23
if you can send a PR with just the actual change?
Abhisek Pattnaik
@abhisekp
Sep 06 2015 08:23
@dcsan I will but the eslint doesn't say about the formatting, btw
dc
@dcsan
Sep 06 2015 08:25
btw wha about adding google analytics or something actually interesting?
Abhisek Pattnaik
@abhisekp
Sep 06 2015 08:25
that might take some time from my end. :worried:
dc
@dcsan
Sep 06 2015 08:26
right. but deploying any change takes a minimum of time for me too
so if its not a meaningful change i dont want to spend the time
Abhisek Pattnaik
@abhisekp
Sep 06 2015 08:26
the troll regex was annoying in the chat room when angular is discussed
CamperBot
@camperbot
Sep 06 2015 08:26
:trollface: troll problems? notify admins here
dc
@dcsan
Sep 06 2015 08:26
adding GA tracking isn't a huge deal
there are other issues too
but GA tracking seems like a really simple thing about the same level as tweaking regexes
but actually useful
Abhisek Pattnaik
@abhisekp
Sep 06 2015 08:29
@dcsan k. But could you gimme a head start about how to approach it?
dc
@dcsan
Sep 06 2015 08:29
maybe those angular users can learn how to tweak a regex.
maybe i f we call it "dependency injected two way data binding compliant fizzbuzz" they would.
dcsan/gitterbot#169
Abhisek Pattnaik
@abhisekp
Sep 06 2015 08:31
@dcsan apart from the node pkg, any other guide?
its basically just one function call
i mean, this is really at the simple end of the outstanding issues
Abhisek Pattnaik
@abhisekp
Sep 06 2015 08:33
@dcsan alright.thanks
CamperBot
@camperbot
Sep 06 2015 08:33
abhisekp sends brownie points to @dcsan :sparkles: :thumbsup: :sparkles:
:star: 103 | @dcsan | http://www.freecodecamp.com/dcsan
Rex Schrader
@SaintPeter
Sep 06 2015 17:37
botstatus
CamperBot
@camperbot
Sep 06 2015 17:37
All bot systems are go!
botVersion: 0.0.11
env: prod
botname: camperbot