by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 02 07:27
    decebals commented #545
  • Jun 01 15:04
    mhagnumdw commented #545
  • Jun 01 08:24

    decebals on master

    Add version 1.13.1 in changelog (compare)

  • Jun 01 08:18
    decebals closed #545
  • Jun 01 08:18
    decebals commented #545
  • Jun 01 07:32

    decebals on master

    [maven-release-plugin] prepare … (compare)

  • Jun 01 07:32

    decebals on release-1.13.1

    (compare)

  • Jun 01 07:32

    decebals on master

    [maven-release-plugin] prepare … (compare)

  • Jun 01 07:08

    decebals on master

    Revert "Closing the writer will… (compare)

  • May 31 15:02
    mhagnumdw commented #545
  • May 31 09:10
    decebals commented #545
  • May 31 09:06
    decebals commented #545
  • May 31 08:54
    decebals commented #545
  • May 31 08:51
    decebals opened #545
  • May 31 08:42
    decebals commented #537
  • May 29 17:52

    decebals on master

    Use public key when release a n… (compare)

  • May 29 17:50

    decebals on master

    Add version 1.13.0 in changelog (compare)

  • May 29 17:16

    decebals on master

    [maven-release-plugin] prepare … (compare)

  • May 29 17:16

    decebals on release-1.13.0

    (compare)

  • May 29 17:16

    decebals on master

    [maven-release-plugin] prepare … (compare)

Decebal Suiu
@decebals
The last commit was 13 days ago (now I am in vacation)
Adam Brown
@Wavesonics
@decebals Oh sweet, I got the skeleton of my project setup today and it's working wonderfully
Going much more smoothly than using sorr
Spark
It's a really nice library you have here
I created a very small library for using Koin instead of Weld for DI and adding controllers
Decebal Suiu
@decebals
@Wavesonics I am glad that you find Pippo useful :)
If you encounter any problem please let me know and I will help you
Also please share with us (Pippo's community) your interesting things you created
Related to status of project please take a look on https://groups.google.com/forum/#!topic/pippo-java/WEOcOaLw6aU
Have fun with Pippo!
Adam Brown
@Wavesonics
hey I was wondering something, why can't controllers accept FileItem as arguments using @param ? Looks like you have to just get it off the request.
Adam Brown
@Wavesonics
not an issue, just purely from a user of the API standpoint it seems oddly inconsistent
Decebal Suiu
@decebals
A FileItem is not extracted from request's paramaters
The FileItemExtractor is here
And the method from request that returns a file is here
Decebal Suiu
@decebals
In the end is trivial for us to adopt the construction upload(@Param FileItem file)
Adam Brown
@Wavesonics
ah that makes sense, I synced the pipo repro and as soon as i get a chance will clean up some PRs for you to review
Adam Brown
@Wavesonics
I was taking a look at replacing the current SASS compiler in Pippo with JSASS this weekend. The current SASS compiler doesn't look maintained, and beyond the file loading issues I was having, there are SASS bugs that have been logged for years and gone unfixed.
So I got pretty far in implementing JSASS, which under the hood uses the main line SASS compiler, so should stay patched and up to date
One thing I ran into though that I was wondering if Pippo has some inner machinery I could leverage for is:
In JSASS wants relative paths most of the time, and in their demo, they use the Servlet context to get an absolute path to the resources directory, then they "relativize" their individual resource paths using that
I was wondering if Pippo has something similar, a way to get a path to the root resources directory
Decebal Suiu
@decebals
Yes we have
Take a look at Request and Router
In Request you have getContextPath, getApplicationPath, getPath
In Router you have getContextPath, uriFor, getApplicationPath
Decebal Suiu
@decebals
Also, take a look at current SassResourceHandler
Adam Brown
@Wavesonics
Great thanks
Kiru
@kiru
Is there a way to provide own settings? ( e.g. not to put settings in application.properties but use a custom class which loads the settings for example from a database)
Kiru
@kiru
Another question: The default extension for Freemarker template is "ftl", but I think it should be "ftlh"; Because the default configuration for Freemarker enables html-escaping for "ftlh" ( https://freemarker.apache.org/docs/dgui_quickstart_template.html#dgui_quickstart_template_autoescaping ). What do you think?
Decebal Suiu
@decebals

Is there a way to provide own settings? ( e.g. not to put settings in application.properties but use a custom class which loads the settings for example from a database)

No. You can create an issue to see if we can find a solution.

Decebal Suiu
@decebals

Another question: The default extension for Freemarker template is "ftl", but I think it should be "ftlh"; Because the default configuration for Freemarker enables html-escaping for "ftlh" ( https://freemarker.apache.org/docs/dgui_quickstart_template.html#dgui_quickstart_template_autoescaping ). What do you think?

I use Pebble in my projects. If you use Freemarker in your projects, please create a PR with this modification (eventually update freemarker version if you think that is valuable). You can switch very easy the extension for the Freemarker templates in your project if you want (TemplateEngine.setFileExtension).

Decebal Suiu
@decebals
The fast mode to change templates' extension is via template.extension settings (application.properties)
Kiru
@kiru
@decebals Thank you, I'll do that

Another question: The default extension for Freemarker template is "ftl", but I think it should be "ftlh"; Because the default configuration for Freemarker enables html-escaping for "ftlh" ( https://freemarker.apache.org/docs/dgui_quickstart_template.html#dgui_quickstart_template_autoescaping ). What do you think?

I use Pebble in my projects. If you use Freemarker in your projects, please create a PR with this modification (eventually update freemarker version if you think that is valuable). You can switch very easy the extension for the Freemarker templates in your project if you want (TemplateEngine.setFileExtension).

This is what I did now, but I was thinking it might be a better solution to enable auto-escaping by default.

Kiru
@kiru

On the filters: (http://www.pippo.ro/doc/filters.html)

Note: If you want to add a filter for all routes you MUST use /. and NOT /:
Can you explain when "/*" does make sense?

I spent some time to figure out that my CSRFHandler didn't work because I used / and not /.
"/*" and not "/.*"
Marwan Rabbâa
@waghanza
Hi,
I want to introduce pippo in the-benchmarker/web-frameworks#1373 (a benchmarking project)
anyone wants to give a try ?
Decebal Suiu
@decebals
Pippo was not created with speed in mind. Speed is more than decent. There are other features that recommend this micro web framework.
Marwan Rabbâa
@waghanza
In deed @decebals. We are actually targeting performance as the first indicator, but there will be other (resource consumption, build time ...). Do you consent that I add pippo on this list ?
Decebal Suiu
@decebals
Do you consent that I add pippo on this list ?
Yes. No problem.
Marwan Rabbâa
@waghanza
:heart:
Decebal Suiu
@decebals
You're welcome :smile:
mhagnumdw
@mhagnumdw
Hi @decebals !
My first time around here :) Do you know why the status of Travis builds no longer appears in the MR or commits checks? If you have a direction I can try to see.
Decebal Suiu
@decebals
Hello. What you see about a new release? Do you want to add other issues to be available in the coming release?
Decebal Suiu
@decebals
Version 1.13.0 is available