Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 13:05
    dennisdoomen synchronize #1603
  • 10:00
    FabianNitsche opened #1615
  • 08:42
    dennisdoomen synchronize #1603
  • Jun 19 17:55
    dennisdoomen synchronize #1603
  • Jun 18 14:17
    FabianNitsche commented #1613
  • Jun 18 14:16
    dennisdoomen commented #1613
  • Jun 18 13:58
    FabianNitsche commented #1613
  • Jun 18 13:41
    dennisdoomen commented #1613
  • Jun 18 13:04
    dennisdoomen review_requested #1614
  • Jun 18 13:04
    dennisdoomen opened #1614
  • Jun 18 08:21
    FabianNitsche opened #1613
  • Jun 18 02:16
    mdentremont commented #1435
  • Jun 17 23:08
    mdentremont commented #1435
  • Jun 17 19:19
    dennisdoomen commented #1353
  • Jun 17 19:03
    xadvfh commented #1411
  • Jun 17 13:58
    dennisdoomen closed #1274
  • Jun 17 13:58
    dennisdoomen commented #1274
  • Jun 17 13:13
    dennisdoomen commented #1612
  • Jun 17 13:13
    dennisdoomen labeled #1612
  • Jun 17 13:05
    AdamBarnettUK commented #1612
Dennis Doomen
@dennisdoomen
@adamrodger You can't. It is something that is used within the assertion classes
Stuart Blackler
@Im5tu
I've got a bit of free time coming up, thought i'd start to contribute some stuff back. Anything that you want taking a look at as a higher priority?
Dennis Doomen
@dennisdoomen
@Im5tu That would be awesome. There's a lot of stuff up for grabs. I'm still reorganizing the develop branch for v5, but I'll just forward port anything that lands on master
Stuart Blackler
@Im5tu
Do you need a hand with the reorg?
Dennis Doomen
@dennisdoomen
Sure. I'm trying to get my PR to compile properly. Have to go through all the #ifdefs and stuff to make it work. But I've overcommitted a bit too much. See fluentassertions/fluentassertions#558
This is the biggest hurdle before the remainder of the v5 work can commence (see also fluentassertions/fluentassertions#463)
Stuart Blackler
@Im5tu
I'll pull your fork later on and see what I can do :)
Dennis Doomen
@dennisdoomen
:+1:
Stuart Blackler
@Im5tu
I've managed to drop 20 of the error messages. Last ones are quite minor and can be fixed by using the newer type API inside the TypeExtensions.cs class. If you're happy, i'll switch that stuff over tonight and PR back to you :)
Assuming there is no more errors once i've fixed the remaining 13 errors
Dennis Doomen
@dennisdoomen
Man, that would be awesome.
@SaroTasciyan would be happy as well, since he was eagier to help with the remainder of the v5 work
Stuart Blackler
@Im5tu
No worries - i'll get it done so at least the main project is building tonight :)
Dennis Doomen
@dennisdoomen
:+1:
Saro Taşciyan
@SaroTasciyan
:+1: Nice work
Stuart Blackler
@Im5tu
Happy if I pipe the Type calls through to TypeInfo eg:
blob
Dennis Doomen
@dennisdoomen
Sure
Dennis Doomen
@dennisdoomen
That is the NetStandard way
Stuart Blackler
@Im5tu
Here is what i've got it down too:
blob
I'm not sure about the AppDomain stuff. So i'll add a comment and highlight it in the PR for you. The one i'll be stuck on is the top one about GetReferencedAssemblies. But i'll dig now :)
Stuart Blackler
@Im5tu
Main project is now building. Update here: dennisdoomen/fluentassertions#2
Dennis Doomen
@dennisdoomen
If NetStandard doesn't support Assembly, then we can just wrap it in #ifdef NET45
Dennis Doomen
@dennisdoomen
The test framework provider stuff is a bit tricky. It tries to detect which test framework (XUnit, MBUnit, etc) is being used by scanning the assemblies in the AppDomain. Apparently AppDomain is no longer available in NetStandard, so maybe the workaround mentioned here works as well http://www.michael-whelan.net/replacing-appdomain-in-dotnet-core/
The ProbingAdapterResolver is no longer needed. It was used to find by the PCL to find the platform-specific implementation of FA (e.g. NET 4.5, Silverlight, etc)
Dennis Doomen
@dennisdoomen

If NetStandard doesn't support Assembly, then we can just wrap it in #ifdef NET45

Scratch that. NetStandard does support Assembly. But getting the dependencies has to happen through DependencyContext.Default.CompileLibraries
and DependencyContext.Default.RuntimeLibraries. See https://stackoverflow.com/questions/30007264/get-available-types-in-coreclr

Stuart Blackler
@Im5tu
Cool - will alter the PR later :)
Stuart Blackler
@Im5tu
Not given up btw, just adjusting some free time :D
So I removed the unnecessary file, and got to the point of putting in the dependency context, but couldn't seem to find DependencyContext.Default so think i've done something wrong. That's where I am at
Stuart Blackler
@Im5tu
blob
That's what I am getting, any ideas greatly appreciated
Dennis Doomen
@dennisdoomen
Is it possible that it requires a higher version of NetStandard?
Stuart Blackler
@Im5tu
nuget.org says net standard 1.3
(and 1.6 & net451)
Dennis Doomen
@dennisdoomen
According to nuget. org, that 1.1.2 has some weird dependencies on some preview stuff. Try 1.1.1.
Raghav S
@raghav710
I would like to know on how to get a setup ready for the fluentassertions repo. I cloned the master branch and when I run psake.cmd or psake.ps1 I get
Exception: Exec: Er
ror executing command msbuild /v:m /p:Platform="Any CPU" $SlnFile /p:Configurat
ion=Release /p:SourceAnalysisTreatErrorsAsWarnings=false /t:Rebuild $logger.
I am a newbie to this repo, so please excuse any questions that seem obvious
Dennis Doomen
@ddoomen_twitter
The master branch needs Visual Studio 2015. The develop branch is WIP and requires Visual Studio 2017.
@Im5tu anything I can continue with? I'll probably have a bit more time the coming weeks.
Raghav S
@raghav710
@ddoomen_twitter I have VS 2015 and am on the master branch. Is running the VS build enough or do I need to run ./psake too?
Raghav S
@raghav710
hi, I am working on an implementation for fluentassertions/fluentassertions#557 and I am stuck at a point
Raghav S
@raghav710
In the GenericDictionaryEquivalencyStep class I want to check if one dictionary contains the other's keys. But since the key types are different (TExpectKey, TSubjectKey) I am not able to do a 2-way comparison i.e. I can do the .Contains() check one way by saying TSubjectKey:TExpectKey but then I wouldnt be able to do the comparison the other way
can someone give me some pointers to move forward?
Raghav S
@raghav710
@dennisdoomen any comments?
Dennis Doomen
@dennisdoomen
Sorry, missed your question. Eventually the comparison will use the TSubjectKey to compare the items in the dictionary, so that's the only thing you can make assumptions on.
Raghav S
@raghav710
@dennisdoomen thanks :smile:
Dennis Doomen
@dennisdoomen
If anybody wants to help with v5.0, the ground work to support .NET 4.5.1, .NET Standard 1.4 and .NET Standard 1.6 using a single cross-compiled project has been completed. See https://github.com/fluentassertions/fluentassertions/milestone/10 for the work that still needs to be done.
Dennis Doomen
@dennisdoomen
@/all this Gitter channel is going to be closed. Please join the official Slack channel at https://fluentassertions.slack.com