Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 18:35
    Ergamon commented #1628
  • 12:32
    dennisdoomen commented #1628
  • 10:23
    Ergamon opened #1628
  • 10:16
    Ergamon closed #1626
  • 10:16
    Ergamon commented #1626
  • Jul 23 19:31
    dennisdoomen assigned #1562
  • Jul 23 19:31
    dennisdoomen closed #1627
  • Jul 23 19:31

    dennisdoomen on release-6.0

    Fixed a regression where a nest… (compare)

  • Jul 23 19:31
    dennisdoomen closed #1604
  • Jul 23 19:02
    dennisdoomen synchronize #1627
  • Jul 23 18:58
    dennisdoomen edited #1627
  • Jul 23 18:56
    dennisdoomen synchronize #1627
  • Jul 23 18:55
    dennisdoomen opened #1627
  • Jul 23 17:59
    dennisdoomen unassigned #1562
  • Jul 23 17:59
    dennisdoomen assigned #1604
  • Jul 23 11:19
    dennisdoomen commented #1626
  • Jul 23 10:22
    Ergamon commented #1626
  • Jul 23 06:37
    dennisdoomen labeled #1626
  • Jul 23 06:37
    dennisdoomen commented #1626
  • Jul 22 21:55
    Ergamon opened #1626
Stuart Blackler
@Im5tu
Happy if I pipe the Type calls through to TypeInfo eg:
blob
Dennis Doomen
@dennisdoomen
Sure
Dennis Doomen
@dennisdoomen
That is the NetStandard way
Stuart Blackler
@Im5tu
Here is what i've got it down too:
blob
I'm not sure about the AppDomain stuff. So i'll add a comment and highlight it in the PR for you. The one i'll be stuck on is the top one about GetReferencedAssemblies. But i'll dig now :)
Stuart Blackler
@Im5tu
Main project is now building. Update here: dennisdoomen/fluentassertions#2
Dennis Doomen
@dennisdoomen
If NetStandard doesn't support Assembly, then we can just wrap it in #ifdef NET45
Dennis Doomen
@dennisdoomen
The test framework provider stuff is a bit tricky. It tries to detect which test framework (XUnit, MBUnit, etc) is being used by scanning the assemblies in the AppDomain. Apparently AppDomain is no longer available in NetStandard, so maybe the workaround mentioned here works as well http://www.michael-whelan.net/replacing-appdomain-in-dotnet-core/
The ProbingAdapterResolver is no longer needed. It was used to find by the PCL to find the platform-specific implementation of FA (e.g. NET 4.5, Silverlight, etc)
Dennis Doomen
@dennisdoomen

If NetStandard doesn't support Assembly, then we can just wrap it in #ifdef NET45

Scratch that. NetStandard does support Assembly. But getting the dependencies has to happen through DependencyContext.Default.CompileLibraries
and DependencyContext.Default.RuntimeLibraries. See https://stackoverflow.com/questions/30007264/get-available-types-in-coreclr

Stuart Blackler
@Im5tu
Cool - will alter the PR later :)
Stuart Blackler
@Im5tu
Not given up btw, just adjusting some free time :D
So I removed the unnecessary file, and got to the point of putting in the dependency context, but couldn't seem to find DependencyContext.Default so think i've done something wrong. That's where I am at
Stuart Blackler
@Im5tu
blob
That's what I am getting, any ideas greatly appreciated
Dennis Doomen
@dennisdoomen
Is it possible that it requires a higher version of NetStandard?
Stuart Blackler
@Im5tu
nuget.org says net standard 1.3
(and 1.6 & net451)
Dennis Doomen
@dennisdoomen
According to nuget. org, that 1.1.2 has some weird dependencies on some preview stuff. Try 1.1.1.
Raghav S
@raghav710
I would like to know on how to get a setup ready for the fluentassertions repo. I cloned the master branch and when I run psake.cmd or psake.ps1 I get
Exception: Exec: Er
ror executing command msbuild /v:m /p:Platform="Any CPU" $SlnFile /p:Configurat
ion=Release /p:SourceAnalysisTreatErrorsAsWarnings=false /t:Rebuild $logger.
I am a newbie to this repo, so please excuse any questions that seem obvious
Dennis Doomen
@ddoomen_twitter
The master branch needs Visual Studio 2015. The develop branch is WIP and requires Visual Studio 2017.
@Im5tu anything I can continue with? I'll probably have a bit more time the coming weeks.
Raghav S
@raghav710
@ddoomen_twitter I have VS 2015 and am on the master branch. Is running the VS build enough or do I need to run ./psake too?
Raghav S
@raghav710
hi, I am working on an implementation for fluentassertions/fluentassertions#557 and I am stuck at a point
Raghav S
@raghav710
In the GenericDictionaryEquivalencyStep class I want to check if one dictionary contains the other's keys. But since the key types are different (TExpectKey, TSubjectKey) I am not able to do a 2-way comparison i.e. I can do the .Contains() check one way by saying TSubjectKey:TExpectKey but then I wouldnt be able to do the comparison the other way
can someone give me some pointers to move forward?
Raghav S
@raghav710
@dennisdoomen any comments?
Dennis Doomen
@dennisdoomen
Sorry, missed your question. Eventually the comparison will use the TSubjectKey to compare the items in the dictionary, so that's the only thing you can make assumptions on.
Raghav S
@raghav710
@dennisdoomen thanks :smile:
Dennis Doomen
@dennisdoomen
If anybody wants to help with v5.0, the ground work to support .NET 4.5.1, .NET Standard 1.4 and .NET Standard 1.6 using a single cross-compiled project has been completed. See https://github.com/fluentassertions/fluentassertions/milestone/10 for the work that still needs to be done.
Dennis Doomen
@dennisdoomen
@/all this Gitter channel is going to be closed. Please join the official Slack channel at https://fluentassertions.slack.com