These are chat archives for deployd/contributors

12th
Jan 2015
Eric Fong
@ericfong
Jan 12 2015 08:56
Sorry, over the weekend, I am too busy. Will catch up and rebase this two days
Nicolas Ritouet
@NicolasRitouet
Jan 12 2015 10:05
hey @ericfong , no need to be sorry, we're not a company, we're benevolent and it's already awesome what you're doing for the project !
Andrei Alecu
@andreialecu
Jan 12 2015 13:19
@ericfong did you get that memory leak sorted?
Eric Fong
@ericfong
Jan 12 2015 13:54
One month: 1 - 2 times restart. acceptable for me for my stage
Andrei Alecu
@andreialecu
Jan 12 2015 14:26
I was talking about that fix I made
which was just committed
did you see memory leaks after it? is memory usage still increasing?
Eric Fong
@ericfong
Jan 12 2015 15:46
I put that into my staging machine, which is still running (~500MB now).
Andrei Alecu
@andreialecu
Jan 12 2015 15:46
that sounds like a lot
it shouldn't increase too much from a base value
Eric Fong
@ericfong
Jan 12 2015 15:48
Thanks @andreialecu for your PR. Let's try to follow the subject format in: https://github.com/deployd/deployd/blob/master/CONTRIBUTING.md#type
https://github.com/deployd/deployd/blob/master/CONTRIBUTING.md#subject
which don't capitalize first letter
May be my problem have some internal problems. try to study that later
Andrei Alecu
@andreialecu
Jan 12 2015 16:02
deployd/deployd#484 I updated the code here
didn't like checking for function name, I check if a promise is returned now
Andrei Alecu
@andreialecu
Jan 12 2015 16:39
@ericfong are you running your code with env=production?
Eric Fong
@ericfong
Jan 12 2015 16:39
YES
Andrei Alecu
@andreialecu
Jan 12 2015 16:40
ok, because that memory leak thing fix I did doesn't apply for development, it would still leak
https://github.com/deployd/deployd/blob/master/lib/config-loader.js#L36 not sure why it wouldn't want to cache for development
Eric Fong
@ericfong
Jan 12 2015 16:41
may be other reasons. Thanks
Andrei Alecu
@andreialecu
Jan 12 2015 16:41
I think the reason is so that you can edit event scripts in a text editor instead of the dashboard without restarting the node process every time
though that would be better done by watching the files for changes via fs.watch
Andrei Alecu
@andreialecu
Jan 12 2015 17:14
deployd/deployd#384 this can be closed probably