These are chat archives for deployd/contributors

21st
Jan 2015
Nicolas Ritouet
@NicolasRitouet
Jan 21 2015 08:54
hey guys
what’s your point of view for the 0.8 version? Which PR should be merged before releasing?
Nicolas Ritouet
@NicolasRitouet
Jan 21 2015 14:50
@/all
Eric Fong
@ericfong
Jan 21 2015 15:02
One more bug fix for script.js deployd/deployd#493
:smile:
Andrei Alecu
@andreialecu
Jan 21 2015 16:03
that's not good @ericfong
I doubt tests will pass once you do that, at least not the promise PR I made
and add then finish right one after the other doesn't really make much sense really :)
might as well just remove finishcallback it's the same thing :)
for sure however that the promise stuff will be broken by this, it expects that callback to actually call the finishcallback event
they'll be out of sync otherwise
Eric Fong
@ericfong
Jan 21 2015 16:06
Mmm, this PR seems stupid to me too. Just found the bug.
And not sure why originally need the finishcallback.
Andrei Alecu
@andreialecu
Jan 21 2015 16:07
to inject as the last parameter of a domain function
it's a callback function
I don't see if it was actually ever used, I only started using it for promises
that code path
Eric Fong
@ericfong
Jan 21 2015 16:08
If the promise PR can consider the call_a_async_func_without_callback_and_promise will be great. And I can close my PR
I will call dpd.email.post({DATA}) without waiting for the email done.
Andrei Alecu
@andreialecu
Jan 21 2015 16:09
if you merge my promise PR
that will work
already
I already handled that stuff there
Eric Fong
@ericfong
Jan 21 2015 16:12
Yes. Shall we consider Promise PR as a fix instead of feature and launch that with 0.8?
Then my PR is duplicated (The unit test can be kept)