These are chat archives for deployd/contributors

23rd
Jan 2015
Eric Fong
@ericfong
Jan 23 2015 02:45
@NicolasRitouet Please assign me some PRs to rebase. Not sure which one you are working on.
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 08:06
@/all I’ve been thinking about the PR with the promises
Actually, it would be better to add it to the 0.8 release
since it’s a big change
if we wait, it might take too long to have it
Hey there! I hope it's okay for me to join with my personal account instead of the simpleTechs account? This way I can at least somehow keep our shared inbox clean :)
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 14:53
no problem :)
are you Fabian?
Yepp
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 14:54
ok
I started to write you an email yesterday, before you sent us your PR
about Deployd in general
and then, I received your PR
hehe, what would you like to know?
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 14:55
well, I wanted to let you know about the changes Deployd is facing
that we have a new team
and I also wanted to get your feedback regarding the priorities
what you think is necessary, what should be fixed, what should be implemented, etc...
oh, okay, well otoh I think it's most important to make getting started easy. It is now, but sometimes the docs can be a bit scary for beginners and that may scare off people.
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 14:57
yeah, we need to work on the docs, definitively
Apart from that, well, for me most of the things we really need are either already done in core or we were able to add them with little to no work as an extension
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 14:59
cool
Please give me a minute, I'd like to show you sth
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 14:59
sure
Andrei Alecu
@andreialecu
Jan 23 2015 15:02
oh hey @0ff
:) Hey there!
Andrei Alecu
@andreialecu
Jan 23 2015 15:04
nice PR again, I was thinking about improving mine later to do what yours did, especially since bluebird has a .promisify() method so you could auto promisify async functions in the domain automatically
did mine quickly that way and said I'll improve it later on, but yours is better already :)
Phew. This nifty heroku cache wouldn't rebuild my version of deployd. Sorry it took me so incredibly long, but now it's done :) https://deployd-playground.herokuapp.com/dashboard - login with "playground" as your key
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 15:27
ok, I’m in
That's what I was working on lately, i.e. the CodeResource - what do you think?
I found that we would often write some event handlers and then fiddly test them with curl or anything, where just running them inside of deployd was what we would actually need
This is useful for all kinds of stuff, even migration via code
On heroic it won't persists the code-files you create after rebooting, but on a standard server this could serve as toolbelt for running snippets quickly
On heroku...
@andreialecu Thanks for the flowers :) I didn't realize Q was used, but I figured ayepromise is used in the js-client, so maybe it's nice to be consistent here. There are better options, of course.
Anyways, I'm totally up for discussion on that one - after all, the basic function should be the same with each and every one of them (and that's thanks to the spec :))
Andrei Alecu
@andreialecu
Jan 23 2015 15:53
omg!
that coderesource thing is awesome
Thanks! I though you might like it :)
Andrei Alecu
@andreialecu
Jan 23 2015 15:53
dude and that's exactly what I was working on
:))
I'll scrap mine
hehe, best compliment a coder can make another coder I guess? :)
Andrei Alecu
@andreialecu
Jan 23 2015 15:54
well, the dashboard part anyway
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 15:55
@0ff nice !!!!
Andrei Alecu
@andreialecu
Jan 23 2015 15:55
but yours looks better anyway, great job :)
Uh, didn't know about this one, I'll take a look
I actually just took the events.html of the core collections and went with that
Andrei Alecu
@andreialecu
Jan 23 2015 15:55
it's not necessarily the same thing
it's like the event resource but you can define them separately
it's pretty buggy too
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 15:56
@0ff are the source available?
Andrei Alecu
@andreialecu
Jan 23 2015 15:57
how do you call those?
Sure, as always my primiary git will be at bitbucket (https://bitbucket.org/simpletechs/dpd-resource-code), but once a "releasable" (i.e. readme + docs) version is done, we'll publish on github
Andrei Alecu
@andreialecu
Jan 23 2015 15:58
ah
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 15:58
cool
Andrei Alecu
@andreialecu
Jan 23 2015 15:58
so that's just a mini toolbelt? I was thinking about having some global scripts
that you could call from other event scripts
for code reuse
Yeah, we'd use it for things like bulk updates
Andrei Alecu
@andreialecu
Jan 23 2015 15:58
like, to verify authentication or something
oh, I see
For reuse, I love to use require, this seems to be so much cleaner
Andrei Alecu
@andreialecu
Jan 23 2015 15:58
so it's not exactly what I was working on,but it could be easily adapted
yeah, could require('code1') maybe
where code1 is defined in this coderesource
probably with some prefix, but yeah, that could work
Andrei Alecu
@andreialecu
Jan 23 2015 15:59
require is not great actually by the way, in event scripts
because if you call async stuff, it won't pass through the wrapasyncfunctions code
and they won't wait to be executed before returning
yes, unfortunately I know
that why the resource actually includes when in the domain rather than just require'ing it.
I was thinking about looking into it, but right now this wasn't part of my original plan
one minor problem I had was in the fact that deployd would not let manage different events for different instances of a resource. This is due to the internal way of handling events and I don't really mind it, so I just prevented the resource from crashing and added a message for the user. it's really hacky atm, but this way I could keep the events dynamic and reuse most of the code from collections
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 16:21
hey guys
I have to go
was nice to talk to you, thanks to both of you
really happy to have awesome contributors like you
sure, thanks for keeping deployd alive :) Have a nice weekend!
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 16:22
thx, you too :)
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 19:03
hey @0ff
Nicolas Ritouet
@NicolasRitouet
Jan 23 2015 19:13
regarding my proposition to migrate to bluebird, would that be an option?
Andrei Alecu
@andreialecu
Jan 23 2015 19:13
yes
just need to combine my PR with @0ff's
or rather he needs to take more of it, he took a part of it already :)