These are chat archives for deployd/contributors

27th
Jan 2015
Andrei Alecu
@andreialecu
Jan 27 2015 13:59
so @ericfong , you know about your concerns about vm being slow, there apparently is a bug in node
regarding vm stuff: joyent/node#6552
the good news is, I have found a workaround and reworked the script code to not use runInNewContext and it seems to be 20x times faster at least
and without memory leaks
I have a test case here actually that shows a huge memory leak
with the current deployd
but not occuring with my fix
it's actually incredibly fast with my fix, running a script 15000 times uses 1.6 gb of memory and takes over 2 minutes with runInNewContext, but with my changes it runs in 322 ms and uses virtually no memory
Andrei Alecu
@andreialecu
Jan 27 2015 14:14
here you go: deployd/deployd#496
Eric Fong
@ericfong
Jan 27 2015 14:16
WOW!
Nice one
Andrei Alecu
@andreialecu
Jan 27 2015 14:16
check the test there without my fix
Eric Fong
@ericfong
Jan 27 2015 14:20
Try to check that 2 hours later.
Andrei Alecu
@andreialecu
Jan 27 2015 14:20
I think I can improve it further
Nicolas Ritouet
@NicolasRitouet
Jan 27 2015 15:05
@andreialecu awesome PR
I’ll ask the core developer to review this just in case
but really good PR
Andrei Alecu
@andreialecu
Jan 27 2015 16:05
well actually I'll remove the dependency on vm entirely
Andrei Alecu
@andreialecu
Jan 27 2015 16:18
alright, I pushed again, should be a lot cleaner now and doesn't use vm
Andrei Alecu
@andreialecu
Jan 27 2015 19:03
minor consistency fix here: deployd/deployd#497