These are chat archives for deployd/contributors

9th
Feb 2015
Andrei Alecu
@andreialecu
Feb 09 2015 18:51
I found a bug
I'm not sure if it's because of the promise stuff yet, but something is changing nulls to empty obj {}
in event scripts for previous, probably for this too
Nicolas Ritouet
@NicolasRitouet
Feb 09 2015 18:55
Damn :(
Andrei Alecu
@andreialecu
Feb 09 2015 18:56
it's probably really simple
looking into it
Andrei Alecu
@andreialecu
Feb 09 2015 19:12
I fixed it
it doesn't seem to be a new issue, very weird
this is pre promises
if you open dev console and do typeof null is object
so the next line changes it into {}
fix is this: } else if (typeof asyncFunctions[k] === 'object' && !(asyncFunctions[k] instanceof Array) && asyncFunctions[k] !== null) {
trying to come up with a test for it
Andrei Alecu
@andreialecu
Feb 09 2015 19:23
done
sending PR
Nicolas Ritouet
@NicolasRitouet
Feb 09 2015 19:27
Awesome, thanks
Andrei Alecu
@andreialecu
Feb 09 2015 19:33
deployd/deployd#509