These are chat archives for deployd/contributors

24th
Feb 2015
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 09:06
everybody agrees to merge this PR: deployd/deployd#496 ?
Eric Fong
@ericfong
Feb 24 2015 10:24
Yes. waiting for that
Andrei Alecu
@andreialecu
Feb 24 2015 10:43
yes, it seems stable for me, I've been using it for a while
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 10:43
ok
Andrei Alecu
@andreialecu
Feb 24 2015 10:46
https://github.com/deployd/deployd/pull/512/files is this really a thing? I have a lot of booleans in my models in my app and I haven't seen a problem with them
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 10:46
really?
weird
Andrei Alecu
@andreialecu
Feb 24 2015 10:47
I could be wrong
meaning, I may have only set them via the dashboard
instead of via POST
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 10:47
ok
Andrei Alecu
@andreialecu
Feb 24 2015 10:48
actually no, I have an instance where I have a boolean that is properly being saved
just checked
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 10:48
saved with post then?
Andrei Alecu
@andreialecu
Feb 24 2015 10:50
the first if
if(validation.exists(val)) {
will be entered
and that else at the end doesn't seem like it would be executed
what that code seems to do is that if val is undefined, it will enter that else block and set the body[key] to false
which seems correct behavior and not a bug
those tests really fail without the change?
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 11:07
I think so
don’t remember though in details
I’ll take a closer look this evening
Andrei Alecu
@andreialecu
Feb 24 2015 11:11
I just ran your two tests on deployd master
and they passed
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 11:11
ok
Andrei Alecu
@andreialecu
Feb 24 2015 11:11
without the changes you made
something else is wrong
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 11:12
indeed
Eric Fong
@ericfong
Feb 24 2015 14:51
By the way, how you guys do API versioning ? I am thinking put nginx in front of 2 instances of deployd
Andrei Alecu
@andreialecu
Feb 24 2015 15:03
I didn't get there yet personally
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 15:07
me neither with deployd
Andrei Alecu
@andreialecu
Feb 24 2015 15:09
I thought about it though as I was initially looking at deployd and I would've liked to have some configurable endpoints like myapp.com/api/v1/.... or v2, etc
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 15:09
yep, that would be nice indeed
Andrei Alecu
@andreialecu
Feb 24 2015 15:10
but I think that's achievable with what @ericfong mentioned, with nginx
Nicolas Ritouet
@NicolasRitouet
Feb 24 2015 15:12
it is, but adding nginx can be a pain
Eric Fong
@ericfong
Feb 24 2015 15:12
nginx allow deployd run by two diff node instance (deps can be diff version without any problem).
I already have nginx in-front for ssl thing
Andrei Alecu
@andreialecu
Feb 24 2015 16:38
so apparently there's an issue with Safari on both PC and iOS not allowing cookies via CORS, which prevents the sid cookie from being set after a login if your deployd api is on a separate domain from your site (I have my api at myapp-api.heroku and the app at myapp.heroku for now)
this kinda breaks everything
it's only fixable by changing a setting in Safari regarding cookies (allow from all sites, not just from sites I visited)
and I think the workaround is to allow authorization via HTTP header, Authorization: Bearer sidtokenhere
Andrei Alecu
@andreialecu
Feb 24 2015 18:42
PR deployd/deployd#521