These are chat archives for deployd/contributors

20th
Mar 2015
Nicolas Ritouet
@NicolasRitouet
Mar 20 2015 14:47
@andreialecu you are on fire ! :clap:
Eric Fong
@ericfong
Mar 20 2015 17:37
I would like to have a temp solution
Andrei Alecu
@andreialecu
Mar 20 2015 17:54
I think we can merge it like that
but has someone tested it manually?
ensured it works with either the function call and/or the dpd.js script element?
Eric Fong
@ericfong
Mar 20 2015 17:55
Personally, I have done some, but may need to do one for rebasing to the new master
Andrei Alecu
@andreialecu
Mar 20 2015 18:02
it may be tested via sinon
with some mocks maybe
mock io.connect and check if it's called with proper parameters
and the XHR object
I'll take a stab at it
and send you a PR with tests
if I can figure something out
send it to your branch I mean ericfong:urlBase
Eric Fong
@ericfong
Mar 20 2015 18:07
Yes. please. sleep first
Andrei Alecu
@andreialecu
Mar 20 2015 21:49
@ericfong here you go: ericfong/deployd#1