These are chat archives for deployd/contributors

23rd
Mar 2015
Andrei Alecu
@andreialecu
Mar 23 2015 14:17
hey @ericfong, when you have time, can you address the spacing/comments in #490 so we can merge it? thanks!
Eric Fong
@ericfong
Mar 23 2015 16:31
Done

BTW, using atom, any way to make the auto indent work as

var x = 1
  , b = 2

instead of

var x = 1
, b = 2

?

Andrei Alecu
@andreialecu
Mar 23 2015 16:36
no idea, I indent manually
but don't use atom
Andrei Alecu
@andreialecu
Mar 23 2015 16:44
@ericfong I just merged it, ty :)
Eric Fong
@ericfong
Mar 23 2015 16:45
Thx
Andrei Alecu
@andreialecu
Mar 23 2015 23:15
probably high priority merge: deployd/deployd#541 it can be a denial of service just calling login with an existing username but without a password in the body, I verified it crashes the deployd process
if someone can review (simple change really) and merge, or I can merge it myself after someone signs off on it