These are chat archives for deployd/contributors

25th
May 2015
Andrei Alecu
@andreialecu
May 25 2015 13:06
hey guys
Rares Golea
@rgolea
May 25 2015 13:55
hey guys! I would like to start helping with maintaining deployd but I need somewhere to start. any ideas?
I mean, how do you guys work? (git, git flow, PR to master…) where can I find docs on the architecture of deployd? (folders, injection, ctx, etc…) and what would you have me do? I would love to start helping with the docs but for that I need to know where are the docs right now and how to edit them, etc...
Rares Golea
@rgolea
May 25 2015 14:01
sorry… my bad… just found out where are the docs...
I do need the rest of the info
Andrei Alecu
@andreialecu
May 25 2015 14:26
:point_up: May 25 2015 4:06 PM @NicolasRitouet @ericfong
Nicolas Ritouet
@NicolasRitouet
May 25 2015 19:27
@andreialecu I'll take care of this this evening
Andrei Alecu
@andreialecu
May 25 2015 19:28
deployd/deployd#576 this one is more pressing for me, and real simple
Nicolas Ritouet
@NicolasRitouet
May 25 2015 19:29
ok
Andrei Alecu
@andreialecu
May 25 2015 19:29
so I can keep using deployd/deployd instead of my own fork
Nicolas Ritouet
@NicolasRitouet
May 25 2015 19:30
I'm doing it right now
@rgolea you can found some contribution guideline here: https://github.com/deployd/deployd/blob/master/CONTRIBUTING.md
if they are not clear, let me know, we can improve it
Rares Golea
@rgolea
May 25 2015 19:31
thanks!
I have to warn you I’m not a skilled developer… but I’ll do my best. Thank you for the chance
Nicolas Ritouet
@NicolasRitouet
May 25 2015 19:33
it’s ok, you can contribute on lot’s of different stuff
Rares Golea
@rgolea
May 25 2015 19:33
@NicolasRitouet thank you
Nicolas Ritouet
@NicolasRitouet
May 25 2015 19:33
it can be documentation, design (we’d like to redesign the homepage), easy bugs, etc..
Rares Golea
@rgolea
May 25 2015 19:34
the homepage?
Andrei Alecu
@andreialecu
May 25 2015 19:34
yup, documentation is severely lacking
Rares Golea
@rgolea
May 25 2015 19:34
you mean the dashboard?
Andrei Alecu
@andreialecu
May 25 2015 19:34
I think he means deployd.com
Rares Golea
@rgolea
May 25 2015 19:34
I will try my best on the docs but I will be posting a lot of questions
I think I can manage that too
would you like something more foundation, more bootstrap or more material-design?
Andrei Alecu
@andreialecu
May 25 2015 19:35
I think the homepage itself is ok
Nicolas Ritouet
@NicolasRitouet
May 25 2015 19:35
as @andreialecu mentionned, we have lots of issues in the docs repo: https://github.com/deployd/docs/issues
yeah, it’s not the priority, but if somebody is good for designing stuff, I’m open to improvements :)
Rares Golea
@rgolea
May 25 2015 19:37
okay… I will do my best...
Rares Golea
@rgolea
May 25 2015 19:45
have you guys merged the @andreialecu ’s session2 branch to master? https://github.com/andreialecu/deployd/tree/refactor-session2
Nicolas Ritouet
@NicolasRitouet
May 25 2015 19:45
which PR is it?
Rares Golea
@rgolea
May 25 2015 19:46
let me see...
I can’t find it… maybe he didn’t PR yet...
Nicolas Ritouet
@NicolasRitouet
May 25 2015 19:56
@andreialecu why is engine.io needed? is it in addition to socket.io?
Nicolas Ritouet
@NicolasRitouet
May 25 2015 20:41
ok, I get it, engine.io is a dependency of socket.io and you need to specify a specific version of engine.io to make it work
Andrei Alecu
@andreialecu
May 25 2015 20:55
@NicolasRitouet yes, they updated ws in the master
but they didn't bump the version and release to npm
Nicolas Ritouet
@NicolasRitouet
May 25 2015 20:55
ok
I’ll make a new release
0.8.3, no breaking changes, right? (at least, not on documented features)
Andrei Alecu
@andreialecu
May 25 2015 20:57
there is the one about CORS, when you call deployd cross domain over the web with XHR
and you need to specify allowed origins explicitly
instead of allowing all by default (which was a huge security issue)
Nicolas Ritouet
@NicolasRitouet
May 25 2015 20:57
ok
a note in the release should be sufficient
Nicolas Ritouet
@NicolasRitouet
May 25 2015 20:58
yep, I remember now
Andrei Alecu
@andreialecu
May 25 2015 20:59
@rgolea that PR was merged deployd/deployd#572
Nicolas Ritouet
@NicolasRitouet
May 25 2015 21:00
damn, build is broken
Andrei Alecu
@andreialecu
May 25 2015 21:00
restarting
Nicolas Ritouet
@NicolasRitouet
May 25 2015 21:00
I already did :(
Andrei Alecu
@andreialecu
May 25 2015 21:00
and still broken?
looks like it's passing now
Nicolas Ritouet
@NicolasRitouet
May 25 2015 21:01
cool
Andrei Alecu
@andreialecu
May 25 2015 21:01
travis sometimes randomly breaks builds
Nicolas Ritouet
@NicolasRitouet
May 25 2015 21:01
and weird
:)
Andrei Alecu
@andreialecu
May 25 2015 21:02
it was a 100ms timeout in one test
not being respected
from what I could gather
before restarting
Nicolas Ritouet
@NicolasRitouet
May 25 2015 21:02
indeed
Andrei Alecu
@andreialecu
May 25 2015 21:16
@NicolasRitouet just realized: https://github.com/deployd/deployd/blob/master/.travis.yml you may remove node 0.11, since it was unstable and never released for production, should speed up travis builds a bit
Nicolas Ritouet
@NicolasRitouet
May 25 2015 21:17
ok
Andrei Alecu
@andreialecu
May 25 2015 21:33
Looks like I finally got the attention of socket.io's maintainer after people complaining for two months and no response :) https://github.com/Automattic/socket.io/issues/2056#issuecomment-105319753
Nicolas Ritouet
@NicolasRitouet
May 25 2015 21:34
nice
then, I’ll wait to have the new version before I release
Andrei Alecu
@andreialecu
May 25 2015 21:34
Alright