Hey, @NicolasRitouet - making the dashboard a dpd module is a great idea!
I think it should be possible for a module to respond with text/html content and render its html at its endpoint, I don't remember there being anything that would prevent that
how could you do that? can the module know about the route and overwrite the rendering?
well suppose you have a dpd-event
it already has an url, and it returns some output at that url
you can even do it now, albeit a bit hacky by running something like
ctx.res.setHeader('content-type', 'text/html'); ctx.res.done('<html><body><h1>Hello</h1></body></html>');
inside that dpd-event
true
a bit hacky, but could work
if you were to create a real dpd module for the dashboard, you'd of course have access to the ctx right in the module so this wouldn't feel hacky
oh yeah
can you review and eventually approve this ticket: deployd/deployd#772 ?
alright, I see a problem though, it links to os-x instead of windows
true
good that we have a thorough review process :)
I’ll change this
hmm, regarding installing deployd globally, that's not necessarily a good idea, but without it the cli wouldn't be easily accessible via command line
I agree 100% with you
I hate installing modules globally, but as you said, we can’t do better at the moment
my plan is to extract the CLI part
I think it might be possible to easily hack the cli out into its own package, I'll give it some time right now and look at it
that would be awesome, I can also help
I remember looking at it before
the only problem I think would be for the tests, since they also use the cli to work, but the cli could come as a devDependency instead
wasn’t devDependencies not installed by default with npm3?
oh no
it was peerDependencies
interesting, I'm looking at my hard drive and I already have the cli extracted, I forgot why I didn't publish it
lol
it seems to work
actually
it's been here for 2 years apparently
ok
I’ll take a look
the CLI would need to bootstrap a boilerplate also
but it’s an awesome start
it does
true
I forgot
try
npm install -g andreialecu/deployd-cli
I know, I remember now
and
dpd create test123
then
cd test123 and dpd
I think the dependencies are outdated though
actually it doesn't have any
I made a few changes: https://github.com/deployd/deployd/pull/772/files
@NicolasRitouet I think the CLI extraction is done, could you test this: https://github.com/andreialecu/deployd/tree/refactor-extractcli ?
If all is well we should move my deployd-cli repo under
deployd in github, and I'll make a PR with this
mainly what is important is the ability to still run integration tests, and they seem to be running via the cli package that I extracted
looks good, I’ll take a look this evening