These are chat archives for deployd/contributors

26th
Oct 2016
Andrei Alecu
@andreialecu
Oct 26 2016 10:55
@NicolasRitouet the dashboard is its own resource in the main deployd package btw: https://github.com/deployd/deployd/blob/master/lib/resources/dashboard.js
I think we should also extract that to its own package
then deployd can be as barebones as possible, and everything else comes with additional plugins
Andrei Alecu
@andreialecu
Oct 26 2016 11:19
it would also make sense so that dpd-dashboard can be added as a devDependency so it doesn't make it to production servers
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 12:39
I also thought about it, making it only devDep by default
would be a big breaking change also for a lot of modules, I would see this as a 2.0
and 1.0 would be the current version
I know you don’t like this, but there’s no reason not to do it
Andrei Alecu
@andreialecu
Oct 26 2016 12:39
I don't think it is a breaking change
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 12:40
I reviewed a few modules yesterday and some of them uses the dashboard in some way
it as a quick review, maybe we can find a way not to break stuff, but we’ll have a to take a look
Andrei Alecu
@andreialecu
Oct 26 2016 12:40
yes but if the user installs the forthcoming dpd-dashboard module it should still work
without any other changes
I'm mainly talking about the UI for the dashboard
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 12:41
yeah, what I saw in the modules, was require of the Dashboard module
if it’s not in the core, it might break
Andrei Alecu
@andreialecu
Oct 26 2016 12:41
do you have an example?
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 12:41
but this is a detail, I don’t care about breaking change anyway
not now
at home
Andrei Alecu
@andreialecu
Oct 26 2016 12:41
ok
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 12:41
I’ll review this more in details
but that doesn’t change a lot, even with a breaking change, it is a good idea :)
with a lightweight core, we can have easier refactoring
I love that
Andrei Alecu
@andreialecu
Oct 26 2016 12:42
could you create the deployd-cli project on github? maybe fork mine, I don't seem to have permissions to do it myself
under deployd
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 12:43
dpd-cli or deployd-cli? important question :P
Andrei Alecu
@andreialecu
Oct 26 2016 12:43
well, the main package is called deployd
dpd-cli might seem like a module
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 12:43
you’re right
done, I gave you access
Andrei Alecu
@andreialecu
Oct 26 2016 12:51
deployd/deployd#776
travis is green
next step would be to publish deployd-cli to npm and reference it from npm in package.json
right now it's from github
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 12:58
can you publish it and make me also a maintainer on npm?
Andrei Alecu
@andreialecu
Oct 26 2016 13:08
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:14
well, then dpd-cli?
Andrei Alecu
@andreialecu
Oct 26 2016 13:16
how about something like deployd-dev-cli
it would reinforce it should only be used for dev purposes
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:16
I think many people will use it on production also
Andrei Alecu
@andreialecu
Oct 26 2016 13:17
which is a horrible idea
:)
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:17
not really
you might need to see the data
modify
add a user
Andrei Alecu
@andreialecu
Oct 26 2016 13:17
that's the dashboard
not the cli
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:17
ooohhh
true
sorry lol
Andrei Alecu
@andreialecu
Oct 26 2016 13:18
so deployd-dev-cli ?
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:18
let me think
not a big fan
Andrei Alecu
@andreialecu
Oct 26 2016 13:19
dpd-cli is confusing since we'd have deployd and dpd-cli
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:19
true
Andrei Alecu
@andreialecu
Oct 26 2016 13:19
and then modules are like dpd-event
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:19
let me see what the existing deployd-cli is
Andrei Alecu
@andreialecu
Oct 26 2016 13:19
I looked
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:19
that would be the best option
and?
Andrei Alecu
@andreialecu
Oct 26 2016 13:20
it's a chinese package, it does something with github, I don't know what
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:20
ok
Andrei Alecu
@andreialecu
Oct 26 2016 13:20
some git commands
@deployd/cli
Nicolas Ritouet
@NicolasRitouet
Oct 26 2016 13:24
I sent an email to the maintainer of deployd-cli, let’s see what he answers