by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Andrei Alecu
    @andreialecu
    which with the login stuff is probably mostly done now, there are still some things bugging me, like the lack of require() being available by default
    it's also something extremely likely someone will need
    but I have that fixed with a custom dpd extension
    Andrei Alecu
    @andreialecu
    @NicolasRitouet hey, there are lots of "Issues" on github that should be closed because they're more or less resolved. I'm looking through issues to see if there's any other bugs that could potentially be important. When you can, the issue list should be cleaned up.
    Andrei Alecu
    @andreialecu
    @NicolasRitouet @ericfong , I just implemented promises into the internal client aka deployd/deployd#375
    it can wait for 0.9 if you want although all tests pass and I made a test for it as well
    there's one thing you need to know though, I had to change from Q to Bluebird for Promises for this to work: https://github.com/petkaantonov/bluebird
    bluebird is faster than Q and a lot cooler actually so it shouldn't be a problem, it's completely compatible anyway
    Nicolas Ritouet
    @NicolasRitouet
    ok
    good to know
    regarding the issue list, that’s indeed a problem
    if you want, you can comment them and I can close them afterwards
    Andrei Alecu
    @andreialecu
    deployd/deployd#484
    Andrei Alecu
    @andreialecu
    now that I audit some of that code, that was there before, it looks like there could be a bug in it
    I kept this https://github.com/deployd/deployd/pull/484/files#diff-1635b4f24e4bb7c1006e010d10362130L187 because if was already there but it doesn't make sense, it will stop waiting for callbacks prematurely when other, non-callback functions are called in the script
    or actually not, nvm, it's ok -> but only because of a different bug :)
    they work together like it was on purpose
    I'll leave it like that
    maybe it was
    Andrei Alecu
    @andreialecu
    funny, leaving that line there is actually a bug in current deployd, the one without this PR I just made
    it would only occur if you called the internal client without a callback, though there was no reason to do that in theory
    Nicolas Ritouet
    @NicolasRitouet
    indeed, that’s weird
    Eric Fong
    @ericfong
    Sorry, over the weekend, I am too busy. Will catch up and rebase this two days
    Nicolas Ritouet
    @NicolasRitouet
    hey @ericfong , no need to be sorry, we're not a company, we're benevolent and it's already awesome what you're doing for the project !
    Andrei Alecu
    @andreialecu
    @ericfong did you get that memory leak sorted?
    Eric Fong
    @ericfong
    One month: 1 - 2 times restart. acceptable for me for my stage
    Andrei Alecu
    @andreialecu
    I was talking about that fix I made
    which was just committed
    did you see memory leaks after it? is memory usage still increasing?
    Eric Fong
    @ericfong
    I put that into my staging machine, which is still running (~500MB now).
    Andrei Alecu
    @andreialecu
    that sounds like a lot
    it shouldn't increase too much from a base value
    Eric Fong
    @ericfong
    Thanks @andreialecu for your PR. Let's try to follow the subject format in: https://github.com/deployd/deployd/blob/master/CONTRIBUTING.md#type
    https://github.com/deployd/deployd/blob/master/CONTRIBUTING.md#subject
    which don't capitalize first letter
    May be my problem have some internal problems. try to study that later
    Andrei Alecu
    @andreialecu
    deployd/deployd#484 I updated the code here
    didn't like checking for function name, I check if a promise is returned now
    Andrei Alecu
    @andreialecu
    @ericfong are you running your code with env=production?
    Eric Fong
    @ericfong
    YES
    Andrei Alecu
    @andreialecu
    ok, because that memory leak thing fix I did doesn't apply for development, it would still leak
    https://github.com/deployd/deployd/blob/master/lib/config-loader.js#L36 not sure why it wouldn't want to cache for development
    Eric Fong
    @ericfong
    may be other reasons. Thanks
    Andrei Alecu
    @andreialecu
    I think the reason is so that you can edit event scripts in a text editor instead of the dashboard without restarting the node process every time
    though that would be better done by watching the files for changes via fs.watch
    Andrei Alecu
    @andreialecu
    deployd/deployd#384 this can be closed probably
    Andrei Alecu
    @andreialecu
    deployd/deployd#480 any chance this could be merged soon-ish? It's innocent enough, only a testing infrastructure thing
    and as with the phantomjs runner, it's very important to ensure code correctness, I keep having to merge it and test then revert
    Andrei Alecu
    @andreialecu
    and by the way: deployd/deployd#476 , another positive side effect of the dpd cli change in this PR is that it tests if the cli works properly and can spawn a mongod instance. previously there were no tests for that - this at least ensures that npm test will fail if there is something wrong somewhere in /bin/dpd
    Nicolas Ritouet
    @NicolasRitouet
    @andreialecu , I just rebased your PR, thx
    Andrei Alecu
    @andreialecu
    just saw that, thx
    I'm fixing something else I found, just caught it while working on my stuff