by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Eric Fong
    @ericfong
    Take care
    Andrei Alecu
    @andreialecu

    Git Commit Guidelines

    We have very precise rules over how our git commit messages can be formatted. This leads to more readable messages that are easy to follow when looking through the project history. But also, we use the git commit messages to generate the AngularJS change log.

    :)
    I'm thinking about making my first merge, with this: deployd/deployd#535
    unless someone else wants to
    Nicolas Ritouet
    @NicolasRitouet
    go ahead @andreialecu
    what do you guys think about this one: deployd/deployd#490
    can we find a better solution?
    Nicolas Ritouet
    @NicolasRitouet
    @andreialecu you are on fire ! :clap:
    Eric Fong
    @ericfong
    I would like to have a temp solution
    Andrei Alecu
    @andreialecu
    I think we can merge it like that
    but has someone tested it manually?
    ensured it works with either the function call and/or the dpd.js script element?
    Eric Fong
    @ericfong
    Personally, I have done some, but may need to do one for rebasing to the new master
    Andrei Alecu
    @andreialecu
    it may be tested via sinon
    with some mocks maybe
    mock io.connect and check if it's called with proper parameters
    and the XHR object
    I'll take a stab at it
    and send you a PR with tests
    if I can figure something out
    send it to your branch I mean ericfong:urlBase
    Eric Fong
    @ericfong
    Yes. please. sleep first
    Andrei Alecu
    @andreialecu
    @ericfong here you go: ericfong/deployd#1
    Andrei Alecu
    @andreialecu
    hey guys, so I just gutted the CLI out of deployd and made this: https://github.com/andreialecu/deployd-cli
    Andrei Alecu
    @andreialecu
    I think this is the only thing that should be installed globally, with deployd installed locally
    grunt does the same
    the cli is global, but grunt is local in node_modules
    I changed dpd create in this to create a package.json that has deployd in it, and then run npm install so it seems to all just work
    Andrei Alecu
    @andreialecu
    also, I made a fork without the cli here: https://github.com/andreialecu/deployd/tree/remove-cli
    Eric Fong
    @ericfong
    WOW, Good move for separating dpd cli and deployd core
    Andrei Alecu
    @andreialecu
    I'll work on it some more and maybe we can move the deployd-cli repo to deployd/
    and merge the removal
    Andrei Alecu
    @andreialecu
    hey @ericfong, when you have time, can you address the spacing/comments in #490 so we can merge it? thanks!
    Eric Fong
    @ericfong
    Done

    BTW, using atom, any way to make the auto indent work as

    var x = 1
      , b = 2

    instead of

    var x = 1
    , b = 2

    ?

    Andrei Alecu
    @andreialecu
    no idea, I indent manually
    but don't use atom
    Andrei Alecu
    @andreialecu
    @ericfong I just merged it, ty :)
    Eric Fong
    @ericfong
    Thx
    Andrei Alecu
    @andreialecu
    probably high priority merge: deployd/deployd#541 it can be a denial of service just calling login with an existing username but without a password in the body, I verified it crashes the deployd process
    if someone can review (simple change really) and merge, or I can merge it myself after someone signs off on it
    Nicolas Ritouet
    @NicolasRitouet
    will you add the tests from @Maddis1337 ?
    Andrei Alecu
    @andreialecu
    @NicolasRitouet I understand the confusion, I had it too, but @Maddis1337 has a different PR than mine, his tests dont apply
    it will need to be merged separately
    Nicolas Ritouet
    @NicolasRitouet
    ok
    Andrei Alecu
    @andreialecu
    the link for the windows installer here is still 0.7.0
    I think we should deprecate the installer in favor of plain npm install