by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Andrei Alecu
    @andreialecu
    send it to your branch I mean ericfong:urlBase
    Eric Fong
    @ericfong
    Yes. please. sleep first
    Andrei Alecu
    @andreialecu
    @ericfong here you go: ericfong/deployd#1
    Andrei Alecu
    @andreialecu
    hey guys, so I just gutted the CLI out of deployd and made this: https://github.com/andreialecu/deployd-cli
    Andrei Alecu
    @andreialecu
    I think this is the only thing that should be installed globally, with deployd installed locally
    grunt does the same
    the cli is global, but grunt is local in node_modules
    I changed dpd create in this to create a package.json that has deployd in it, and then run npm install so it seems to all just work
    Andrei Alecu
    @andreialecu
    also, I made a fork without the cli here: https://github.com/andreialecu/deployd/tree/remove-cli
    Eric Fong
    @ericfong
    WOW, Good move for separating dpd cli and deployd core
    Andrei Alecu
    @andreialecu
    I'll work on it some more and maybe we can move the deployd-cli repo to deployd/
    and merge the removal
    Andrei Alecu
    @andreialecu
    hey @ericfong, when you have time, can you address the spacing/comments in #490 so we can merge it? thanks!
    Eric Fong
    @ericfong
    Done

    BTW, using atom, any way to make the auto indent work as

    var x = 1
      , b = 2

    instead of

    var x = 1
    , b = 2

    ?

    Andrei Alecu
    @andreialecu
    no idea, I indent manually
    but don't use atom
    Andrei Alecu
    @andreialecu
    @ericfong I just merged it, ty :)
    Eric Fong
    @ericfong
    Thx
    Andrei Alecu
    @andreialecu
    probably high priority merge: deployd/deployd#541 it can be a denial of service just calling login with an existing username but without a password in the body, I verified it crashes the deployd process
    if someone can review (simple change really) and merge, or I can merge it myself after someone signs off on it
    Nicolas Ritouet
    @NicolasRitouet
    will you add the tests from @Maddis1337 ?
    Andrei Alecu
    @andreialecu
    @NicolasRitouet I understand the confusion, I had it too, but @Maddis1337 has a different PR than mine, his tests dont apply
    it will need to be merged separately
    Nicolas Ritouet
    @NicolasRitouet
    ok
    Andrei Alecu
    @andreialecu
    the link for the windows installer here is still 0.7.0
    I think we should deprecate the installer in favor of plain npm install
    like for mac os x
    Nicolas Ritouet
    @NicolasRitouet
    if we can find a way to avoid installing mongo (tingodb?), that’s an option
    Nicolas Ritouet
    @NicolasRitouet
    @andreialecu I rebased your PR
    Andrei Alecu
    @andreialecu
    @NicolasRitouet can you restart this test? https://travis-ci.org/deployd/deployd
    seems to have failed
    Nicolas Ritouet
    @NicolasRitouet
    you should also have the rights to restart the build
    Nicolas Ritouet
    @NicolasRitouet
    it keeps failing :(
    Andrei Alecu
    @andreialecu
    it fails locally too
    I know what's wrong
    there's a bug in one of the PRs
    Nicolas Ritouet
    @NicolasRitouet
    just to know, can you restart the build on travis?
    I think you can
    Andrei Alecu
    @andreialecu
    what's the procedure?
    Nicolas Ritouet
    @NicolasRitouet
    you should have an icon on the travis page
    to restart the latest build
    you have to login I guess
    Andrei Alecu
    @andreialecu
    deployd/deployd#542
    Nicolas Ritouet
    @NicolasRitouet
    hey @/all
    do we need a new release? (0.8.1?)
    Eric Fong
    @ericfong
    I think so
    Nicolas Ritouet
    @NicolasRitouet
    ok
    others, any objection?