Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Andrei Alecu
    @andreialecu
    is it ok to merge this directly via github?
    been sitting there for over a year and I just saw it
    and I need it in my app
    Nicolas Ritouet
    @NicolasRitouet
    I think it’s ok
    Andrei Alecu
    @andreialecu
    shall I change the version to 0.0.3 here: https://github.com/deployd/dpd-event/blob/master/package.json
    and could you perhaps publish it to npm?
    Nicolas Ritouet
    @NicolasRitouet
    unfortunately, I’m not the maintainer of npm: https://www.npmjs.com/package/dpd-event
    I can ask Richie to change that
    would you be the maintainer for this module?
    Andrei Alecu
    @andreialecu
    I could, yes
    Nicolas Ritouet
    @NicolasRitouet
    all right
    can you give me your email and your npm username? (in private if you prefer)
    Nicolas Ritouet
    @NicolasRitouet
    @andreialecu ?
    Nicolas Ritouet
    @NicolasRitouet
    hey guys
    I sent a PR with some dependency updates
    once it’s rebased and tested by someone else, I’ll release 0.8.1 (hopefully tomorrow evening)
    I assigned @ericfong but if @andreialecu is available, you can also review and rebase it
    0ff
    @0ff
    Hey @NicolasRitouet we ran into some serious memory issues with 0.8.0, do you happen to monitor memory usage of your instances? Is it due to some extension? In very bad situations it was +2MB/request, even for 404s, with no cleanup. We're still looking for the culprit, just checking in with you to see if you might know something?
    Nicolas Ritouet
    @NicolasRitouet
    damn
    I know that Eric and Andrei worked on improving memory consumption
    I think that their improvements didn’t make it for 0.8.0, it may be in 0.8.1 (that I plan to release soon)
    0ff
    @0ff
    Hm, would you happen to know what exactly they are working on (is there a branch somewhere?). Maybe they've already found what we're still looking for? :)
    Nicolas Ritouet
    @NicolasRitouet
    they submitted some bug fixes that also improve memory consumption I think
    but again, I'm not sure, let's wait for them to tell us more about this
    Eric Fong
    @ericfong
    Please takle a look if you are interested
    deployd/deployd#496
    Nicolas Ritouet
    @NicolasRitouet
    @ericfong I’ll release this evening if I don’t feel too bad (I’m homesick), can you update the docs regarding this PR: deployd/deployd#496 ?
    I’ll link to the docs in the history.md
    0ff
    @0ff
    @NicolasRitouet with the latest version of master, I cannot get into the dashboard. I think (though that's just a wild guess) this is related to updating ejs. The error is the following: ejs:58\n 56| \n 57| <script type=\"text/html\" id=\"resource-sidebar-template\">\n >> 58| <% var type = types[resource.type]; %>\n 59| <% var isCurrent = resource.id === Context.resourceId %>\n 60| <li <%= isCurrent ? 'class=\"active\"' : '' %>>\n 61| <a href=\"/dashboard/<%= resource.id %>\" <%= type && type.dashboardPages ? 'class=\"pages-header\"' : '' %>>\n\ntypes is not defined
    Using deployd/deployd@5331ac3 instead of master works just fine.
    Downgrading ejs to ejs@1.0.0 also works fine, so it is indeed related to this upgrade.
    0ff
    @0ff
    Update on memory issues: I was able to get memory usage down by a factor of ~20 through updating to the latest master (-1, see my messages above). There's still memory that will not be freed, it just takes way longer. I was thinking about integrating memwatch, do you guys have any pointers/tips to debug memory usage?
    Nicolas Ritouet
    @NicolasRitouet
    @0ff thx for the info for ejs, I’ll take a look at that this week-end. @ericfong, don’t rebase my PR then, we’ll have to modify something
    Oops, already rebased
    can somebody take a look at this? I won’t be able to investigate until this week-end
    Eric Fong
    @ericfong
    I will do that tonight (within 8 hour from now). I think may only revert the ejs.
    Eric Fong
    @ericfong
    Fixed the dashboard problem by
    deployd/deployd#548
    Please review or rebase if you have time.
    Andrei Alecu
    @andreialecu
    Hey, sorry for not merging that. I was away this weekend, Just got back today. I submitted a new fix at #552.
    Feel free to review when you have time.
    Nicolas Ritouet
    @NicolasRitouet
    hey guys
    I plan to release 0.8.1, anybody against it?
    Eric Fong
    @ericfong
    +1. Thx
    Andrei Alecu
    @andreialecu
    +1
    Nicolas Ritouet
    @NicolasRitouet
    I’ll release tomorrow guys, I’ve been caught by something else
    Nicolas Ritouet
    @NicolasRitouet
    0.8.1 released
    let me know if you find some issues
    Andrei Alecu
    @andreialecu
    not sure how it happens that I always find bugs immediately after releases
    deployd/deployd#554
    this can be pretty bad, as you can crash deployd just by issuing a DELETE to an arbitrary id that doesn't exist
    0.8.1.1 ? :)
    I may be to blame for this bug in deployd/deployd@462c676