Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Nicolas Ritouet
    @NicolasRitouet
    I know that Eric and Andrei worked on improving memory consumption
    I think that their improvements didn’t make it for 0.8.0, it may be in 0.8.1 (that I plan to release soon)
    0ff
    @0ff
    Hm, would you happen to know what exactly they are working on (is there a branch somewhere?). Maybe they've already found what we're still looking for? :)
    Nicolas Ritouet
    @NicolasRitouet
    they submitted some bug fixes that also improve memory consumption I think
    but again, I'm not sure, let's wait for them to tell us more about this
    Eric Fong
    @ericfong
    Please takle a look if you are interested
    deployd/deployd#496
    Nicolas Ritouet
    @NicolasRitouet
    @ericfong I’ll release this evening if I don’t feel too bad (I’m homesick), can you update the docs regarding this PR: deployd/deployd#496 ?
    I’ll link to the docs in the history.md
    0ff
    @0ff
    @NicolasRitouet with the latest version of master, I cannot get into the dashboard. I think (though that's just a wild guess) this is related to updating ejs. The error is the following: ejs:58\n 56| \n 57| <script type=\"text/html\" id=\"resource-sidebar-template\">\n >> 58| <% var type = types[resource.type]; %>\n 59| <% var isCurrent = resource.id === Context.resourceId %>\n 60| <li <%= isCurrent ? 'class=\"active\"' : '' %>>\n 61| <a href=\"/dashboard/<%= resource.id %>\" <%= type && type.dashboardPages ? 'class=\"pages-header\"' : '' %>>\n\ntypes is not defined
    Using deployd/deployd@5331ac3 instead of master works just fine.
    Downgrading ejs to ejs@1.0.0 also works fine, so it is indeed related to this upgrade.
    0ff
    @0ff
    Update on memory issues: I was able to get memory usage down by a factor of ~20 through updating to the latest master (-1, see my messages above). There's still memory that will not be freed, it just takes way longer. I was thinking about integrating memwatch, do you guys have any pointers/tips to debug memory usage?
    Nicolas Ritouet
    @NicolasRitouet
    @0ff thx for the info for ejs, I’ll take a look at that this week-end. @ericfong, don’t rebase my PR then, we’ll have to modify something
    Oops, already rebased
    can somebody take a look at this? I won’t be able to investigate until this week-end
    Eric Fong
    @ericfong
    I will do that tonight (within 8 hour from now). I think may only revert the ejs.
    Eric Fong
    @ericfong
    Fixed the dashboard problem by
    deployd/deployd#548
    Please review or rebase if you have time.
    Andrei Alecu
    @andreialecu
    Hey, sorry for not merging that. I was away this weekend, Just got back today. I submitted a new fix at #552.
    Feel free to review when you have time.
    Nicolas Ritouet
    @NicolasRitouet
    hey guys
    I plan to release 0.8.1, anybody against it?
    Eric Fong
    @ericfong
    +1. Thx
    Andrei Alecu
    @andreialecu
    +1
    Nicolas Ritouet
    @NicolasRitouet
    I’ll release tomorrow guys, I’ve been caught by something else
    Nicolas Ritouet
    @NicolasRitouet
    0.8.1 released
    let me know if you find some issues
    Andrei Alecu
    @andreialecu
    not sure how it happens that I always find bugs immediately after releases
    deployd/deployd#554
    this can be pretty bad, as you can crash deployd just by issuing a DELETE to an arbitrary id that doesn't exist
    0.8.1.1 ? :)
    I may be to blame for this bug in deployd/deployd@462c676
    sorry
    paging @NicolasRitouet / @ericfong for review and merge
    Eric Fong
    @ericfong
    rebased
    Nicolas Ritouet
    @NicolasRitouet
    so, 0.8.2 ?
    @andreialecu any other bug you found before I release again?
    Andrei Alecu
    @andreialecu
    not yet :)
    not yet, haven't found any bug, I mean
    yes, you can release
    Nicolas Ritouet
    @NicolasRitouet
    Andrei Alecu
    @andreialecu
    @NicolasRitouet @ericfong please take a look at deployd/deployd#555 when possible
    I want to work on an Authorize event (that runs pre GET/POST/PUT/DELETE and allows inspecting query, or whether the user is authenticated, etc, and canceling the request) and we need to merge this first so I have a clean base to work on
    Nicolas Ritouet
    @NicolasRitouet
    hey guys
    would you like to have a video chat with only contributors in the future to discuss about deployd?
    Eric Fong
    @ericfong
    I think that is good idea to know the way to do. (I am in +8 timezone BTW)
    Nicolas Ritouet
    @NicolasRitouet
    guys, I think you’re right, the cli is a pain to support in its current state
    Nicolas Ritouet
    @NicolasRitouet
    damn @andreialecu , you’re on fire :D
    Andrei Alecu
    @andreialecu
    I've been working hard these past few weeks on getting my app ready for an event that just finished yesterday
    so I have some time again
    Nicolas Ritouet
    @NicolasRitouet
    awesome